1. 12 Jun, 2019 1 commit
  2. 10 Jun, 2019 2 commits
  3. 06 Jun, 2019 5 commits
    • Noah Davis's avatar
      Change Text Selection icon to edit-select-text · 2c39981b
      Noah Davis authored
      Summary:
      The current icon (draw-text) is semantically incorrect. This patch makes the Text Selection tool use the icons added in D21632.
      
      BUG: 408391
      FIXED-IN: 1.8.0
      
      Test Plan: {F6874885, size=full}
      
      Reviewers: #vdg, #okular, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21633
      2c39981b
    • Noah Davis's avatar
      Change Browse icon back to the hand shape · 9310bed6
      Noah Davis authored
      Summary: I changed the `input-mouse` icon so that it would look more like a real mouse. In order to keep the proper icon for the Browse tool, I have to change the icon to `transform-browse`.
      
      Test Plan: {F6874739, size=full}
      
      Reviewers: #okular, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21630
      9310bed6
    • Nate Graham's avatar
      In Toolbar's selection mode menu, show "Text Selection" tool by default · e8473354
      Nate Graham authored
      Summary:
      Currently, the Toolbar's selection mode menu shows the rectangular selection mode
      by default, which is not the most useful or commonly used selection mode.
      
      This patch makes the Text Selection tool the one that's shown by default, since that's
      the kind of selection that's the most useful given the sort of document that Okular
      is typically used to view.
      
      Test Plan:
      - Delete `~/.config/okularrc` and `~/.config/okularpartrc`
      - Open Okular
      - See that the selection mode toolbar button shows Text Selection by default:
      {F6874497, size=full}
      
      Reviewers: #okular, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21624
      e8473354
    • Nate Graham's avatar
      Use a more conventional dropdown menu style instead of press-and-hold · c7924445
      Nate Graham authored
      Summary:
      Currently, `ToolAction` menus (of which there is only one, the selection tool menu)
      activate the current tool on click, and require a click-and-hold to choose a new tool.
      This is a somewhat unfamiliar user interface that I myself struggled with when initially
      encountering it, and I've encountered user complaints about it as well.
      
      This patch adjusts the behavior so that clicking on the arrow on the right side of the
      button will open the pop-up and allow choosing another tool, which is a more common
      method of implementing the feature. The patch also adjusts the tooltop accordingly.
      
      Test Plan: {F6874466, size=full}
      
      Reviewers: #okular, #vdg, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: ndavis, abetts, filipf, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21622
      c7924445
    • Nate Graham's avatar
      Regularize tool names · c325cb41
      Nate Graham authored
      Summary:
      Currently, some of the items in the {nav Tools} menu have "tool" in the name, and some
      do not. This is in any event redundant since they're in a menu with that word in it
      already. In the toolbar, these actions become more inconsistent since their names change
      and can even differ between what's shown in the pop-up menu and what's shown on the
      button text.
      
      This patch regularizes the names, stops changing the names for the toolbar versions, and
      updates the docbook accordingly.
      
      Test Plan:
      {F6874459, size=full}
      
      {F6874458, size=full}
      
      Reviewers: #okular, #vdg, filipf
      
      Reviewed By: #vdg, filipf
      
      Subscribers: filipf, okular-devel, kde-doc-english
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D21621
      c325cb41
  4. 04 Jun, 2019 2 commits
  5. 03 Jun, 2019 4 commits
  6. 02 Jun, 2019 1 commit
  7. 01 Jun, 2019 2 commits
    • Tobias Deiminger's avatar
      Add icons for line annotation arrow styles to combo box · 1b89f220
      Tobias Deiminger authored
      Summary:
      Use `LineAnnotPainter` to generate accurate icons.
      
      Looks like this:
      {F6852054}
      
      Depends on D21248
      
      Test Plan:
      - open "Edit annotation tool" for straight line and check combo box items for start and stop style
      - test on HiDPI
      
      Reviewers: #okular, sander
      
      Reviewed By: sander
      
      Subscribers: davidhurka, knambiar, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21416
      1b89f220
    • Tobias Deiminger's avatar
      Add line annotation ending arrows for non PDF documents · d0e3a77d
      Tobias Deiminger authored
      Summary:
      This implements drawing the various line ending styles for 2 point lines in non-PDF documents.
      
      Looks like this:
      {F6833437}
      
      CCBUG: 381629
      
      Test Plan:
      - open a *.txt document
      - draw line annotations with different arrow styles: Square, Diamond, OpenArrow, ClosedArrow, ROpenArrow, RClosedArrow, Butt, Slash, Circle
      - ... as start and as end style (start needs D21238 to be configurable in GUI)
      - ... filled or not (fill color can't be configured in GUI yet)
      - ... with different leader line settings
      - ... at various angles
      - rotate and scale page
      - leader line with setting 100 gives 100 pixel line at 100% zoom (use kruler to verify)
      
      Reviewers: #okular, aacid, sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, knambiar, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21248
      d0e3a77d
  8. 27 May, 2019 3 commits
  9. 26 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add line start/end style config only for Straight Line tool · b1c30cd0
      Rajeesh K V authored
      Summary:
      “Inner Color” configuration of Polygon tool was overlapping with the line start/end styles intended for only Straight Line tool. Fix it.
      
      CCBUG: 381629
      
      Test Plan:
      1. Configure annotations
      2. Create/Edit Polygon tool
      3. Observe that no Line Start/End styles are visible
      4. Create/Edit Straight Line tool
      5. Observe that line start/end styles can be configured
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21332
      b1c30cd0
  10. 22 May, 2019 10 commits
  11. 21 May, 2019 1 commit
    • Kezi Olio's avatar
      Make selection scrolling go at 60 fps · e971c67c
      Kezi Olio authored
      Summary:
      When you select a square with the right mouse button, and you go past the margin of the window (but where there is still space to go), okular scrolls the document so you can select more.
      With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same
      
      Reviewers: #okular, aacid, sander, ngraham
      
      Reviewed By: sander, ngraham
      
      Subscribers: sander, ngraham, aacid, ahmedbilal, okular-devel, kezik
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D20437
      e971c67c
  12. 19 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line start style for Straight Line tool · 59a86c3f
      Rajeesh K V authored
      Summary: Similar to the line ending style, add support for line start style for the Straight Line annotation tool
      
      Test Plan:
      1. Go to Configure annotations
      2. Create (or edit existing) Straight Line tool
      3. Set the ‘Line Start’ option on Style and Apply
      4. Use the Straight Line tool to draw a line and check the line starting style.
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: ngraham, tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21238
      59a86c3f
  13. 14 May, 2019 2 commits
    • Tobias Deiminger's avatar
    • Tobias Deiminger's avatar
      Fix line annotation leader line angle · a0045a97
      Tobias Deiminger authored
      Summary:
      For "Straight Line" annotations, the "Leader Lines" (if any) shall be perpendicular to the main line segment. Current code missed to consider page aspect ratio when calculating the main segment angle, which caused non-perpendicular leader lines.
      
      Note: Bug is only visible with non-PDF documents (i.e. where Okular draws line annotation, instead of generator).
      
      Before:
      {F6818453}
      
      After:
      {F6818452}
      
      Test Plan:
      - open a txt file, the generated page will have aspect ratio 3:4
      - configure a "Straight Line" annotation with long leader line
      - create a line annotation at 45 degree angle
      - check the leader line, it shall be perpendicular to the main line
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21136
      a0045a97
  14. 12 May, 2019 1 commit
  15. 11 May, 2019 2 commits
  16. 09 May, 2019 1 commit
  17. 08 May, 2019 1 commit