Artem Grinev (da648df7) at 25 Mar 17:42
Follow breeze!435
Artem Grinev (da648df7) at 15 Mar 12:42
gtk3,gtk4: Remove visible scrollbar trough
... and 91 more commits
I strongly agree with that choice but don't we have this new light/dark wallpaper feature that might be needed to be advertised via the default?
@ngraham It's anyway needed to work around Mozilla's GTK support flaw so I can provide a MR that decreases borders for Thunderbird.
I'm afraid this is not a fix at all as this will lead to this:
as this code was a trick to emulate tab overlapping using CSS.
I can reproduce this behavior only with those modern GNOME-like tabs and not classic ones, can you confirm that only they are affected?
This reverts commit 8042ae81.
This change slightly improved performance, but subtle implementation differences between the onEntered: and onPositionChanged: handlers in MouseArea triggered two subtle and annoying bugs that users have reported a bunch of duplicates of.
A way to fix the bugs using onEntered has not been found, so let's revert the change for now; slightly worse performance is a less severe issue then these bugs are.
BUG: 454349 BUG: 455674 FIXED-IN: 5.25.5
So we don't have to implement the theme lookup mechanism by ourselves and rely on canberra, which is even better. I apologize, I thought Phonon is still preferred.
The thing here also is that GTK apps use libcanberra
directly for mentioned usecases so moving them to a workspace-side won't help us much in supporting more (at least GTK-based) apps.
CC @sitter @broulik (I hope those are right people) as ones who were working on current NotifyByAudio
via Phonon implementation to know if it makes sense from the code perspective.
My proposal is here: #47
With the discussion of the new Blue Ocean theme there came an idea to create a new KCM for sounds theme. The most obvious idea is to use XDG Sound Theme spec which currently KDE software lacks.
As far as I understand all KF5 apps rely on KNotifications for event producing and configuration. The sound file is defined in the corresponding notifyrc file and being played by KNotifications via libcanberra or phonon by a file URL.
XDG specification defines names of sounds and an algorithm of getting a particular file name using the sound's name and a selected theme name.
My idea is to extend notifyrc files with the support of system sound name field and a new SystemSound
event action which will lookup and play the sound by it's name. The event configuration window will allow users to select if they want to use a sound file or a sound name. kdeglobals
will get a new field for the sound theme
This mechanism will allow us to use GNOME sounds themes (such as Ubuntu's Yaru), sync sounds with GTK and create a KCM for the sound sets management. This also won't change anything for apps, only the sound name could be added declaratively to the existing event configuration.
I really hope I got the whole existing architecture right and my proposal makes any sense. I'd be glad to hear any ideas, corrections and improvements.
Edit (by @iasensio): If you allow me, I'd like to use this issue to track the on-going progress and the required tasks to achieve the proposal.
(General sub-task: #40)
If it's going to be a thing in the future, I would like to see plasma-workspace!1708 (merged) implemented here in some way.
I'd like to implement a sound theme support (following the XDG standard) with KCM, now doing a research about how sounds work in Plasma.
Artem Grinev (2b25cdad) at 02 Jun 15:54
@ngraham now checkboxes are (almost) a pixel-perfect copy of QStyle checkboxes including both color and checkmark appearance
Artem Grinev (2b25cdad) at 02 Jun 07:55
GTK3,4: Make checkbox colors a pixel-perfect copy of QStyle
... and 1 more commit
Artem Grinev (fb30186c) at 28 May 11:29
assets: Make checkmark a pixel-perfect copy of QStyle
I provide this code directly to the project maintainers
What do you mean? @ngraham is one of the project's maintainers.
This MR doesn't affect menubars for me, only produces too narrow regular menu items. Which app you plan to fix with this change?