GitLab

Inspired by kdenlive, this small patch adds the option to show/hide the
titlebars of all dockers to the settings menu.

Patch by Moritz Molch. Thanks!
CCMAIL:kde@moritzmolch.de
REVIEW:122753

And try really hard to remember the last used preset for all input
devices.

This should fix the crash.

This is perfectly fine, it occurs already when creating a filter mask,
so no reason to warn the user.

Maybe that'll convince people it isn't an open document...

If a part of a path started with a number, KoStore pre 2.9 would prepend
'part'. We don't do that anymore, but there are files out there with that
weirdness, so check whether the path can be opened, and if it can't,
fix it up.

V571 Recurring check. The 'm_canvas->viewManager()' condition was already verified in line 128. kis_color_selector_ng_docker_widget.cpp 129

V519 The 'desk' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 2109, 2110. kismainwindow.cpp 2110

V808 'applyRects' object of 'QStack' type was created but was not utilized. kis_async_merger.cpp 154

Make the code cleaner

V571 Recurring check. The 'm_closeSnappingActivated' condition was already verified in line 92. kis_tool_polyline_base.cpp 93

V802 On 64-bit platform, structure size can be reduced from 24 to 16 bytes by rearranging the fields according to their sizes in decreasing order. kis_base_iterator.h 28

Mistake when porting to new NG iterators.

V715 The 'while' operator has empty body. Suspicious pattern detected: 'if (expr) {...} while (it->nextPixel()) ;'. kis_png_converter.cpp 1126

V501 There are identical sub-expressions 'k_glGetSynciv == 0' to the left and to the right of the '||' operator. kis_opengl_canvas2_p.h 344

V611 The memory was allocated using 'new T[]' operator but was released using the 'delete' operator. Consider inspecting this code. It's probably better to use 'delete [] transfers;'. kis_perchannel_filter.cpp 501

V501 There are identical sub-expressions 'image.width() > 128' to the left and to the right of the '&&' operator. kis_brush.cpp 270

Such as: The review tool and the references tool

V570 The 'd->autoSpacingActive' variable is assigned to itself. kis_brush.cpp 163
V570 The 'd->autoSpacingCoeff' variable is assigned to itself. kis_brush.cpp 164

REVIEW:123002

It doesn't change the behavior, but at least understandable now.

Warning from PVS Studio
V646 Consider inspecting the application's logic. It's possible that
'else' keyword is missing. kis_sequential_iterator.h 147

http://www.viva64.com/en/d/0265/print/

V649 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 169, 171. kis_fill_painter.cc 171

V607 Ownerless expression 'pi.hThread'. kis_crash_handler.cpp 138

It still produces win builds with crashes

BUG:345142

And save as patch.