1. 27 May, 2020 1 commit
    • Nate Graham's avatar
      Improve the sidebar's navigation and UX · b8b36ae5
      Nate Graham authored
      Okular's sidebar vertical view chooser toolbar suffers from a few issues:
      
      * It's a nonstandard UI not used for category choosers in other pieces of KDE software,
        and not used in other FOSS document readers
      * What is shown and what is hidden is simultaneously too configurable while still not
        offering the desirable UI common to other programs (i.e. no visible category chooser,
        but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
      * With labels on it takes up quite a bit of horizontal space, while with labels off, the
        categories are less than clear
      * UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
        to hide that category's view while keeping the view chooser visible, showing mostly
        disabled items)
      * It's made with custom painting code, which reduces maintainability and introduces bugs
        (e.g. https://bugs.kde.org/show_bug.cgi?id=408190)
      
      This patch removes the vertical category chooser entirely and replaces it with a tabbed
      view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
      button is added on the left side of the default toolbar to quickly hide or show the
      sidebar. In order to make room for the new button, the Previous and Next buttons on the
      toolbar are removed, as previous/next buttons are already present on the Page Bar on the
      bottom of the window so there's no need to duplicate this functionality. This improves
      the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
      maintainability.
      
      ![vokoscreenNG-2020-04-16_13-29-24](https://invent.kde.org/graphics/okular/uploads/a1f96a315b69282df51de9993b1befaf/vokoscreenNG-2020-04-16_13-29-24.webm)
      
      BUG: 213508
      
      BUG: 334441
      
      BUG: 344599
      
      BUG: 408190
      
      CCBUG: 335189
      
      FIXED-IN: 1.11.0
      
      CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space
      b8b36ae5
  2. 26 May, 2020 1 commit
  3. 25 May, 2020 1 commit
    • Albert Astals Cid's avatar
      Fix ZoomIn getting stuck when on facing pages · 040e11c5
      Albert Astals Cid authored
      We need to use int when calculating colWidth in zoomFactorFitMode since
      we also use int when calculating it in PageView::slotRelayoutPages,
      otherwise the calculated numbers are veeeeeeery similar but not the same
      and the algorithm gets all confused
      
      BUGS: 420824
      040e11c5
  4. 24 May, 2020 1 commit
    • Albert Astals Cid's avatar
      Remove the "Page Sizes" action from the menu · 0ada1973
      Albert Astals Cid authored
      It's only enabled when the document supports multiple page sizes, that
      at the time of writing (and since 13 years) is none
      
      So not great to have an always disabled menu :D
      
      The backend part (Document::supportsPageSizes) is still there, so if we
      ever reintroduce a backend that supports it part of the code is there,
      and probably we may want to rethink the UI so it only shows when useful,
      and not being disabled without possibility of enabling it for say PDF
      0ada1973
  5. 23 May, 2020 5 commits
  6. 19 May, 2020 1 commit
  7. 17 May, 2020 2 commits
  8. 16 May, 2020 3 commits
  9. 15 May, 2020 1 commit
  10. 13 May, 2020 1 commit
  11. 12 May, 2020 1 commit
    • Albert Astals Cid's avatar
      Markdown: Support internal links · b1c02b7e
      Albert Astals Cid authored
      When processing the <a> elements, store in two maps those that contain
      an href="#Something" and those with name="Something" then once we've
      processed them all, go over the first map trying to find itself in the
      second
      
      BUGS: 421163
      b1c02b7e
  12. 11 May, 2020 5 commits
  13. 10 May, 2020 2 commits
  14. 05 May, 2020 4 commits
  15. 29 Apr, 2020 2 commits
  16. 25 Apr, 2020 2 commits
  17. 23 Apr, 2020 2 commits
  18. 20 Apr, 2020 2 commits
  19. 19 Apr, 2020 2 commits
    • Albert Astals Cid's avatar
      tweak spacing to make clang-10 happier · a4e044e6
      Albert Astals Cid authored
      The whole file is a mess, but in particular this was making a warning so
      let's fix it
      a4e044e6
    • David Hurka's avatar
      Generate presentation drawing tool icons in a custom QIconEngine, so... · ef488d33
      David Hurka authored
      Generate presentation drawing tool icons in a custom QIconEngine, so checkboxes can be sharp on hidpi
      
      The checkboxes in the drawing tool icons in the presentation toolbar were not sharp on hiDPI, this fixes it.
      
      The toolbar buttons are QActions with QIcons, and the icons were created from 25x25 pixmaps. That is usually smaller than the toolbar’s icon size, so the icons had a nice size. But at hiDPI, the icons were scaled up, so the checkmarks looked blurry.
      
      Now the icons are generated in the correct resolution on the fly, because the painting code from ColorAction::setColor() is moved to a custom QIconEngine inside ColorAction.
      ef488d33
  20. 18 Apr, 2020 1 commit