1. 18 Sep, 2019 1 commit
  2. 25 Jul, 2019 1 commit
    • Simone Gaiarin's avatar
      General improvements to stamp annotation · f15e8568
      Simone Gaiarin authored
      Summary:
      Configuration:
      - Add push button to select custom stamp image
      - Check if loaded image is usable as stamp or throw error
      - Keep image proportions in previewer
      - Move previewer below the combobox to display larger preview
      
      Annotation tool:
      - Keep stamp image proportion in annotation preview (while left mouse button is down)
      - Adding the annotation with one-click (without holding the left mouse button and dragging) adds the stamp with original proportions
      
      BUG: 370381
      BUG: 383652
      CCBUG: 383651
      FIXED-IN: 1.9.0
      
      Closes T8074
      
      TODO:
      - [ ] Check if filters in file chooser make sense / propose better alternative
      - [x] Update doc ( @yurchor will do it after we merge this)
      
      Test Plan:
      From stamp annotation configuration dialog:
      - Show a warning regarding limitations of the feature's current implementation
      - Click push button next to combo box opens a file selector
      - Selecting a corrupted image file should throw an error
      - Selecting a good image file shows the preview of the image
      - Select a horizontal image shows a large clear preview
      - Select a vertical image file shows a smaller preview without messing up the visual of the config dialog
      - Input a valid icon name in the combobox and the preview of the icon is shown
      
      From page view, select the stamp annotation with horizontal image file (not squared):
      - Click and hold. The preview maintains proportions
      - Single click. The stamp image in the pdf maintains proportions and has the same size of the click and hold preview.
      - Add an annotation of the Okular custom stamps (internal SVG so treated slightly differently) do not create problems
      
      Reviewers: #okular, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: pino, aacid, yurchor, ngraham, okular-devel
      
      Tags: #okular
      
      Maniphest Tasks: T8074
      
      Differential Revision: https://phabricator.kde.org/D22064
      f15e8568
  3. 24 Jun, 2019 1 commit
  4. 02 Jun, 2019 1 commit
  5. 01 Jun, 2019 2 commits
    • Tobias Deiminger's avatar
      Add icons for line annotation arrow styles to combo box · 1b89f220
      Tobias Deiminger authored
      Summary:
      Use `LineAnnotPainter` to generate accurate icons.
      
      Looks like this:
      {F6852054}
      
      Depends on D21248
      
      Test Plan:
      - open "Edit annotation tool" for straight line and check combo box items for start and stop style
      - test on HiDPI
      
      Reviewers: #okular, sander
      
      Reviewed By: sander
      
      Subscribers: davidhurka, knambiar, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21416
      1b89f220
    • Tobias Deiminger's avatar
      Add line annotation ending arrows for non PDF documents · d0e3a77d
      Tobias Deiminger authored
      Summary:
      This implements drawing the various line ending styles for 2 point lines in non-PDF documents.
      
      Looks like this:
      {F6833437}
      
      CCBUG: 381629
      
      Test Plan:
      - open a *.txt document
      - draw line annotations with different arrow styles: Square, Diamond, OpenArrow, ClosedArrow, ROpenArrow, RClosedArrow, Butt, Slash, Circle
      - ... as start and as end style (start needs D21238 to be configurable in GUI)
      - ... filled or not (fill color can't be configured in GUI yet)
      - ... with different leader line settings
      - ... at various angles
      - rotate and scale page
      - leader line with setting 100 gives 100 pixel line at 100% zoom (use kruler to verify)
      
      Reviewers: #okular, aacid, sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, knambiar, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21248
      d0e3a77d
  6. 26 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add line start/end style config only for Straight Line tool · b1c30cd0
      Rajeesh K V authored
      Summary:
      “Inner Color” configuration of Polygon tool was overlapping with the line start/end styles intended for only Straight Line tool. Fix it.
      
      CCBUG: 381629
      
      Test Plan:
      1. Configure annotations
      2. Create/Edit Polygon tool
      3. Observe that no Line Start/End styles are visible
      4. Create/Edit Straight Line tool
      5. Observe that line start/end styles can be configured
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21332
      b1c30cd0
  7. 19 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line start style for Straight Line tool · 59a86c3f
      Rajeesh K V authored
      Summary: Similar to the line ending style, add support for line start style for the Straight Line annotation tool
      
      Test Plan:
      1. Go to Configure annotations
      2. Create (or edit existing) Straight Line tool
      3. Set the ‘Line Start’ option on Style and Apply
      4. Use the Straight Line tool to draw a line and check the line starting style.
      
      Reviewers: #okular, tobiasdeiminger
      
      Reviewed By: tobiasdeiminger
      
      Subscribers: ngraham, tobiasdeiminger, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21238
      59a86c3f
  8. 12 May, 2019 1 commit
  9. 07 May, 2019 1 commit
    • Rajeesh K V's avatar
      Okular Annotation: add support for line ending style for Straight Line tool · db2dcdad
      Rajeesh K V authored
      Summary:
      Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the Straight Line tool. Expose the functionality in configuration and hook up the correct slots.
      
      Configure annotations (before):
      {F6788150}
      
      Configure annotations (after):
      {F6788151}
      
      Straight Line tool with Open Arrow end in action:
      {F6788153}
      
      Test Plan:
      1. Open a PDF in Okular
      2. Enable Review
      3. Right click on Review toolbar and Configure annotations
      4. Create (or edit existing) Straight Line tool
      5. Set the ‘Line End’ option on Style and Apply
      6. Use the Straight Line tool to draw a line and check the line ending style.
      
      Reviewers: #okular, #vdg, sander, ngraham
      
      Reviewed By: #vdg, sander, ngraham
      
      Subscribers: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D20760
      db2dcdad
  10. 04 Oct, 2018 1 commit
    • Dileep Sankhla's avatar
      Support setting text color for typewriter annotations · e44ff387
      Dileep Sankhla authored
      Summary:
      Changing typewriter text color can be done in the typewriter properties dialog, or programmatically via new okular API methods TextAnnotation::textColor and TextAnnotation::setTextColor.
      
      poppler >= 0.69 is required to store text color natively inside PDF documents. For other document types, text color is stored as metadata inside the document archive.
      
      This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.
      
      Test Plan:
      - properties dialog of typewriter annotation has "Font Color" picker
      - saving to PDF results in <r> <g> <b> rg operation in /DA
      - saving to archive results in fontColor="rrggbb" attribute in metadata.xml
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: kde-doc-english, sander, okular-devel
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D15205
      e44ff387
  11. 25 Sep, 2018 1 commit
    • Dileep Sankhla's avatar
      Add typewriter annotation tool · 6dd7cf66
      Dileep Sankhla authored
      Summary:
      Typewriter is originally specified by the PDF reference as special FreeText annotation, where Intent=FreeTextTypewriter. It features opaque letters on transparent background, so that users can fill non interactive forms. Herewith typewriter is implemented natively for PDF, and there's also an Okular specific implementation for other document types. The added tool reuses the inline note UI.
      
      This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.
      
      FEATURE: 353401
      
      Test Plan:
      - okularpartrc is generated (if not yet existing) with typewriter as 10th tool
      - typewriter tool is also available in Annotation Tools -> Add, Typ "Typewriter"
      - selecting the tool and left click into document opens inline note input dialog
      - finishing creates an annotation similar to inline note, but with transparent background
      - saving into PDF results in /Subtype FreeText /IT /FreeTextTypeWriter
      - saving typewriter into archive stores color with alpha channel = 0x00
      - opening annotated archive works, if archive was created with old Okular, and opened in patched Okular
      - opening annotated archive works, if archive was created with patched Okular, and opened in old Okular
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D15204
      6dd7cf66
  12. 05 Sep, 2017 1 commit
  13. 24 Nov, 2015 1 commit
  14. 29 Oct, 2015 1 commit
  15. 29 Jan, 2015 2 commits
  16. 23 Oct, 2014 1 commit
  17. 08 Oct, 2014 1 commit
  18. 06 Oct, 2014 2 commits
  19. 01 Oct, 2014 1 commit
  20. 16 Sep, 2014 1 commit
  21. 11 Sep, 2014 2 commits
  22. 09 Sep, 2014 1 commit
  23. 13 Aug, 2014 1 commit
  24. 10 Aug, 2014 1 commit
  25. 08 Aug, 2014 1 commit
  26. 18 May, 2013 1 commit
  27. 20 Apr, 2013 1 commit
    • Fabio D'Urso's avatar
      HighlightAnnotation text improvements · cfa8c3a6
      Fabio D'Urso authored
       - Changed property dialog title from "Highlight" to "Text Markup",
         because it's used for Underline, Squiggle and Strike out too.
       - Renamed Squiggly (adjective) to Squiggle (noun)
       - Show the precise type of HighlightAnnotation in the review panel and
         on right-click on a HighlightAnnotation
      cfa8c3a6
  28. 18 Apr, 2013 1 commit
  29. 29 Dec, 2012 1 commit
  30. 28 Dec, 2012 2 commits
  31. 31 Jul, 2011 1 commit
  32. 16 Nov, 2008 1 commit
  33. 20 Sep, 2008 2 commits
  34. 19 Sep, 2008 1 commit