1. 21 Feb, 2020 4 commits
  2. 21 Sep, 2019 1 commit
  3. 18 Sep, 2019 2 commits
  4. 07 Aug, 2019 1 commit
    • Andrey Yashkin's avatar
      Fix an incorrect text bounding rectangle calculation inside the sidebar · 5099b615
      Andrey Yashkin authored
      Summary:
      Now //fontBoundaries// always has smaller width than //boundingRect// from
      ```
      void QPainter::drawText(const QRect &rectangle, int flags, const QString &text, QRect *boundingRect = nullptr)
      ```
      which is required to enclose the whole text. The difference is only several pixels, but sometimes it can cause visual problems. You can see the sidebar without and with this patch in Russian language with Noto Sans 10pt font on a picture below.
      {F7177644}
      Now the first and the last symbols are fully visible.
      
      Reviewers: #okular
      
      Subscribers: okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D23012
      5099b615
  5. 13 Mar, 2019 1 commit
  6. 22 Sep, 2017 1 commit
    • Nathaniel Graham's avatar
      Fix sidebar labels being unreadable when selected or hovered over · e80972e1
      Nathaniel Graham authored
      Summary:
      BUG: 382139
      
      Previously these labels were white-on-light-blue with light themes; now they use the correct theme color property, and become black appropriately.
      
      Test Plan:
      Tested on KDE Neon (dev unstable). Verified that with the default Breeze color scheme, tab text is more readable when hovered over and then active but not in focus. See before and after:
      
      {F3909142}
      
      {F3909143}
      
      Also tested these changes with all standard color schemes as well as the Oxygen theme to make sure that there were no visual regressions.
      
      Reviewers: aacid, #okular, #kde_applications, broulik, sander, rkflx
      
      Reviewed By: aacid, #okular, #kde_applications, rkflx
      
      Subscribers: rkflx
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D7793
      e80972e1
  7. 05 Sep, 2017 1 commit
  8. 29 Oct, 2016 4 commits
  9. 24 Jul, 2016 3 commits
  10. 11 Jul, 2016 1 commit
  11. 15 Sep, 2015 1 commit
  12. 14 Sep, 2015 1 commit
  13. 18 Aug, 2015 1 commit
  14. 16 Aug, 2015 1 commit
  15. 12 Jul, 2015 1 commit
  16. 16 Mar, 2015 1 commit
  17. 19 Oct, 2014 1 commit
  18. 12 Oct, 2014 1 commit
  19. 01 Oct, 2014 2 commits
  20. 13 Aug, 2014 2 commits
  21. 08 Aug, 2014 1 commit
  22. 09 Apr, 2014 2 commits
  23. 20 Nov, 2013 1 commit
  24. 19 Feb, 2013 1 commit
  25. 13 Feb, 2013 1 commit
    • Eike Hein's avatar
      Port sidebar delegate to KColorScheme. · a3b3545c
      Eike Hein authored
      Certain KDE color schemes have Window Background and View Text
      not contrasting, which causes invisible icon labels when using
      QPalette::Text on QPalette::Base. An example is the default
      color scheme in openSUSE 12.3.
      
      Thanks to Will Stephenson for noticing.
      CCMAIL:wstephenson@kde.org
      
      It turns out that the Places sidebar in Dolphin suffers from
      the same bug, so a similar change should be done there. Frank?
      CCMAIL:frank78ac@googlemail.com
      a3b3545c
  26. 27 Dec, 2011 1 commit
  27. 15 Dec, 2011 1 commit
    • Albert Astals Cid's avatar
      Set a focus proxy in case this widget ends up with focus · ac79610a
      Albert Astals Cid authored
      Should never happen, but as it is the "main" widget of the part it might end up there if someone just says part->mainwidget->setfocus or something like that
      At least this way the focus does not go down the drain and ends up in the sidebar list, which is not optimal but is better than getting the keyboard focus lost
      ac79610a
  28. 31 Jul, 2011 1 commit