1. 07 Jan, 2019 6 commits
  2. 06 Jan, 2019 5 commits
  3. 05 Jan, 2019 2 commits
  4. 03 Jan, 2019 3 commits
  5. 01 Jan, 2019 1 commit
    • Anna Medonosová's avatar
      Advanced Color Selector: option to hide color selector · 52afd0cb
      Anna Medonosová authored
      Summary:
      I have resurrected the original patch by Ranveer Aggarwal, which enables the user to hide the
      color selector part of the docker.
      
      There was one issue with the original: the docker settings button is inside the color selector, therefore when you hide
      the selector, the only way to configure the docker is via the main menu, "Settings" -> "Configure Krita". To solve that I have added
      a fallback settings button to the docker widget, which appears when the color selector part is hidden.
      
      BUG: 337328
      
      Reviewers: #krita, rempt
      
      Reviewed By: #krita, rempt
      
      Subscribers: rempt
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D17893
      52afd0cb
  6. 28 Dec, 2018 2 commits
  7. 25 Dec, 2018 7 commits
    • Kuntal  Majumder's avatar
      Added a QSpinBox to adjust granularity while doing transforms · ea51095a
      Kuntal Majumder authored
      Summary:
      The patch adds a QSpinBox to the transform tool options to adjust the granularity while doing transforms.
      
      This patch fixes real transformation granularity only, preview
      granularity will be solved in the following patches.
      
      CCBUG:344210
      
      Reviewers: #krita, rempt, dkazakov
      Reviewed By: #krita, dkazakov
      Subscribers: #krita
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D17660
      ea51095a
    • Bernhard Liebl's avatar
      Less KisCanvasUpdatesCompressor contention · b56a0362
      Bernhard Liebl authored
      Reduces contention on the mutex in KisCanvasUpdatesCompressor
      by not getting updates one by one but in a batch (without this,
      there will be a constant list of 20 to 30 items in the list
      during drawing).
      
      This is a resurrected patch from Bernhard Liebl, which
      was accidentally forgotten in 2017 :(
      
      Differential Revision: https://phabricator.kde.org/D8022
      b56a0362
    • Dmitry Kazakov's avatar
      Insert new layer above selected group layer · 5f819ec9
      Dmitry Kazakov authored
      Summary: About a month ago or something I said in the irc channel that
      I'd t ake a look at inserting the new layers above the group layer if th
      e group layer is selected as opposed to inserting it in the group. The
      rationale is that you can already easily insert the layer in the group
      by selecting any layer inside that group, but if you want to insert the
      layer just above the group you're forced to do it in two steps: first
      insert the layer inside the group, then move the layer above the
      group (eg. with ctrl+pgup).  It's not a big deal, but I know at least
      one person that mentioned this before (don't remember if it was in irc
      or opened a bug).
      
      In any case it's a very tiny change that I finally got around to doing it.
      
      The patch by Razvan Radulescu (https://phabricator.kde.org/p/razvanr/)
      
      BUG:399103
      Reviewers: rempt, scottpetrovic, #krita
      Reviewed By: rempt, #krita
      Tags: #krita
      Differential Revision: https://phabricator.kde.org/D15523
      5f819ec9
    • Mehmet Salih Çalışkan's avatar
    • Dmitry Kazakov's avatar
      add exportConfiguration InfoObject to Node.save for predictable batchmode · 0c150e26
      Dmitry Kazakov authored
      Summary: As discussed with @rempt yesterday, I've modified `Node.save`
      to accept this `InfoOjbect` just like `Document.exportImage` in order to
      be able to save layers in batch mode with predictable output settings.
      
      As it happens, I can't get Krita working with Python on my PC due to
      incompatibilities between PyQt5 (v5.11.3) & Qt5 (v5.11.1) libraries. It
      can't easily be solved as I couldn't find compatible packages, there's
      no PyQt5 v5.11.1 release unfortunately and the change appears in v5.11.2
      
      Patch by Razvan Radulescu (https://phabricator.kde.org/p/razcore.art/)
      
      Reviewers: rempt, #krita
      Reviewed By: rempt, #krita
      Subscribers: rempt
      Tags: #krita
      Differential Revision: https://phabricator.kde.org/D17639
      0c150e26
    • Dmitry Kazakov's avatar
      overview docker: preserve aspect ratio and don't stretch when some layers are hidden · 9cee1d46
      Dmitry Kazakov authored
      Summary:
      Since 58e1c17a , the overview docker displays thumbnails for transparent layers incorrectly (e.g. when hiding the background layer or selectively displaying one single layer). The thumbnail is stretch with a wrong aspect ratio.
      A solid afternoon of debugging points that the final step of thumbnailing does not provide a size, hence the bounds of the KisPaintDevice are used instead, resulting in a size mismatch.
      The attached patch fixes this issue while preserving the fixes from the aforementioned patch.
      
      Note: in 4.1.3, the size also mismatched, but was centered without stretching/resizing in the overview docker with correct aspect ratio; however the canvas viewport outline was wrong.
      
      Test Plan:
      - Create a new A4/landscape image
      - Create a perfect circle somewhere near the bottom-left of the screen (i.e. not the top-left)
      - Check the overview thumbnail (state 1)
      - Hide the background layer
      - Check that the overview thumbnail is consistent with state 1: same position and correct aspect ratio for the circle
      
      Patch by Beuc (https://phabricator.kde.org/p/Beuc/)
      
      Reviewers: #krita, rempt
      Reviewed By: #krita, rempt
      Tags: #krita
      Differential Revision: https://phabricator.kde.org/D17695
      9cee1d46
    • Dmitry Kazakov's avatar
      Deref image shared pointers before calling ~KisDocument (#396985) · 1f14ab95
      Dmitry Kazakov authored
      Summary:
      Call the implicit KisImageSP destructor with scoping.
      
      Alternatively, we could remove the:
              // check if the image has actually been deleted
              KIS_SAFE_ASSERT_RECOVER_NOOP(!sanityCheckPointer.isValid());
      check from KisDocument which seems a bit possessive about its current image.
      
      Test Plan: Cf. https://bugs.kde.org/show_bug.cgi?id=396985
      
      Patch by Beuc (https://phabricator.kde.org/p/Beuc/)
      
      Reviewers: #krita
      Subscribers: dkazakov
      Tags: #krita
      Differential Revision: https://phabricator.kde.org/D17708
      1f14ab95
  8. 24 Dec, 2018 1 commit
  9. 22 Dec, 2018 2 commits
    • Anna Medonosová's avatar
    • Anna Medonosová's avatar
      Palette Docker: bug 402072; color selection in the combobox · b1c8ba60
      Anna Medonosová authored
      Summary:
      This diff fixes two issues:
      
      1, bug 402072, where the user is unable to reselect a previously
      selected color from the palette after picking another color by other
      means.
      
      This is fixed by clearing currentIndex in KisPaletteView upon FG color
      change in the resource provider. That way the swatch stays selected, so
      the user knows which color they had selected before, but enables them to
      reselect the color.
      
      2, Another issue, probably originating from commit 69915f53: if the
      user selects a color in the KisPaletteComboBox, nothing happens.
      
      KisPaletteComboBox calls KisPaletteView::selectClosestColor() to select
      the clicked color in the palette. However, from said commit, the
      function is called only with specific setting on. I have added another
      slot specifically for KisPaletteComboBox, which unconditionally calls
      said function.
      
      BUG: 402072
      
      Reviewers: #krita, woltherav
      
      Reviewed By: #krita, woltherav
      
      Subscribers: woltherav
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D17728
      b1c8ba60
  10. 19 Dec, 2018 2 commits
    • Anna Medonosová's avatar
      Partial fix for bug 401656 · 325cbf6c
      Anna Medonosová authored
      Summary:
      Only Default Tool should connect to the selectedShapesProxy::selectionChanged,
      otherwise arrange actions (both in context menu and arrange docker) get disabled
      errorneusly.
      
      This fixes just one part of the bug. The issue with disabled arrange
      actions after layer duplication is still present.
      
      CCBUG: 401656
      
      Reviewers: #krita, rempt
      
      Reviewed By: #krita, rempt
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D17665
      325cbf6c
    • Boudewijn Rempt's avatar
      Fix the Node api · c1b8345e
      Boudewijn Rempt authored
      QPointF shouldn't be passed by reference
      c1b8345e
  11. 18 Dec, 2018 5 commits
  12. 17 Dec, 2018 3 commits
  13. 16 Dec, 2018 1 commit
    • Eoin O'Neill's avatar
      Added Fill Layer Content Option for New Documents · cb8d3c97
      Eoin O'Neill authored
      This patch also changes a few things about how new images are created by
      making use of enums in the newImage interface. I think I've also
      addressed the background opacity in a way that makes more sense and also
      allows for users to tweak background opacity settings after creating a
      new image. Lastly, while using RASTER or FILL backgrounds, if you create
      more than one layer the background layer will start locked. This helps
      to prevent accidental painting on initial starting background layers.
      cb8d3c97