1. 08 Jun, 2019 4 commits
  2. 07 Jun, 2019 2 commits
    • Ivan Yossi's avatar
      Remove update on creating a generator fill layer. · 92a9a440
      Ivan Yossi authored
      This avoids drawing the path twice on load, update is made only from setFilter
      which is also called on document load. If done from the creator it draws
      the default pattern first and then overlays the saved pattern.
    • Dmitry Kazakov's avatar
      Fix a crash when creating a text shape · eb611609
      Dmitry Kazakov authored
      Every KoShapeController used to reset the global "shape document" in its
      KoDocumentResourceManager. The problem is that in Krita we have multiple
      KoShapeController-s, but the resource manager is the only one. It means
      that every shape selection or shape layer used to reset the pointer to
      the global "shape document" to its own one. The only reason why we didn't
      have too many crashes is that almost noone uses this "shape document".
      Ideally we should:
      1) Remove KoDocumentResourceManager::GlobalShapeController resource. This
         resource is not global to the document, but is created per-layer. The only
         user of it atm is the legacy text tool, which should be deprecated.
      2) Remove KoDocumentResourceManager at all. There is no much use of it
         anymore. Its main user is legacy text tool.
  3. 06 Jun, 2019 3 commits
  4. 05 Jun, 2019 3 commits
    • Boudewijn Rempt's avatar
      warning-- · 82e29df0
      Boudewijn Rempt authored
      [171/4490] Building CXX object libs/odf/tests/CMakeFiles/TestStorage.dir/TestStorage.cpp.o
      /home/boud/dev/krita/libs/odf/tests/TestStorage.cpp: In member function ‘void TestStorage::storage()’:
      /home/boud/dev/krita/libs/odf/tests/TestStorage.cpp:85:15: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result]
               system(ba.constData());       // QDir::rmdir isn't recursive!
      /home/boud/dev/krita/libs/odf/tests/TestStorage.cpp: In member function ‘void TestStorage::storage2()’:
      /home/boud/dev/krita/libs/odf/tests/TestStorage.cpp:218:15: warning: ignoring return value of ‘int system(const char*)’, declared with attribute warn_unused_result [-Wunused-result]
               system(ba.constData());       // QDir::rmdir isn't recursive!
    • Boudewijn Rempt's avatar
      Rename KisMaskGeneratorBenchmark to Test · e881acd1
      Boudewijn Rempt authored
      This apparently fixes an issue with duplicate targets that Ninja
      has decided to error out on.
    • Boudewijn Rempt's avatar
  5. 04 Jun, 2019 4 commits
  6. 03 Jun, 2019 7 commits
  7. 01 Jun, 2019 9 commits
  8. 30 May, 2019 3 commits
  9. 28 May, 2019 2 commits
  10. 27 May, 2019 2 commits
  11. 24 May, 2019 1 commit
    • Boudewijn Rempt's avatar
      Fix memory leak in KoGamutMask · 644dddf8
      Boudewijn Rempt authored
      ==23688== 115,060 (224 direct, 114,836 indirect) bytes in 2 blocks are definitely lost in loss record 12,891 of 12,945
      ==23688==    at 0x4C2E68F: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==23688==    by 0x129083D3: QuaZip::QuaZip(QIODevice*) (in /usr/lib64/libquazip5.so.1.0.0)
      ==23688==    by 0xA7DC821: KoQuaZipStore::KoQuaZipStore(QIODevice*, KoStore::Mode, QByteArray const&, bool) (KoQuaZipStore.cpp:69)
      ==23688==    by 0xA7D5DDF: KoStore::createStore(QIODevice*, KoStore::Mode, QByteArray const&, KoStore::Backend, bool) (KoStore.cpp:110)
      ==23688==    by 0x90ED6DE: KoGamutMask::loadFromDevice(QIODevice*) (KoGamutMask.cpp:245)
      ==23688==    by 0x90ECEE5: KoGamutMask::load() (KoGamutMask.cpp:211)
      ==23688==    by 0x89B4BB3: KoResourceServer<KoGamutMask, PointerStoragePolicy<KoGamutMask> >::loadResources(QStringList) (KoResourceServer.h:203)
      ==23688==    by 0x89AC270: KoResourceServerProvider::KoResourceServerProvider() (KoResourceServerProvider.cpp:142)
      ==23688==    by 0x89AC6BB: Holder (KoResourceServerProvider.cpp:156)
      ==23688==    by 0x89AC6BB: innerFunction (KoResourceServerProvider.cpp:156)
      ==23688==    by 0x89AC6BB: operator QGlobalStatic<KoResourceServerProvider, (anonymous namespace)::Q_QGS_s_instance::innerFunction, (anonymous namespace)::Q_QGS_s_instance::guard>::Type* (qglobalstatic.h:134)
      ==23688==    by 0x89AC6BB: KoResourceServerProvider::instance() (KoResourceServerProvider.cpp:160)
      ==23688==    by 0x5DCE9EB: KisApplication::loadResources() (KisApplication.cpp:287)
      ==23688==    by 0x5DD2C4F: KisApplication::start(KisApplicationArguments const&) (KisApplication.cpp:425)
      ==23688==    by 0x40698B: main (main.cc:524)