1. 27 Mar, 2020 1 commit
  2. 26 Mar, 2020 3 commits
  3. 25 Mar, 2020 1 commit
  4. 22 Mar, 2020 1 commit
  5. 21 Mar, 2020 1 commit
  6. 20 Mar, 2020 1 commit
  7. 18 Mar, 2020 1 commit
    • Kai Uwe Broulik's avatar
      [Icons KCM] Floor delegate height · c9f545a3
      Kai Uwe Broulik authored
      There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded up,
      pushing the icons too close to the delegate border.
      Since there's already code for unloading the icons that are out of view, nothing should be leaked into the view,
      even if we now end up having 1 or 2 pixels of the delegates normally out of view visible.
      
      Differential Revision: https://phabricator.kde.org/D28120
      c9f545a3
  8. 13 Mar, 2020 1 commit
    • Nate Graham's avatar
      Make panel edit mode tooltip not unexpectedly disappear under certain circumstances · 9768200d
      Nate Graham authored
      Summary:
      The panel edit mode tooltip can currently disappear in an irritating manner under two circumstances:
      - You need to mouse the mouse diagonally out of the configuration areat to reach the tooltop, because the timer's duration is very short
      - You move the mouse between the tooltip and the configuration area in preparation for moving it to another applet, because the timer did not stop when moving from the tooltip to the configuration area
      
      This patch fixes both issues by increasing the timer duration and stopping the timer when entering the configuration area
      
      BUG: 413736
      FIXED-IN: 5.18.4
      
      Test Plan:
      Edit the panel
      Hover over an applet and move the mouse diagonally to its tooltip, crossing empty space
      Hover over an applet and move the mouse back to the configuration area, then back to the applet, and back to the configuration area, then to another applet, then to that applet's tooltip
      
      In both cases, the tooltip remains visible, as expected.
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27877
      9768200d
  9. 10 Mar, 2020 1 commit
  10. 02 Mar, 2020 1 commit
  11. 27 Feb, 2020 2 commits
    • Nate Graham's avatar
      [applets/taskmanager] Show PA-related features even when audio indicators are disabled · 3b2e4dda
      Nate Graham authored
      Summary:
      There is a checkbox in the Task Manager settings with the text "Mark applications that
      play audio". Unchecking it does much more than no longer marking applications that play
      audio though; it disabled all PulseAudio-related features. This not only makes the label
      inaccurate, but it also seems undesirable; a user could quite reasonably wish to disable
      the audio indicators while still using PulseAudio-related functionality through the Task
      Manager (e.g. muting an app from the context menu).
      
      This patch makes the setting in question really and truly only show and hide the audio
      indicator icon on the Task; other PA-related functionality is always loaded when
      available.
      
      Test Plan:
      Open an app or window that can play audio and start playing audio with it
      Make sure that audio indicators are visible
      Right-click on the task and see that there's {nav Mute} item (provided by PA
      Configure the Task Manager and disable audio indicators
      See that the audio indicator icon is gone from the task
      Right-click on the task and see that the {nav Mute} item is still there
      Configure the Task Manager again and re-enable audio indicators
      See that the audio indicator icon re-appears on the task
      
      BUG: 418164
      FIXED-IN: 5.18.3
      
      Reviewers: #plasma
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27684
      3b2e4dda
    • Filip Fila's avatar
      [emojier] Set minimum window height and width · d0247bf5
      Filip Fila authored
      Summary:
      There are two problems right now with the emojier's window:
      - when shrinking the window a scrollbar is drawn *over* the category drawer's icons
      - the whole window can be shrunk to be only 1px wide and only several pixels tall
      
      To solve both issues this patch sets a minimum height that is equal to the height of the category drawer's content, thereby removing the possibility of a scrollbar appearing. Minimum width is then set to be somewhat bigger than minimum height to account for monitor aspect ratios.
      
      In practice this amounts to about 465x370 on a 1080p screen.
      
      BUG: 418195
      FIXED-IN: 5.18.3
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27679
      d0247bf5
  12. 25 Feb, 2020 1 commit
  13. 24 Feb, 2020 1 commit
    • David Edmundson's avatar
      Calculate needsSave on checkbox toggle not on change · 1dd4668f
      David Edmundson authored
      Summary:
      Otherwise we will trigger it during load, which is wasteful.
      
      But worse potentially we haven't evaluated the other settings yet, so it
      could trigger that we have changed the settings, and prematurely set
      apply to enabled prematurely which currently breaks things.
      
      I suspect it will fix the bug below, I couldn't reproduce reliably
      enough to prove it.
      
      Please reopen if it remains an issue
      
      BUG: 411584
      Fixed-in: 5.18.2
      
      Test Plan:
      Opened KCM
      toggling still worked as expected
      
      Reviewers: #plasma, apol, ngraham
      
      Reviewed By: apol, ngraham
      
      Subscribers: apol, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27590
      1dd4668f
  14. 23 Feb, 2020 1 commit
  15. 22 Feb, 2020 2 commits
  16. 21 Feb, 2020 3 commits
  17. 20 Feb, 2020 3 commits
  18. 19 Feb, 2020 4 commits
  19. 18 Feb, 2020 1 commit
  20. 17 Feb, 2020 2 commits
    • David Edmundson's avatar
      [desktoppackage] Fix layout when an applet has no custom config modules · 1123cc4d
      David Edmundson authored
      Summary:
      There was some broken code to hide the sidebar when we only have one
      module. However at some point it seems half was removed, half wasn't.
      
      This leads to the content overlapping the sidebar frame, but the sidebar
      was invisible and it looks generally broken.
      
      This patch completes the removal.
      
      BUG: 410770
      
      Test Plan:
      Opened touchpad KCM
      Saw the one module (keyboard shortcuts)
      Sidebar was visible, and nothing was overlapping
      
      Reviewers: ngraham
      
      Reviewed By: ngraham
      
      Subscribers: broulik, ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27398
      1123cc4d
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 6ef03d63
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      6ef03d63
  21. 15 Feb, 2020 1 commit
  22. 14 Feb, 2020 3 commits
    • David Edmundson's avatar
      Set toolbox to invisble when it's hidden · 7a48de1e
      David Edmundson authored
      Summary:
      opacity was bound to editMode, but this did not affect visibility or
      enabled.
      
      Not only is this somewhat wasteful, enabled is very important as
      otherwise shortcuts for buttons get intercepted to match the accelerator
      applied to the internal buttons. This breaks all the multi-key shortcuts
      that plasma uses as alt+d gets taken.
      
      BUG: 416695
      FIXED-IN: 5.18.1
      
      Test Plan:
      Mad gammaray skillz to find the bug
      
      Checked alt+d, a now opens the widget explorer
      Checked edit mode through the context menu still showed the toolbox
      
      Reviewers: #plasma, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27386
      7a48de1e
    • David Edmundson's avatar
      [kcm/standardactions] Don't register kcminit hook when we don't have one · ea7013f1
      David Edmundson authored
      Summary:
      There is no exported function called standard_actions. kcminit will link
      against this library, fail to find a method to run and do nothing.
      
      Test Plan: Grepped for method
      
      Reviewers: #plasma, broulik
      
      Reviewed By: #plasma, broulik
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27007
      ea7013f1
    • Benjamin Port's avatar
      [KCM Fonts] force need save to false during load to avoid state to be true too early · 0c4da077
      Benjamin Port authored
      Summary:
      This will resolve a bug (apply never enabled). Bug occurs (at least) when kdeglobals contains QFont serialization without styleName (old style)
      
      BUG: 416358
      
      Reviewers: #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson
      
      Subscribers: plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27384
      0c4da077
  23. 13 Feb, 2020 3 commits
    • Arjen Hiemstra's avatar
      Baloo KCM: Do not anchor fill ScrollView · 83b92094
      Arjen Hiemstra authored
      Summary:
      ScrollView will resize any single child flickabe to the right size.
      However, this behaviour breaks if that child specifies anchors,
      causing the child to ignore any padding specified in ScrollView.
      Removing the anchoring fixes the scrollbar overlapping and also
      fixes list items poking outside the scrollview border.
      
      BUG: 417437
      FIXED-IN: 5.18.1
      
      Test Plan:
      Before:
      
      {F8101357}
      
      After:
      
      {F8101358}
      
      Reviewers: #plasma, ngraham, davidedmundson
      
      Reviewed By: #plasma, ngraham, davidedmundson
      
      Subscribers: davidedmundson, plasma-devel
      
      Tags: #plasma
      
      Differential Revision: https://phabricator.kde.org/D27379
      83b92094
    • Kai Uwe Broulik's avatar
      [Styles KCM] Set style display name as window title · bc5c45e8
      Kai Uwe Broulik authored
      StyleConfigDialog doesn't actually load the config plugin, so it doesn't use the argument for loading but displaying.
      Pass the display of the style to ensure a correct window title.
      
      BUG: 417563
      FIXED-IN: 5.18.1
      
      Differential Revision: https://phabricator.kde.org/D27368
      bc5c45e8
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 7c67a453
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      7c67a453
  24. 11 Feb, 2020 1 commit
    • Marco Martin's avatar
      unlock widgets · 2bc3c5e9
      Marco Martin authored
      5.18 doesn't offer a way anymore from the gui
      so unlock them if they're locked
      BUG:417424
      2bc3c5e9