GitLab

Summary: Error messages should be shown to users no matter how much long it is.

Reviewers: #vdg, #plasma, #frameworks, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28200

Summary: Similar to D28296

Reviewers: #plasma, ervin, bport, crossi, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28297

Summary:
The load function of the field was not called previously.
Preventing the checkbox from reflecting the property status and if it is enabled.

Test Plan:
kcmshell5 mouse
Select a pointer not support middle click emulation.
Before:
middle click emulation is enabled
After:
middle click emulation is disabled

Reviewers: #plasma, ervin, bport, crossi, hchain

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D28296

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

I fixed the case that the "Apply" button wasn't enabled when the selected scheme didn't change but was edited by introducing the m_activeSchemeEdited variable.
However, I didn't actually have it save in this case...

CCBUG: 419168

Differential Revision: https://phabricator.kde.org/D28270

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

According to XDG cursor spec [1] the names are "pointer" and "help" for the pointing hand and what's this cursors.

[1] https://www.freedesktop.org/wiki/Specifications/cursor-spec/

Differential Revision: https://phabricator.kde.org/D28158

There's two rows, so if the delegate happens to be at an odd size, both rows would be rounded up,
pushing the icons too close to the delegate border.
Since there's already code for unloading the icons that are out of view, nothing should be leaked into the view,
even if we now end up having 1 or 2 pixels of the delegates normally out of view visible.

Differential Revision: https://phabricator.kde.org/D28120

Summary:
The panel edit mode tooltip can currently disappear in an irritating manner under two circumstances:
- You need to mouse the mouse diagonally out of the configuration areat to reach the tooltop, because the timer's duration is very short
- You move the mouse between the tooltip and the configuration area in preparation for moving it to another applet, because the timer did not stop when moving from the tooltip to the configuration area

This patch fixes both issues by increasing the timer duration and stopping the timer when entering the configuration area

BUG: 413736
FIXED-IN: 5.18.4

Test Plan:
Edit the panel
Hover over an applet and move the mouse diagonally to its tooltip, crossing empty space
Hover over an applet and move the mouse back to the configuration area, then back to the applet, and back to the configuration area, then to another applet, then to that applet's tooltip

In both cases, the tooltip remains visible, as expected.

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27877

GIT_SILENT

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
There is a checkbox in the Task Manager settings with the text "Mark applications that
play audio". Unchecking it does much more than no longer marking applications that play
audio though; it disabled all PulseAudio-related features. This not only makes the label
inaccurate, but it also seems undesirable; a user could quite reasonably wish to disable
the audio indicators while still using PulseAudio-related functionality through the Task
Manager (e.g. muting an app from the context menu).

This patch makes the setting in question really and truly only show and hide the audio
indicator icon on the Task; other PA-related functionality is always loaded when
available.

Test Plan:
Open an app or window that can play audio and start playing audio with it
Make sure that audio indicators are visible
Right-click on the task and see that there's {nav Mute} item (provided by PA
Configure the Task Manager and disable audio indicators
See that the audio indicator icon is gone from the task
Right-click on the task and see that the {nav Mute} item is still there
Configure the Task Manager again and re-enable audio indicators
See that the audio indicator icon re-appears on the task

BUG: 418164
FIXED-IN: 5.18.3

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27684

Summary:
There are two problems right now with the emojier's window:
- when shrinking the window a scrollbar is drawn *over* the category drawer's icons
- the whole window can be shrunk to be only 1px wide and only several pixels tall

To solve both issues this patch sets a minimum height that is equal to the height of the category drawer's content, thereby removing the possibility of a scrollbar appearing. Minimum width is then set to be somewhat bigger than minimum height to account for monitor aspect ratios.

In practice this amounts to about 465x370 on a 1080p screen.

BUG: 418195
FIXED-IN: 5.18.3

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27679

GIT_SILENT

Summary:
Otherwise we will trigger it during load, which is wasteful.

But worse potentially we haven't evaluated the other settings yet, so it
could trigger that we have changed the settings, and prematurely set
apply to enabled prematurely which currently breaks things.

I suspect it will fix the bug below, I couldn't reproduce reliably
enough to prove it.

Please reopen if it remains an issue

BUG: 411584
Fixed-in: 5.18.2

Test Plan:
Opened KCM
toggling still worked as expected

Reviewers: #plasma, apol, ngraham

Reviewed By: apol, ngraham

Subscribers: apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27590

Summary:
The standalone index cleaner has been replaced almost 5 years by
functionality implemented in baloo_file.

Reviewers: #baloo, ngraham

Reviewed By: #baloo, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27579

(cherry picked from commit 616a9916)

Summary:
Else the content overflows the frame when scrolling.

Same finding/fix as in D27558

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27559

Summary:
Else the content overflows the frame when scrolling.

Same finding/fix as in D27558

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27561

Summary: BUG: 397595

Test Plan:
KCM Look and feel, apply Breeze or Breeze Dark global style, then go to KCM KWin Decoration (Window Decoration), no decoration is highlighted in the grid.
In kwinrc, the group `[org.kde.kdecoration2]` has a `theme=` with no value.

With this patch, applying Breeze or Breeze Dark global theme will write the proper value in kwinrc and the KCM KWin Decoration will show the correct decoration highlighted.

Reviewers: ervin, bport, meven, davidedmundson, #plasma, ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27483

(cherry picked from commit 6d3d3ffa)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- try to find the exact locale.
- Include the more generic one.
- If none were found, use English.

BUG: 417713

Otherwise KWin would get the full name as
org.kde.org.kde.plasma.emojier.

BUG: 416669

BUG: 417454

Summary: Added devicePixelRatio to shadow's radius.

Test Plan:
Check the shadow of items on the desktop.
Compare scale 100% vs big display scale (e.g. 300%).
Before: Shadow is invisible.
After: Visible shadow at every display scale.

Before vs After
Scale 300% and 100%
{F8097331,size=full}

Reviewers: #plasma, #vdg, apol, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, apol, ngraham, davidedmundson

Subscribers: broulik, davidedmundson, apol, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27316

Summary:
BUG: 414109
FIXED-IN: 5.18.2

Reviewers: #plasma, broulik, ervin, meven, crossi, davidedmundson

Reviewed By: #plasma, meven, crossi, davidedmundson

Subscribers: ngraham, davidre, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27470

GIT_SILENT

Summary:
There was some broken code to hide the sidebar when we only have one
module. However at some point it seems half was removed, half wasn't.

This leads to the content overlapping the sidebar frame, but the sidebar
was invisible and it looks generally broken.

This patch completes the removal.

BUG: 410770

Test Plan:
Opened touchpad KCM
Saw the one module (keyboard shortcuts)
Sidebar was visible, and nothing was overlapping

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: broulik, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27398

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
opacity was bound to editMode, but this did not affect visibility or
enabled.

Not only is this somewhat wasteful, enabled is very important as
otherwise shortcuts for buttons get intercepted to match the accelerator
applied to the internal buttons. This breaks all the multi-key shortcuts
that plasma uses as alt+d gets taken.

BUG: 416695
FIXED-IN: 5.18.1

Test Plan:
Mad gammaray skillz to find the bug

Checked alt+d, a now opens the widget explorer
Checked edit mode through the context menu still showed the toolbox

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27386

Summary:
There is no exported function called standard_actions. kcminit will link
against this library, fail to find a method to run and do nothing.

Test Plan: Grepped for method

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27007

Summary:
This will resolve a bug (apply never enabled). Bug occurs (at least) when kdeglobals contains QFont serialization without styleName (old style)

BUG: 416358

Reviewers: #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27384

Summary:
ScrollView will resize any single child flickabe to the right size.
However, this behaviour breaks if that child specifies anchors,
causing the child to ignore any padding specified in ScrollView.
Removing the anchoring fixes the scrollbar overlapping and also
fixes list items poking outside the scrollview border.

BUG: 417437
FIXED-IN: 5.18.1

Test Plan:
Before:

{F8101357}

After:

{F8101358}

Reviewers: #plasma, ngraham, davidedmundson

Reviewed By: #plasma, ngraham, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27379

StyleConfigDialog doesn't actually load the config plugin, so it doesn't use the argument for loading but displaying.
Pass the display of the style to ensure a correct window title.

BUG: 417563
FIXED-IN: 5.18.1

Differential Revision: https://phabricator.kde.org/D27368

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

5.18 doesn't offer a way anymore from the gui
so unlock them if they're locked
BUG:417424