1. 28 Sep, 2020 1 commit
  2. 26 Sep, 2020 2 commits
    • Nate Graham's avatar
      Merge branch 'release/20.08' into master · a00edb9c
      Nate Graham authored
      a00edb9c
    • Bart De Vries's avatar
      Fix deadlock when closing gwenview importer · d15622e1
      Bart De Vries authored
      When gwenview_importer is closed after importing files, it gets into a
      deadlock.  This bug was introduced in commit 4f7d35d1 by the refactoring
      of thumbnailprovider and thumbnailgenerator.
      
      The deadlock is caused by the fact that closing the application will
      directly trigger a wait() in the thumbnailgenerator thread which will
      wait on proper closure of this thread before allowing the application to
      exit.  However, this thumbnailgenerator thread is, at that moment, in a
      QWaitCondition state which is intended to wait on new thumbnails to be
      generated.
      As far as I can see, this is not a problem in the main gwenview
      application because the deadlock will eventually be lifted by the
      destruction of the thumbnailgenerator object by the chain of destructors
      going from application level down to thumbnailprovider which is the
      owner of this object.
      In the importer the situation is a bit different.  After importing has
      finished, the thumbnailpage which is the owner of thumbnailprovider
      is not the current widget anymore.  It still exists in the background in
      case the user presses the "Import more Documents" button.  For some
      reason the destruction chain doesn't seem to properly trigger the
      cancel() function of the thumbnailgenerator object/thread.
      
      The simple solution is to call the cancel() function just before the
      wait() function is called when the application emits aboutToQuit().
      This is proper behavior, since the thumbnailgenerator should always be
      triggered to close down when the application is quitting.
      
      BUG: 425971
      d15622e1
  3. 22 Sep, 2020 1 commit
    • Michael Augaitis's avatar
      Fix ESC key not exiting fullscreen when viewing image · f5cb19e8
      Michael Augaitis authored
      The event filter was not catching the QEvent::ShortcutOverride
      event in browsemainpage.cpp and therefore when the ESC
      key was pressed, gwenview would browse images instead
      of leaving fullscreen. This commit ensures that when
      the ESC key is pressed the first time, gwenview will
      exit fullscreen and will browse images on second key
      press.
      
      BUG: 425479
      f5cb19e8
  4. 21 Sep, 2020 1 commit
    • Oded Arbel's avatar
      Workaround Qt 5.15 behavior change · 31a9d54b
      Oded Arbel authored
      QComboBox from 5.15 would always select an entry when the model has some entries available, which would cause the first tag (alphabetically) to be chosen by default when opening the tag editor. See bug #426800.
      31a9d54b
  5. 20 Sep, 2020 2 commits
  6. 11 Sep, 2020 1 commit
  7. 31 Aug, 2020 3 commits
  8. 30 Aug, 2020 1 commit
  9. 24 Aug, 2020 2 commits
  10. 17 Aug, 2020 1 commit
  11. 13 Aug, 2020 2 commits
  12. 06 Aug, 2020 2 commits
  13. 05 Aug, 2020 4 commits
  14. 04 Aug, 2020 2 commits
  15. 31 Jul, 2020 1 commit
  16. 24 Jul, 2020 2 commits
  17. 16 Jul, 2020 1 commit
  18. 14 Jul, 2020 2 commits
  19. 13 Jul, 2020 2 commits
  20. 11 Jul, 2020 5 commits
  21. 08 Jul, 2020 1 commit
  22. 03 Jul, 2020 1 commit