1. 24 Oct, 2018 1 commit
  2. 23 Oct, 2018 14 commits
  3. 22 Oct, 2018 6 commits
    • Kevin Funk's avatar
      Merge remote-tracking branch 'origin/5.3' · e281bc1a
      Kevin Funk authored
      e281bc1a
    • Milian Wolff's avatar
      Make the code compile with older Qt · b30d6ef9
      Milian Wolff authored
      Sadly, we can't yet use the QMetaObject::invokeMethod
      that takes a functor...
      
      (cherry picked from commit fc68afeb)
      b30d6ef9
    • Milian Wolff's avatar
      Fix crashes when document gets destroyed directly after load · 0be566e3
      Milian Wolff authored
      This fixes the clang code completion unit test, which used to
      crash on exit since the event loop wasn't run between loading
      a document and destroying it again.
      
      To guard against this, we need to jump through a QPointer hoop,
      which requires some lambda boiler plate but otherwise isn't too bad.
      
      (cherry picked from commit 8f9f8d1c)
      0be566e3
    • Kevin Funk's avatar
      Fix memleaks in unittests · e3c0a1ad
      Kevin Funk authored
      Summary:
      Fix memory leaks in unittests to make it easier to find real memory leaks in the tested code.
      
      Fixed tests:
      - test_projectmodel
      - test_areaoperation
      - test_controller
      - test_toolviewtoolbar
      - test_viewactivation
      
      NOTE: this does not fix all memory leaks in all unittests, this is just s start to keep the changes small
      
      Test Plan:
      - cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON ..
      - make test
      
      Many tests will fail because of LSAN (leak sanitizer), which is enabled (at least here) by default with ASAN.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: brauch, kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16064
      e3c0a1ad
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2bb9401f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2bb9401f
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 1eea06a6
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      1eea06a6
  4. 21 Oct, 2018 2 commits
  5. 18 Oct, 2018 2 commits
    • Friedrich W. H. Kossebau's avatar
      Merge branch '5.3' · 65c75e0c
      Friedrich W. H. Kossebau authored
      65c75e0c
    • Friedrich W. H. Kossebau's avatar
      Context browser: fix handleRect for non-symbol tooltips · 27c15b18
      Friedrich W. H. Kossebau authored
      Summary:
      The ContextBrowserPlugin::showToolTip() tried to calculate the handle
      rect for the tooltip in all cases from DUChainUtils::itemUnderCursor(),
      which currently in case of no symbol repots a valid empty range at
      position 0,0.
      
      This results in bogus active zones for the tooltips for problem tooltips,
      but also languages where the language support plugin has many items not
      in the DUChain (like the CMake support plugin).
      
      This patches fixes this by
      a) changing ILanguageSupport::specialLanguageObjectNavigationWidget()
      to report not only the widget but also which document range the object
      covers for which the widget was created.
      b) collect the ranges from all places from which the tooltip widget is
      fetched
      
      Test Plan:
      Tooltips for problems and cmake symbols behave now similar to those for e.g.
      C++ symbols. E.g.. tooltips for items at the bottom of the screen, where the
      tooltip is shown above, the tooltip now can be entered by the mouse and does
      not disappear on a move.
      C++ language tooltips work as before.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, brauch, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16203
      27c15b18
  6. 17 Oct, 2018 1 commit
  7. 16 Oct, 2018 1 commit
  8. 15 Oct, 2018 3 commits
    • Christoph Roick's avatar
      Prevent QWebEngine from overriding signal handlers · 27eaf33c
      Christoph Roick authored
      Summary:
      - The documentation view may use QWebEngine, which is based on
        Chromium, which installs its own signals handlers. This breaks
        the use of KCrash.
      - Overriding the signal handlers can be prevented by setting an
        environment variable before the use, just like in D16004.
      
      Test Plan:
      - open a documentation page in KDevelop
      - kill SIGABRT KDevelop -> DrKonqi shows up
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16188
      27eaf33c
    • Christoph Roick's avatar
      Prevent QWebEngine from overriding signal handlers · ef0af08a
      Christoph Roick authored
      Summary:
      - The documentation view may use QWebEngine, which is based on
        Chromium, which installs its own signals handlers. This breaks
        the use of KCrash.
      - Overriding the signal handlers can be prevented by setting an
        environment variable before the use, just like in D16004.
      
      Test Plan:
      - open a documentation page in KDevelop
      - kill SIGABRT KDevelop -> DrKonqi shows up
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16188
      ef0af08a
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · eaa02d46
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      eaa02d46
  9. 13 Oct, 2018 1 commit
  10. 12 Oct, 2018 3 commits
  11. 11 Oct, 2018 4 commits
  12. 10 Oct, 2018 2 commits