1. 24 Oct, 2018 1 commit
  2. 23 Oct, 2018 14 commits
  3. 22 Oct, 2018 4 commits
    • Milian Wolff's avatar
      Make the code compile with older Qt · b30d6ef9
      Milian Wolff authored
      Sadly, we can't yet use the QMetaObject::invokeMethod
      that takes a functor...
      
      (cherry picked from commit fc68afeb)
      b30d6ef9
    • Milian Wolff's avatar
      Fix crashes when document gets destroyed directly after load · 0be566e3
      Milian Wolff authored
      This fixes the clang code completion unit test, which used to
      crash on exit since the event loop wasn't run between loading
      a document and destroying it again.
      
      To guard against this, we need to jump through a QPointer hoop,
      which requires some lambda boiler plate but otherwise isn't too bad.
      
      (cherry picked from commit 8f9f8d1c)
      0be566e3
    • Kevin Funk's avatar
      Fix memleaks in unittests · e3c0a1ad
      Kevin Funk authored
      Summary:
      Fix memory leaks in unittests to make it easier to find real memory leaks in the tested code.
      
      Fixed tests:
      - test_projectmodel
      - test_areaoperation
      - test_controller
      - test_toolviewtoolbar
      - test_viewactivation
      
      NOTE: this does not fix all memory leaks in all unittests, this is just s start to keep the changes small
      
      Test Plan:
      - cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON ..
      - make test
      
      Many tests will fail because of LSAN (leak sanitizer), which is enabled (at least here) by default with ASAN.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: brauch, kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16064
      e3c0a1ad
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 2bb9401f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      2bb9401f
  4. 18 Oct, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Context browser: fix handleRect for non-symbol tooltips · 27c15b18
      Friedrich W. H. Kossebau authored
      Summary:
      The ContextBrowserPlugin::showToolTip() tried to calculate the handle
      rect for the tooltip in all cases from DUChainUtils::itemUnderCursor(),
      which currently in case of no symbol repots a valid empty range at
      position 0,0.
      
      This results in bogus active zones for the tooltips for problem tooltips,
      but also languages where the language support plugin has many items not
      in the DUChain (like the CMake support plugin).
      
      This patches fixes this by
      a) changing ILanguageSupport::specialLanguageObjectNavigationWidget()
      to report not only the widget but also which document range the object
      covers for which the widget was created.
      b) collect the ranges from all places from which the tooltip widget is
      fetched
      
      Test Plan:
      Tooltips for problems and cmake symbols behave now similar to those for e.g.
      C++ symbols. E.g.. tooltips for items at the bottom of the screen, where the
      tooltip is shown above, the tooltip now can be entered by the mouse and does
      not disappear on a move.
      C++ language tooltips work as before.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, brauch, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16203
      27c15b18
  5. 15 Oct, 2018 1 commit
    • Christoph Roick's avatar
      Prevent QWebEngine from overriding signal handlers · 27eaf33c
      Christoph Roick authored
      Summary:
      - The documentation view may use QWebEngine, which is based on
        Chromium, which installs its own signals handlers. This breaks
        the use of KCrash.
      - Overriding the signal handlers can be prevented by setting an
        environment variable before the use, just like in D16004.
      
      Test Plan:
      - open a documentation page in KDevelop
      - kill SIGABRT KDevelop -> DrKonqi shows up
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16188
      27eaf33c
  6. 12 Oct, 2018 1 commit
    • Kevin Funk's avatar
      windows: Detect VS2017 compiler and tools · ea3d601f
      Kevin Funk authored
      Summary:
      Visual Studio 2017 defines the VS150COMNTOOLS env variable which
      kdevelop-msvc.bat ignored till now. By default VS does not set the
      VS150COMNTOOLS as system-wide variable so we have to do be a bit more
      clever to detect the VS2017 install.
      
      Also allow to start using VS2017 compiler, using either 32 bit or 64 bit
      compilers by prompting the user.
      
      Reviewers: Petross404, brauch
      
      Reviewed By: brauch
      
      Subscribers: brauch, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16123
      ea3d601f
  7. 11 Oct, 2018 3 commits
  8. 07 Oct, 2018 4 commits
    • Friedrich W. H. Kossebau's avatar
    • Friedrich W. H. Kossebau's avatar
    • Bernd Buschinski's avatar
      Sort Project Targets in Launch configuration · f223280b
      Bernd Buschinski authored
      Summary:
      For a small cmake test project which just has a couple of targets:
      - test_cmake_targets
      - test_cmake_targets/unittests/test1
      - test_cmake_targets/unittests/test2
      - test_cmake_targets/unittests/test3
      - test_cmake_targets/unittests/test4
      - test_cmake_targets/utils/util1
      - test_cmake_targets/utils/util2
      - test_cmake_targets/utils/util3
      - test_cmake_targets/utils/util4
      
      but in the "Run -> Configure Launches -> ... -> Project target:" combobox they appear as:
      - test_cmake_targets
      - test_cmake_targets/unittests/test2
      - test_cmake_targets/unittests/test4
      - test_cmake_targets/unittests/test3
      - test_cmake_targets/unittests/test1
      - test_cmake_targets/utils/util2
      - test_cmake_targets/utils/util1
      - test_cmake_targets/utils/util3
      - test_cmake_targets/utils/util4
      
      as the order confuses me greatly (especially for huge projects) and even changes
      in different kdevelop sessions/executions -> sort them.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16003
      f223280b
    • Bernd Buschinski's avatar
      Fix discovery of clang builtin directory with clang svn versions · 6da2caac
      Bernd Buschinski authored
      Summary:
      The CLANG_VERSION for svn clang versions have a svn suffix "8.0.0svn" and all the libraries have a svn suffix.
      But not the in builtin include dir. It still points to
      "/usr/lib/clang/8.0.0/include/cpuid.h"
      without the suffix.
      
      Extend the PATH_SUFFIXES to also looks a version without svn suffix.
      
      BUG: 399439
      
      Test Plan:
      - install clang-svn
      - execute cmake .. (for kdevelop)
      -> it will fail
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15998
      6da2caac
  9. 06 Oct, 2018 2 commits
  10. 05 Oct, 2018 3 commits
  11. 04 Oct, 2018 5 commits
    • Kevin Funk's avatar
      Move clangBuiltinIncludePath() to different ns · feba4b8a
      Kevin Funk authored
      ClangHelpers seems to be the better fit (it's DUChain agnostic)
      feba4b8a
    • Friedrich W. H. Kossebau's avatar
      Fix calling qdbus by using qt5-current name qdbus-qt5 · f9309d65
      Friedrich W. H. Kossebau authored
      Summary:
      Due to Qt not providing OOTB support for parallel installation of different
      base versions (like Qt4 and Qt5), Linux distributions have separated into
      different approaches how to name the Qt tools like qmake and qdbus.
      Many use -qt4 and -qt5 suffixes and link the normal name to a variant, e.g.
      controlled by a custom tool qtchooser. Others kept the Qt4 versions to stay
      with the names, and only added a suffix -qt5 to the new ones.
      
      Test Plan:
      There is no longer a warning about missing qtdbus in the embedded konsole on
      opening. The commands like search! & Co. work again.
      
      Reviewers: #kdevelop, lbeltrame, fvogt, jriddell, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15606
      f9309d65
    • Kevin Funk's avatar
      Minor: Fix stale TODO comment · 300b910e
      Kevin Funk authored
      300b910e
    • Kevin Funk's avatar
      7aa4bfa1
    • Bernd Buschinski's avatar
      Use CLANG_INCLUDE_DIRS for clang include dir · 716372ae
      Bernd Buschinski authored
      Summary:
      Use CLANG_INCLUDE_DIRS for clang include dir instead of manually building it.
      
      This fixes the error:
      kdevplatform.shell: Could not load plugin "kdevclangsupport" , it reported the error: "The clang builtin include path \"/usr/lib64/llvm/7/lib64/clang/7.0.0/include\" is invalid (missing cpuid.h header).\nTry setting the KDEV_CLANG_BUILTIN_DIR environment variable manually to fix this.\nSee also: https://bugs.kde.org/show_bug.cgi?id=393779" Disabling the plugin now.
      
      As CMake with CLANG_INCLUDE_DIRS already tests if this folder is present, it should work across all distros.
      
      CCBUG: 393779
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: mwolff, aaronpuchert, brauch, kossebau, kfunk, arrowd, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15895
      716372ae
  12. 03 Oct, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      cmake: Avoid rst2html warnings in on-the-fly generated html documentation · beae0686
      Friedrich W. H. Kossebau authored
      Summary:
      rst2html reports warnings about the rst syntax into the generated html,
      unless told to switch to another report level, like with --quiet.
      As the user cannot (or does not want to) do anything about the cmake docs
      when just using them, hide any warnings from them.
      
      Test Plan:
      CMake docs are still shown, now without any rst syntax warnings (e.g. for
      CMake's "project".
      
      Reviewers: #kdevelop, apol, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15919
      beae0686