1. 23 Nov, 2016 1 commit
  2. 19 Nov, 2016 1 commit
    • Pino Toscano's avatar
      i18n fixes · 0e0e8031
      Pino Toscano authored
      - make sure to translate all the strings in the GitHub provider plugin
      - avoid string contractions ("countn't" -> "could not", etc)
      - avoid exclamation marks (it is not a game)
      - avoid string puzzles
      - k18n(foo).toString() -> i18n(foo)
      - fix placeholders
      - spell "GitHub" correctly
      - style fixes
      0e0e8031
  3. 15 Nov, 2016 1 commit
  4. 07 Nov, 2016 2 commits
  5. 20 Oct, 2016 1 commit
  6. 19 Oct, 2016 1 commit
  7. 18 Oct, 2016 1 commit
    • Anton Anikin's avatar
      Next step for use-nullptr · c4dcb3f2
      Anton Anikin authored
      Summary:
      The patch continues use-nullptr migration with changes for some parts of code which was not fixed by clang-tidy.
      
      Unfortunately it's not possible now to enable "-Wzero-as-null-pointer-constant" flag without adding many ugly fixes to code. It causes by warnings/errors produced by this flag for 3rd-party, non-KDevelop code such a KF5, Qt which still use old-style zeroes instead nullptr.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D3092
      c4dcb3f2
  8. 17 Oct, 2016 1 commit
  9. 16 Oct, 2016 1 commit
  10. 15 Oct, 2016 2 commits
  11. 07 Oct, 2016 2 commits
    • Anton Anikin's avatar
      cmake manager: fix incorrect settings import from existing build directory · 17b6499e
      Anton Anikin authored
      Summary: Old version ignores install directory and build type settings when user add existing build directory to project. This incorrect behavior leads in particular to full-rebuild if selected build type (which can be choosen from combo box **before** build directory selecting) and existing build type (from build directory) are different. The patch fixes this bug by additional parsing of `CMakeCache.txt` file.
      
      Test Plan: Tested on `master` branch with different projects and build directories.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: apol, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D2964
      17b6499e
    • Anton Anikin's avatar
      cmake manager: fix incorrect settings import from existing build directory · 81f8d158
      Anton Anikin authored
      Summary: Old version ignores install directory and build type settings when user add existing build directory to project. This incorrect behavior leads in particular to full-rebuild if selected build type (which can be choosen from combo box **before** build directory selecting) and existing build type (from build directory) are different. The patch fixes this bug by additional parsing of `CMakeCache.txt` file.
      
      Test Plan: Tested on `master` branch with different projects and build directories.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: apol, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D2964
      81f8d158
  12. 02 Oct, 2016 2 commits
  13. 28 Sep, 2016 1 commit
  14. 14 Sep, 2016 2 commits
  15. 05 Sep, 2016 2 commits
  16. 04 Sep, 2016 1 commit
  17. 01 Aug, 2016 1 commit
  18. 28 Jul, 2016 1 commit
  19. 21 Jul, 2016 1 commit
    • Kevin Funk's avatar
      Drop unneeded Qt5Script dependency · e2a18a86
      Kevin Funk authored
      The CMake plugin used to use it, it does not anymore. Same for the qmljs
      lib apparently. Also note Qt5Script is deprecated since 5.5.
      
      Drop the dependency so we can save some of the installer download size
      (around 1-2 MiB)
      e2a18a86
  20. 18 Jul, 2016 1 commit
  21. 14 Jul, 2016 1 commit
  22. 13 Jul, 2016 1 commit
  23. 12 Jul, 2016 1 commit
  24. 02 Jul, 2016 1 commit
    • Andreas Cord-Landwehr's avatar
      Specify category for GHNS · 4ac818af
      Andreas Cord-Landwehr authored
      Summary:
      With my last fixes in Synchrotron, the phenomenon of empty category
      names is gone and no content is assigned to an empty category name
      anymore. With this patch, GHNS again finds the QtHelp files.
      
      Test Plan: Manual testing.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D2064
      4ac818af
  25. 30 Jun, 2016 1 commit
    • Kevin Funk's avatar
      Fix crash in CMakePreferences::updateCache · 0a3210b8
      Kevin Funk authored
      Happened when invoking a solution involving starting up the
      project config page.
      
      Backtrace:
      
      SUMMARY: AddressSanitizer: undefined-behavior
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/settings/cmakepreferences.cpp:180:9
      in
      ASAN:DEADLYSIGNAL
      =================================================================
      ==31850==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000
      (pc 0x7f10b452f8b7 bp 0x7fff26dce210 sp 0x7fff26dcdd20 T0)
          #0 0x7f10b452f8b6 in CMakePreferences::updateCache(KDevelop::Path
      const&)
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/settings/cmakepreferences.cpp:180:9
          #1 0x7f10b451a94f in CMakePreferences::buildDirChanged(int)
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/settings/cmakepreferences.cpp:231:5
          #2 0x7f10b454f049 in
      QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<int>,
      void, void (CMakePreferences::*)(int)>::call(void
      (CMakePreferences::*)(int), CMakePreferences*, void**)
      /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:501:13
          #3 0x7f10b454eb5d in void QtPrivate::FunctionPointer<void
      (CMakePreferences::*)(int)>::call<QtPrivate::List<int>, void>(void
      (CMakePreferences::*)(int), CMakePreferences*, void**)
      /usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs_impl.h:520:13
          #4 0x7f10b454e5ff in QtPrivate::QSlotObject<void
      (CMakePreferences::*)(int), QtPrivate::List<int>, void>::impl(int,
      QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
      /usr/include/x86_64-linux-gnu/qt5/QtCore/qobject_impl.h:143:17
          #5 0x7f10fb4b8e4e in QMetaObject::activate(QObject*, int, int,
      void**) (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2b4e4e)
          #6 0x7f10fbe8f380 in QComboBox::currentIndexChanged(int)
      (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x26d380)
          #7 0x7f10fbe917e0
      (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x26f7e0)
          #8 0x7f10fbe93e0c
      (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x271e0c)
          #9 0x7f10fbe9403e in QComboBox::setCurrentIndex(int)
      (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x27203e)
          #10 0x7f10fbe99678
      (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x277678)
          #11 0x7f10fb4b8fc9 in QMetaObject::activate(QObject*, int, int,
      void**) (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x2b4fc9)
          #12 0x7f10fb535323 in QAbstractItemModel::rowsInserted(QModelIndex
      const&, int, int, QAbstractItemModel::QPrivateSignal)
      (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x331323)
          #13 0x7f10fb432775 in QAbstractItemModel::endInsertRows()
      (/usr/lib/x86_64-linux-gnu/libQt5Core.so.5+0x22e775)
          #14 0x7f10fbb38f32
      (/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5+0x45ef32)
          #15 0x7f10fbe965bb in QComboBox::insertItems(int, QStringList
      const&) (/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5+0x2745bb)
          #16 0x7f10b454148e in QComboBox::addItems(QStringList const&)
      /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qcombobox.h:174:11
          #17 0x7f10b4526a23 in CMakePreferences::reset()
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/settings/cmakepreferences.cpp:108:5
          #18 0x7f10b4519e3d in
      CMakePreferences::CMakePreferences(KDevelop::IPlugin*,
      KDevelop::ProjectConfigOptions const&, QWidget*)
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/settings/cmakepreferences.cpp:95:5
          #19 0x7f10b4479bd7 in CMakeManager::perProjectConfigPage(int,
      KDevelop::ProjectConfigOptions const&, QWidget*)
      /home/kfunk/devel/src/kf5/kdevelop-stable/projectmanagers/cmake/cmakemanager.cpp:886:20
          #20 0x7f11021ecfdc in
      KDevelop::ProjectControllerPrivate::projectConfig(QObject*)
      /home/kfunk/devel/src/kf5/kdevplatform-stable/shell/projectcontroller.cpp:143:36
          #21 0x7f11021c380f in
      KDevelop::ProjectController::configureProject(KDevelop::IProject*)
      /home/kfunk/devel/src/kf5/kdevplatform-stable/shell/projectcontroller.cpp:976:5
          #22 0x7f10afe80e42 in
      DefinesAndIncludesManager::openConfigurationDialog(QString const&)
      /home/kfunk/devel/src/kf5/kdevelop-stable/languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp:224:9
          ...
      0a3210b8
  26. 25 Jun, 2016 1 commit
  27. 23 Jun, 2016 1 commit
  28. 22 Jun, 2016 1 commit
  29. 18 Jun, 2016 1 commit
  30. 17 Jun, 2016 1 commit
  31. 16 Jun, 2016 3 commits
  32. 15 Jun, 2016 1 commit
    • Kevin Funk's avatar
      Import CMSYS dependency · 3477bb77
      Kevin Funk authored
      Summary:
      Don't depend on the external library. Just requires a minor patch in the
      cmListFileLexer code, this is worth it. Doesn't need a special version
      of CMake which installs the internal CMSYS lib then.
      
      Subscribers: arrowdodger, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D1883
      3477bb77