GitLab

Summary: Analogous to the rename declaration action exposed by the clang plugin

Reviewers: arrowd

Reviewed By: arrowd

Subscribers: arrowd, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17525

Summary: Trim whitespace from the input to QuickOpen. For example, when copying a file path into the QuickOpen widget from some command line output and it happens to contain some whitespace at the start or end, it will still work with this patch. Without the patch, one has to remove the whitespace manually.

Test Plan: Shortly tested it manually.

Reviewers: #kdevelop, dhaumann

Reviewed By: dhaumann

Subscribers: dhaumann, apol, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17885

Summary:
Also
* add SVG variant
* add 512px & 1024px variants as useful with HiDPI

Reviewers: #kdevelop, arrowd

Reviewed By: arrowd

Subscribers: arrowd, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17839

As pointed to by TheAssassin,
https://docs.appimage.org/reference/appdir.html has it:
"The name of the file doesn’t matter [...]"

Using the original name allows to also use the original appdata file
with the same base name, and have the appdata found by appimage tools,
which rely on it being the same.

Differential Revision: https://phabricator.kde.org/D17582

Summary:
On the first run of kdevelop-recipe-centos6.sh it is run from a copied
version, not the git checkout of kdevelop.

Reviewers: #kdevelop, zhigalin

Reviewed By: #kdevelop, zhigalin

Subscribers: kfunk, brauch, zhigalin, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17581

A QWebEngineProfile must exist longer, than a QWebEnginePage using it.
The page is now explicitly deleted before the profile.

BUG: 402026
(cherry picked from commit 7419d27c)

As recommended in multiple tickets dealing with problems with those
libraries part of the AppImage.

Problems experienced on ArchLinux:
   /usr/lib/libfontconfig.so.1: error: symbol lookup error: undefined symbol: FT_Done_MM_Var (fatal)

... and after rm'ing just libfreetype:
   /tmp/.mount_KDevela4PEc7/usr/lib/libz.so.1: error: version lookup error: version `ZLIB_1.2.9' not found (required by /usr/lib/libpng16.so.16) (fatal)

Those libraries are also all blacklisted here:
  https://github.com/AppImage/AppImages/blob/master/excludelist#L81-L83

Summary:
In one of my work projects, the CMake 3.13.1 server gave fileGroups
responses without any useful CMakeFile data. This then was stored
in our lookup hash used by CMakeManager::fileInformation.

Then later, when we queried for these files, we found a match,
albeit empty, and returned that leading to completely broken C++
language support.

To prevent this issue, we now skip useless empty CMakeFile entries.
This fixes the specific scenario I'm seeing in my work project.

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17679

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This adds 2 missing slots to the KTextEditorPlugin integration
layer: MainWindow::openUrl() and MainWindow::showToolView().

Differential Revision: https://phabricator.kde.org/D17465

No new translatable strings in stable branch, also fix casing, etc.

Sets appropriate initial values to the "Export" model parameters "urls"
and "mimeType" to avoid startup warnings. Also sets the updateComment of
the Phabricator plugin so that the default upgrade summary is a little
more personal.

Differential Revision: https://phabricator.kde.org/D17424

Summary:
Override code completion will only add the override specifier if the parser
settings don't have either -std=c++03 or 98.

Supersedes: D4039

BUG: 372280

Test Plan: Run `test_codecompletion testOverrideExecute`

Reviewers: kfunk

Reviewed By: kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16773

(cherry picked from commit 0636cfdd)

... to get the Python module with lzma support (later required inside
install_colorschemes.py)

... which is NOT end of life like 6.8 is.

Summary: Change from qWarning to Using qCWarning in Path.cpp

Test Plan: Build on both Windows and Linux

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17174

Summary: Fix qmakeproject unittest to work on Windows

Test Plan: Build on Windows, verify test passes. Build on Linux, verify test passes (as before).

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17158

Summary: Fix defines and includes test to run on Windows. Change the projects generator to use the 'new' way of generating project files. That way it's easier to handle the fact that we use different paths on different platforms.

Test Plan: Build on Windows and confirm that test is passing. Build on Linux and confirm that test (test_definesandincludes and test_compilerprovider since they both depend on projectgenerator ) still pass.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17156

Summary: Fix projectmodel unittest to work on Windows. Use paths according to the platform we are using

Test Plan: Compile and test on Windows (Debug build) to see the unittests are passing. Compile and test on Linux to see that the test pass (As before)

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17130

Summary: This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.

Test Plan: Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17098

(cherry picked from commit 35026c08)

Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows.

Summary: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform.

Test Plan: Build and test on Windows. See that the test is passing. Build on Linux and verify that test is passing (As before)

Reviewers: #kdevelop, brauch

Reviewed By: #kdevelop, brauch

Subscribers: brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17131

Changes:
- Make it work under Windows
- Extract only interesting paths (optimization)
- Pass the install dir, not prefix (thus /usr/share instead of /usr)

Summary:
Makes sure the strings & metadata are consistent, also brings in
translations.

Reviewers: #kdevelop, kfunk, brauch

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17027

Summary: When doing the benchmark test on windows. Make sure that we use windows paths. Otherwise the test will fail (in debug builds) in an assert in util/path.cpp

Test Plan: Run the test in a Windows debug build environment. Before patch it fails. After patch is applied it succeeds. Run test on Linux and see that test stil completes

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D17077

Failed with:
/usr/include/libkomparediff2/kompare.h:93:32: error: 'QString::QString(const char*)' is private within this context
    QString _localDestination = "",
                                ^~

(cherry picked from commit b03b30c2)