1. 11 Jan, 2019 3 commits
    • Friedrich W. H. Kossebau's avatar
    • Friedrich W. H. Kossebau's avatar
      appimage: skip unneeded cp of cmake, removed later again · ff326bb2
      Friedrich W. H. Kossebau authored
      Test Plan: AppImage still built and starting.
      
      Reviewers: #kdevelop, brauch, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D18175
      ff326bb2
    • Thomas Schöps's avatar
      Clang plugin: Handle CUDA files better · 71c65a65
      Thomas Schöps authored
      Summary:
      This fixes two issues in how KDevelop's clang plugin handles CUDA files (.cu source files and .cuh headers):
      1) Those file types were not treated as source files, therefore if such a file was modified, it was not passed among the list of modified source files to clang for re-parsing. The re-parsing thus incorrectly used the unmodified file on disk instead. This is addressed by the change to documentfinderhelpers.cpp and kdevclang.xml.
      2) The patch passes the general code parser settings also to CUDA files (change in parsesession.cpp). This is for example important to get flags such as -std=c++11 that are required for correct parsing. However, it is not correct: the build system may use separate options for CUDA files (e.g., CMake's CUDA_NVCC_FLAGS). But it might still be better than the previous behavior of not passing any options except -xcuda, since it might be somewhat likely that it is a reasonable guess.
      
      Additional comments:
      a) I am not sure whether the change in clanghelpers.cpp is required, but it seems coherent.
      b) I changed the CUDA mime types in kdevclang.xml to inherit from text/x-c++src/hdr instead of text/x-csrc/hdr since the CUDA files can contain C++ code.
      c) This patch is not sufficient to enable proper CUDA support. I'll post to the kdevelop-devel mailing list for that.
      
      Test Plan: Tested manually.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, apol, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17909
      71c65a65
  2. 10 Jan, 2019 2 commits
  3. 09 Jan, 2019 3 commits
  4. 06 Jan, 2019 1 commit
  5. 05 Jan, 2019 1 commit
  6. 04 Jan, 2019 1 commit
    • Gleb Popov's avatar
      QuickOpen: Trim whitespace from input · 263a5737
      Gleb Popov authored
      Summary: Trim whitespace from the input to QuickOpen. For example, when copying a file path into the QuickOpen widget from some command line output and it happens to contain some whitespace at the start or end, it will still work with this patch. Without the patch, one has to remove the whitespace manually.
      
      Test Plan: Shortly tested it manually.
      
      Reviewers: #kdevelop, dhaumann
      
      Reviewed By: dhaumann
      
      Subscribers: dhaumann, apol, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17885
      263a5737
  7. 03 Jan, 2019 1 commit
  8. 31 Dec, 2018 1 commit
  9. 28 Dec, 2018 1 commit
  10. 25 Dec, 2018 1 commit
  11. 24 Dec, 2018 6 commits
  12. 23 Dec, 2018 1 commit
  13. 20 Dec, 2018 1 commit
    • Kevin Funk's avatar
      appimage: Strip libfreetype & libz · 31e662ec
      Kevin Funk authored
      As recommended in multiple tickets dealing with problems with those
      libraries part of the AppImage.
      
      Problems experienced on ArchLinux:
         /usr/lib/libfontconfig.so.1: error: symbol lookup error: undefined symbol: FT_Done_MM_Var (fatal)
      
      ... and after rm'ing just libfreetype:
         /tmp/.mount_KDevela4PEc7/usr/lib/libz.so.1: error: version lookup error: version `ZLIB_1.2.9' not found (required by /usr/lib/libpng16.so.16) (fatal)
      
      Those libraries are also all blacklisted here:
        https://github.com/AppImage/AppImages/blob/master/excludelist#L81-L83
      31e662ec
  14. 19 Dec, 2018 1 commit
    • Milian Wolff's avatar
      CMake: skip server entries without empty build system information · 2da988ae
      Milian Wolff authored
      Summary:
      In one of my work projects, the CMake 3.13.1 server gave fileGroups
      responses without any useful CMakeFile data. This then was stored
      in our lookup hash used by CMakeManager::fileInformation.
      
      Then later, when we queried for these files, we found a match,
      albeit empty, and returned that leading to completely broken C++
      language support.
      
      To prevent this issue, we now skip useless empty CMakeFile entries.
      This fixes the specific scenario I'm seeing in my work project.
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17679
      2da988ae
  15. 17 Dec, 2018 1 commit
  16. 14 Dec, 2018 1 commit
  17. 10 Dec, 2018 1 commit
  18. 09 Dec, 2018 1 commit
  19. 08 Dec, 2018 1 commit
  20. 06 Dec, 2018 1 commit
  21. 03 Dec, 2018 1 commit
  22. 01 Dec, 2018 1 commit
  23. 27 Nov, 2018 3 commits
  24. 26 Nov, 2018 5 commits
    • Morten Volden's avatar
      Use qCWarning in path.cpp. · 22c9a57f
      Morten Volden authored
      Summary: Change from qWarning to Using qCWarning in Path.cpp
      
      Test Plan: Build on both Windows and Linux
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17174
      22c9a57f
    • Morten Volden's avatar
      Fix qmakeproject unittest to work on Windows. · e3de5953
      Morten Volden authored
      Summary: Fix qmakeproject unittest to work on Windows
      
      Test Plan: Build on Windows, verify test passes. Build on Linux, verify test passes (as before).
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17158
      e3de5953
    • Morten Volden's avatar
      Fix defines and includes test to run on Windows. · b1ba6403
      Morten Volden authored
      Summary: Fix defines and includes test to run on Windows. Change the projects generator to use the 'new' way of generating project files. That way it's easier to handle the fact that we use different paths on different platforms.
      
      Test Plan: Build on Windows and confirm that test is passing. Build on Linux and confirm that test (test_definesandincludes and test_compilerprovider since they both depend on projectgenerator ) still pass.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17156
      b1ba6403
    • Morten Volden's avatar
      Fix projectmodel unittest to work on Windows. · de81ab5c
      Morten Volden authored
      Summary: Fix projectmodel unittest to work on Windows. Use paths according to the platform we are using
      
      Test Plan: Compile and test on Windows (Debug build) to see the unittests are passing. Compile and test on Linux to see that the test pass (As before)
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17130
      de81ab5c
    • Morten Volden's avatar
      Make the filteringstrategy test work on Windows as well. · d46ed701
      Morten Volden authored
      Summary: This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.
      
      Test Plan: Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17098
      
      (cherry picked from commit 35026c08)
      d46ed701