GitLab

Unfortunately not easy to add a regression test given the current qmljs
testing infrastructure.

BUG: 396634
FIXED-IN: 5.3.0

Also dont cause horizontal scroll bars by a too-big size hint

... turn into qCDebug (as all others)

CCBUG: 400231

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

22M uncompressed in size...

... instead of deprecated AppImageAssistant.

Also see:
  https://discourse.appimage.org/t/the-future-of-appimage-type-2-and-new-tools/65

... instead of a prefix containing the major/minor version

Summary:
Automatically offer completions if the user types the scope resolution-
operator, this would involve manual invocation previously.

Reviewers: #kdevelop, mwolff

Reviewed By: #kdevelop, mwolff

Subscribers: brauch, mwolff, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16315

Sadly, we can't yet use the QMetaObject::invokeMethod
that takes a functor...

(cherry picked from commit fc68afeb)

This fixes the clang code completion unit test, which used to
crash on exit since the event loop wasn't run between loading
a document and destroying it again.

To guard against this, we need to jump through a QPointer hoop,
which requires some lambda boiler plate but otherwise isn't too bad.

(cherry picked from commit 8f9f8d1c)

Summary:
Fix memory leaks in unittests to make it easier to find real memory leaks in the tested code.

Fixed tests:
- test_projectmodel
- test_areaoperation
- test_controller
- test_toolviewtoolbar
- test_viewactivation

NOTE: this does not fix all memory leaks in all unittests, this is just s start to keep the changes small

Test Plan:
- cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON ..
- make test

Many tests will fail because of LSAN (leak sanitizer), which is enabled (at least here) by default with ASAN.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: brauch, kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16064

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Summary:
The ContextBrowserPlugin::showToolTip() tried to calculate the handle
rect for the tooltip in all cases from DUChainUtils::itemUnderCursor(),
which currently in case of no symbol repots a valid empty range at
position 0,0.

This results in bogus active zones for the tooltips for problem tooltips,
but also languages where the language support plugin has many items not
in the DUChain (like the CMake support plugin).

This patches fixes this by
a) changing ILanguageSupport::specialLanguageObjectNavigationWidget()
to report not only the widget but also which document range the object
covers for which the widget was created.
b) collect the ranges from all places from which the tooltip widget is
fetched

Test Plan:
Tooltips for problems and cmake symbols behave now similar to those for e.g.
C++ symbols. E.g.. tooltips for items at the bottom of the screen, where the
tooltip is shown above, the tooltip now can be entered by the mouse and does
not disappear on a move.
C++ language tooltips work as before.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16203

Summary:
- The documentation view may use QWebEngine, which is based on
  Chromium, which installs its own signals handlers. This breaks
  the use of KCrash.
- Overriding the signal handlers can be prevented by setting an
  environment variable before the use, just like in D16004.

Test Plan:
- open a documentation page in KDevelop
- kill SIGABRT KDevelop -> DrKonqi shows up

Reviewers: #kdevelop, apol

Reviewed By: #kdevelop, apol

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16188

Summary:
Visual Studio 2017 defines the VS150COMNTOOLS env variable which
kdevelop-msvc.bat ignored till now. By default VS does not set the
VS150COMNTOOLS as system-wide variable so we have to do be a bit more
clever to detect the VS2017 install.

Also allow to start using VS2017 compiler, using either 32 bit or 64 bit
compilers by prompting the user.

Reviewers: Petross404, brauch

Reviewed By: brauch

Subscribers: brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16123

Do not show:
  ERROR: The system was unable to find the specified registry key or value.

Fix coding style

Summary:
For a small cmake test project which just has a couple of targets:
- test_cmake_targets
- test_cmake_targets/unittests/test1
- test_cmake_targets/unittests/test2
- test_cmake_targets/unittests/test3
- test_cmake_targets/unittests/test4
- test_cmake_targets/utils/util1
- test_cmake_targets/utils/util2
- test_cmake_targets/utils/util3
- test_cmake_targets/utils/util4

but in the "Run -> Configure Launches -> ... -> Project target:" combobox they appear as:
- test_cmake_targets
- test_cmake_targets/unittests/test2
- test_cmake_targets/unittests/test4
- test_cmake_targets/unittests/test3
- test_cmake_targets/unittests/test1
- test_cmake_targets/utils/util2
- test_cmake_targets/utils/util1
- test_cmake_targets/utils/util3
- test_cmake_targets/utils/util4

as the order confuses me greatly (especially for huge projects) and even changes
in different kdevelop sessions/executions -> sort them.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D16003

Summary:
The CLANG_VERSION for svn clang versions have a svn suffix "8.0.0svn" and all the libraries have a svn suffix.
But not the in builtin include dir. It still points to
"/usr/lib/clang/8.0.0/include/cpuid.h"
without the suffix.

Extend the PATH_SUFFIXES to also looks a version without svn suffix.

BUG: 399439

Test Plan:
- install clang-svn
- execute cmake .. (for kdevelop)
-> it will fail

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15998

there are no files with spaces in the lldb sources, and the current way
actually breaks the extraction

There are no more files with spaces in the source tree of the gdb
plugin.

This reverts commit d85deaa9.

Summary:
Changes:
* Add a helper function retrieving the Clang version at runtime
* Auto-detect bundled copy of Clang builtin headers on Windows
* Print lots more debug output during startup

TODO: Wondering if we want to add more code detecting this directory at
runtime on other platforms, too. But for now, only Windows is
interesting for us.

CCBUG: 393779

Reviewers: kossebau, aaronpuchert, brauch

Reviewed By: brauch

Subscribers: brauch, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15955

Fixup for 514036de &
11bc71c1

ClangHelpers seems to be the better fit (it's DUChain agnostic)

Summary:
Due to Qt not providing OOTB support for parallel installation of different
base versions (like Qt4 and Qt5), Linux distributions have separated into
different approaches how to name the Qt tools like qmake and qdbus.
Many use -qt4 and -qt5 suffixes and link the normal name to a variant, e.g.
controlled by a custom tool qtchooser. Others kept the Qt4 versions to stay
with the names, and only added a suffix -qt5 to the new ones.

Test Plan:
There is no longer a warning about missing qtdbus in the embedded konsole on
opening. The commands like search! & Co. work again.

Reviewers: #kdevelop, lbeltrame, fvogt, jriddell, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15606