1. 17 Dec, 2018 1 commit
  2. 14 Dec, 2018 1 commit
  3. 10 Dec, 2018 1 commit
  4. 09 Dec, 2018 1 commit
  5. 08 Dec, 2018 1 commit
  6. 06 Dec, 2018 1 commit
  7. 03 Dec, 2018 1 commit
  8. 01 Dec, 2018 1 commit
  9. 27 Nov, 2018 3 commits
  10. 26 Nov, 2018 5 commits
    • Morten Volden's avatar
      Use qCWarning in path.cpp. · 22c9a57f
      Morten Volden authored
      Summary: Change from qWarning to Using qCWarning in Path.cpp
      
      Test Plan: Build on both Windows and Linux
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17174
      22c9a57f
    • Morten Volden's avatar
      Fix qmakeproject unittest to work on Windows. · e3de5953
      Morten Volden authored
      Summary: Fix qmakeproject unittest to work on Windows
      
      Test Plan: Build on Windows, verify test passes. Build on Linux, verify test passes (as before).
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17158
      e3de5953
    • Morten Volden's avatar
      Fix defines and includes test to run on Windows. · b1ba6403
      Morten Volden authored
      Summary: Fix defines and includes test to run on Windows. Change the projects generator to use the 'new' way of generating project files. That way it's easier to handle the fact that we use different paths on different platforms.
      
      Test Plan: Build on Windows and confirm that test is passing. Build on Linux and confirm that test (test_definesandincludes and test_compilerprovider since they both depend on projectgenerator ) still pass.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17156
      b1ba6403
    • Morten Volden's avatar
      Fix projectmodel unittest to work on Windows. · de81ab5c
      Morten Volden authored
      Summary: Fix projectmodel unittest to work on Windows. Use paths according to the platform we are using
      
      Test Plan: Compile and test on Windows (Debug build) to see the unittests are passing. Compile and test on Linux to see that the test pass (As before)
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17130
      de81ab5c
    • Morten Volden's avatar
      Make the filteringstrategy test work on Windows as well. · d46ed701
      Morten Volden authored
      Summary: This requires some changes to some of the regexes used in CompilerFilterStrategy to get to work. Also the test itself is now somewhat more specific about what path type to test on which platform.
      
      Test Plan: Compile the changes on Windows and verify that the test now passes (In Debug mode). Compile the changes on Linux and verify that all tests pass (as before). Verify that the bench number still look reasonable
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17098
      
      (cherry picked from commit 35026c08)
      d46ed701
  11. 24 Nov, 2018 1 commit
    • Morten Volden's avatar
      Fix problem model test on Windows. Make sure that when we create a path the... · 436303a9
      Morten Volden authored
      Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform. E.g. C: on Windows.
      
      Summary: Fix problem model test on Windows. Make sure that when we create a path the root of that path is created according to what is expected on the current platform.
      
      Test Plan: Build and test on Windows. See that the test is passing. Build on Linux and verify that test is passing (As before)
      
      Reviewers: #kdevelop, brauch
      
      Reviewed By: #kdevelop, brauch
      
      Subscribers: brauch, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D17131
      436303a9
  12. 22 Nov, 2018 3 commits
  13. 21 Nov, 2018 4 commits
  14. 19 Nov, 2018 2 commits
    • Kevin Funk's avatar
      patchreview: Restore libkomparediff2 5.0 support · e2d5023e
      Kevin Funk authored
      Failed with:
      /usr/include/libkomparediff2/kompare.h:93:32: error: 'QString::QString(const char*)' is private within this context
          QString _localDestination = "",
                                      ^~
      
      (cherry picked from commit b03b30c2)
      e2d5023e
    • Kevin Funk's avatar
      Increase timeout for duchain gcc compatibility test · 6b645175
      Kevin Funk authored
      Summary:
      This test depends on your system configuration and the presence of many headers.
      Running the test in debug mode with address sanitizer can make it slow, so 5 seconds might not be enough.
      In fact, it takes around ~10seconds here. Plus the test also fails on the CI because of the short timeout.
      
      Increasing it to 60secs solves the problem for me.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16541
      6b645175
  15. 16 Nov, 2018 3 commits
    • Friedrich W. H. Kossebau's avatar
      Auto-find Clazy documentation also with clazy >= 1.4 · fee3dd68
      Friedrich W. H. Kossebau authored
      Summary:
      BUG: 401075
      FIXED-IN: 5.3.1
      
      Test Plan:
      Remove entries from kdeveloprc, paths are auto.detected both with
      clazy 1.4 and clazy 1.3 (well, its simulated doc path).
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16910
      fee3dd68
    • Friedrich W. H. Kossebau's avatar
      Disable plugin project config if project without a IBuildSystemManager dep · a3c782ac
      Friedrich W. H. Kossebau authored
      Summary:
      The Clazy plugin relies on the project providing a buildsystem manager
      to query for the toplevel build directory. If a project has no such manager,
      showing the Clazy plugin config pages in the project settings has no
      purpose.
      As a session might contain different projects, some with a buildsystem
      manager, some without, simply disabling the Clazy plugin might not be
      wanted for the projects with a buildsystem manager.
      So we need to have some condition whether to show some plugins per-project
      config pages or not.
      For a start, motivated by the crash with the Clazy plugin which has a
      hard assumption of project->buildSystemManager() being != nullptr,
      this patch adds to the code to collect the config pages for the project
      settings dialog some special code which makes use of the plugin metadata
      to skip plugins which require a org.kdevelop.IBuildSystemManager, if
      there is no buildsystem manager available for the project.
      As well adds the (so far missing) entry
      X-KDevelop-IRequired: [org.kdevelop.IBuildSystemManager]
      to the metadata.
      
      BUG: 400769
      
      Test Plan:
      Clazy config is no longer shown in the project settings dialog if the
      project is used with the generic project manager.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16915
      a3c782ac
    • Rolf Eike Beer's avatar
      tests: fix naming of test lines · 7b9572d3
      Rolf Eike Beer authored
      (cherry picked from commit 2e82c3e5)
      7b9572d3
  16. 15 Nov, 2018 3 commits
    • Friedrich W. H. Kossebau's avatar
    • Kevin Funk's avatar
      appimage: Do not bundle libfontconfig · c33cd259
      Kevin Funk authored
      Summary:
      The bundled libfontconfig seems to cause problems when the target system uses
      a newer font config format. See discussion here:
        https://mail.kde.org/pipermail/kdevelop/2018-October/019726.html
      
      It seems to be a common problem (as seen in bug reports of other AppImage
      projects).
      
      It's also blacklisted in linuxdeployqt:
        https://github.com/AppImage/AppImages/blob/master/excludelist
      
      For me locally, after the change I also have the exact same font appearance
      as with native applications. Before the patch the fonts did use my
      anti-aliasing settings iiuc. Before the patch, running the AppImage resulted
      in lots of warnings:
      
      ```
      Fontconfig warning: line 5: unknown element "its:rules"
      Fontconfig warning: line 6: unknown element "its:translateRule"
      Fontconfig warning: line 9: unknown element "description"
      Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 4: unknown element "its:rules"
      Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 5: unknown element "its:translateRule"
      Fontconfig warning: "/etc/fonts/conf.d/10-hinting-slight.conf", line 8: unknown element "description"
      ...
      ```
      
      ... these warnings are now gone.
      
      Thanks for the analysis by Friedrich.
      
      Actually easy to test using the new AppImage format. Just do:
      
      ```
      ./KDevelop-5.3.0-x86_64.AppImage --appimage-extract
      cd squashfs-root
      ./AppRun # to check appearance before
      rm rm usr/lib/libfontconfig.so.1
      ./AppRun # to check appearance after rm'ing the lib
      ```
      
      Reviewers: brauch, kossebau, cullmann
      
      Reviewed By: cullmann
      
      Subscribers: cullmann, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16893
      c33cd259
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · ed9a784f
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      ed9a784f
  17. 14 Nov, 2018 1 commit
  18. 03 Nov, 2018 1 commit
  19. 31 Oct, 2018 3 commits
    • Friedrich W. H. Kossebau's avatar
      cmake: fix missing addition of policies to documentation index · c8847264
      Friedrich W. H. Kossebau authored
      Summary:
      Since cmake 3.0 cmake also supports --help-policy-list, matching the
      general --help* pattern. The KDevelop cmake documentation plugin
      already has an entry for "Policies", just it is not filled with any
      content.
      This patch extends the content indexing by also including the policy.
      For cmake < 3.0 the process CMakeCommandsContents::processOutput will
      catch the failing call by the exit code, and things are as before.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15882
      
      (cherry picked from commit 2f0f3da7)
      c8847264
    • Bernd Buschinski's avatar
      FunctionDefinition: only look for (new/other) function definition if we don't have one · 3c51faa2
      Bernd Buschinski authored
      Summary:
      FunctionDefinition::definition always looks for FunctionDefinition based on the DeclarationId, but we don't need to do that if we already have a FunctionDefinition.
      This could cause problems if we have multiple (same) definitions.
      
      Test Plan:
      - create a small cmake (or whatever) project with 3 targets
      -- util1.c / util2.c / util3.c (same content):
      
      ```
      #include <stdio.h>
      #include <stdlib.h>
      
      void configure()
      {
          printf("do stuff in %s\n", __FILE__);
      }
      
      int main(int argc, char *argv[])
      {
          configure();
          puts("Hello, UTIL!");
          exit(EXIT_SUCCESS);
      }
      ```
      
      -- CMakeLists.txt:
      ```
      add_executable(util1 util1.c)
      add_executable(util2 util2.c)
      add_executable(util3 util3.c)
      ```
      
      - open util1.c
      - open the outline and select "configure"
      - EXPECTED: it should open the configure in util1.c (or the currently opened file)
      - repeat with util2 and util3
      - ACTUAL: only one of them works, the other two point to the wrong file.
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16356
      3c51faa2
    • Bernd Buschinski's avatar
      Fix memleaks in duchain unittests · c3c30113
      Bernd Buschinski authored
      Summary:
      The TypeSystem::create test was changed as now the destruction is also taken into account for QBENCHMARK
      
      The TopDUContext dtor is protected, however you can execute
      delete TopDUContext; but it will NOT call the protected TopDUContext dtor but the public DUContext dtor.
      
      Test Plan:
      - compile kdevelop unitest with ASAN&LSAN
      - execute test_duchain
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16458
      c3c30113
  20. 28 Oct, 2018 2 commits
    • Francis Herne's avatar
      Remove unmaintained and buggy CVS plugin · 0fc8dddf
      Francis Herne authored
      The plugin causes hangs or crashes of KDevelop during some of the most
       common operations.
      
      We haven't received any external bug reports for
       this (nor from 5.0-beta1 to 5.2.1 when the plugin was entirely
       non-functional), so it appears that no-one has attempted to use this
       feature.
      
      Advertising this as a "feature" when it's unusable with no real prospect
       of being fixed will only hurt KDevelop's reputation if anyone does try
       to use it. Of course the code is in git history in case it's wanted in
       future.
      0fc8dddf
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · edb437a9
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      edb437a9
  21. 26 Oct, 2018 1 commit
    • Kevin Funk's avatar
      Minor: Silence spurious Clang warning · cf0ff290
      Kevin Funk authored
      Warning:
        .../kdevplatform/shell/sessioncontroller.cpp:371:12: warning: local variable 'l' will be copied despite being returned by name [-Wreturn-std-move]
      cf0ff290