GitLab

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

This is just a thin wrapper around the engine and it has very few usages.

See https://phabricator.kde.org/T14010 for the discussion.

NO_CHANGELOG

Never delete KPackage::PackageStructure instances, as they are managed
internally by KPackage. This is the third go at fixing a crash here
(last one worked almost always, this should work more generally, even if
just leaving a pointer i've been handed flying about feels super
unpleasant).

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

This property is only set to true in very few
places and the downloadable items do not contain
a HTML page.

And IMO the user should always be prompted in case
there is anything unusual.

The KVHTML files used in KDE-Edu have the mimetype
of normal XML files, consequently we do not
have to worry about those.

These properties are never read and the consequently
the feature does not exist anymore.
Adding checksum verification is still a TODO, but
having defunct properties does not help with that.

And if this gets reimplemented I see no valid reason
why one wants to disable it.

This property is completely unused. Also it seems like
a really bad idea to install third-party files in the system scope.

This makes the old KFontinst provider work with the QtQuick
wrapper class. Maybe we should consider deprecating the
`payload()`concept in KF6, but for now it should work.

GIT_SILENT

Previously, the throttle timer was a raw static, but it was also a parented qobject, which means that when the cache was deleted, so was the timer, but the variable was not reset. Consequently, things would crash left and right later on. So, to alleviate this, and hopefully avoid future issues, introduce a dptr, stick the timer there, and move the logic to that private class as well.

BUG:429442

FIXED-IN:5.78

This will allow KCMs and applications to utilize the
QtQuick dialog without needing to be rewritten in QML.

Also some signals are directly forwarded from the engine,
this will make the consumers more flexible when
reacting to installed/updated/uninstalled entries or
the adoption command.

Once the existing usages have been ported we can
officially deprecate the old QWidgets stuff.

The unit test failed, because the messages were not recived.
Also in the line below the result is properly checked, so
checking the message is IMO not necessary.

The version is not mandatory and often empty. In that
case we do not want to end up with a "-" at the end of the
string.

At the moment we were just refusing to uninstall and giving a misleading
error message.

This changes it so when there's nothing installed we notify about no
updates being found.

CCBUG: 418082

Otherwise the engine would make a new network request, this is quite
wasteful and lets the user wait a moment.
Also this appears to fixes the crash, you can try this out by quickly
opening and closing the dialog.

Additionally this makes it consistent with the QtQuick one.

From the stacktrace I got this seems to fix BUG 429302.

BUG: 416328
BUG: 429302
FIXED-IN: 5.77

The KPackage occurrences have already been ported and the
wallpaper compatibility block only affects one file which
will be ported too.

In KF6 we can do this more clean fashion by using a
d-ptr. But for now this is the best we can do and it
is more readable than comparing string values.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

GIT_SILENT

GIT_SILENT