Krita merge requestshttps://invent.kde.org/dkazakov/krita/-/merge_requests2023-01-03T12:58:43Zhttps://invent.kde.org/dkazakov/krita/-/merge_requests/10Port Clone engine to Lager2023-01-03T12:58:43ZSharaf ZamanPort Clone engine to Lagerhttps://invent.kde.org/dkazakov/krita/-/merge_requests/8Port Sketch engine to Lager2022-12-23T15:07:18ZFreya LupenPort Sketch engine to LagerRefactors kis_sketchop_option into
KisSketchOpOption Data/Model/Widget files,
and density, linewidth, and offset_scale options
into KisSketchStandardOptions / OptionData.
It seems to work, but I have some doubts code-wise:
There was som...Refactors kis_sketchop_option into
KisSketchOpOption Data/Model/Widget files,
and density, linewidth, and offset_scale options
into KisSketchStandardOptions / OptionData.
It seems to work, but I have some doubts code-wise:
There was some code in kis_sketch_paintop_settings_widget.cpp
to modify some XML configuration, which was triggering
`SAFE ASSERT (krita): "data" in file src/plugins/paintops/libpaintop/kis_brush_option_widget.cpp, line 109`.
I couldn't figure out what the code was supposed to do, so it might be wrong to remove it.https://invent.kde.org/dkazakov/krita/-/merge_requests/7Port Bristle (Hairy) engine to Lager2022-12-23T14:17:32ZFreya LupenPort Bristle (Hairy) engine to LagerRefactors kis_hairy_bristle and hairy_ink options into KisHairyBristle/Ink Option Data/Model/Widget files.
It works, but I'm not sure about some of the code, namely:
* The connectControlCurve function, which I put in KisHairyInkOptionWi...Refactors kis_hairy_bristle and hairy_ink options into KisHairyBristle/Ink Option Data/Model/Widget files.
It works, but I'm not sure about some of the code, namely:
* The connectControlCurve function, which I put in KisHairyInkOptionWidget because it couldn't be included in KisWidgetConnectionUtils. If this is the correct way to do this, where should it be?
* kis_hairy_paintop_settings.cpp used a constant which is now in KisHairyBristleOptionData.cpp, which doesn't seem to be includeable.https://invent.kde.org/dkazakov/krita/-/merge_requests/2WIP: Fix handling of zero-width shapes in Krita2020-03-23T14:38:47ZDmitry KazakovWIP: Fix handling of zero-width shapes in KritaThe patchset fixes hangups and just when handling zero-width shapes (lines)
Test Plan
---------
0) Create a horizontal vector line by pressing Shift while dragging
1) Resize line
* normal mode
* global mode
* scale styles mode...The patchset fixes hangups and just when handling zero-width shapes (lines)
Test Plan
---------
0) Create a horizontal vector line by pressing Shift while dragging
1) Resize line
* normal mode
* global mode
* scale styles mode
* multiselection mode
* aspect ratio locked mode (including Shift)
* all above when shape(s) is(are) rotated
2) Shear line
3) Edit stroke/fill gradienthttps://invent.kde.org/dkazakov/krita/-/merge_requests/1Fixes rendering of gamut masks, drops KisGamutMaskViewConverter2019-12-03T14:45:57ZAnna MedonosováFixes rendering of gamut masks, drops KisGamutMaskViewConverterI have refactored gamut mask rendering to work with the shape masks rendering fix. Rotation also works. I have dropped KisGamutMaskViewConverter entirely, as we can now do without it.I have refactored gamut mask rendering to work with the shape masks rendering fix. Rotation also works. I have dropped KisGamutMaskViewConverter entirely, as we can now do without it.