1. 15 Jan, 2014 1 commit
  2. 12 Jan, 2014 1 commit
  3. 03 Jan, 2014 1 commit
    • Arjun Ak's avatar
      Fix: segfault by clicking empty area in Cover Manager · ff55aeaf
      Arjun Ak authored
      This patch fixes the segmentation fault crash caused by clicking on an
      empty area in the cover manager.
      
      Thanks to Arjun Ak for the bugfix (you've been marked as the author),
      and André Marcelo Alvarenga for reporting the bug
      
      REVIEW: 114635
      BUG: 326710
      ff55aeaf
  4. 21 Dec, 2013 1 commit
  5. 12 Dec, 2013 1 commit
  6. 08 Dec, 2013 1 commit
  7. 30 Nov, 2013 2 commits
    • Shubham Chaudhary's avatar
      Krazy fixes from ebn · dde52a0e
      Shubham Chaudhary authored
      Changes:
      * single quote chars
      * casted floats to qBound
      * KUrl instead of QUrl
      * removed empty spaces
      * added newline at eof
      
      REVIEW: 114217
      dde52a0e
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  8. 27 Nov, 2013 1 commit
  9. 24 Nov, 2013 1 commit
  10. 19 Nov, 2013 1 commit
  11. 18 Nov, 2013 1 commit
  12. 11 Nov, 2013 2 commits
  13. 08 Nov, 2013 2 commits
  14. 03 Nov, 2013 1 commit
  15. 02 Nov, 2013 1 commit
  16. 30 Oct, 2013 1 commit
  17. 24 Oct, 2013 1 commit
  18. 22 Oct, 2013 1 commit
  19. 13 Oct, 2013 1 commit
  20. 11 Oct, 2013 1 commit
  21. 09 Oct, 2013 1 commit
  22. 08 Oct, 2013 1 commit
  23. 06 Oct, 2013 1 commit
    • Shubham Chaudhary's avatar
      Notify the user that JuK is docked on startup. · 61e5fc8d
      Shubham Chaudhary authored
      We show a simple notification if the user starts up JuK and it is set to
      dock in the systray on startup (as otherwise the user may wonder why it
      didn't open up). Although a "Do not show again" checkbox is not possible
      with KNotification, it is possible to remove this additional
      notification by going to "Application and System Notifications" in
      System Settings to manage "Juk music player" application notifications.
      
      We do *not* show a notification if a session is being restored to avoid
      noise, however JuK will show the main window if the user tries to start
      it up again after it's already running, so this should be OK.
      
      Thanks to Shubham Chaudhary for the bugfix (you're been marked as the
      patch author), and Michael for reporting the bug.
      
      This bugfix adds new strings so it cannot be backported. It will show up
      first in KDE SC 4.12.
      
      BUG:316832
      FIXED-IN:4.12
      GUI:
      61e5fc8d
  24. 03 Sep, 2013 4 commits
  25. 25 Aug, 2013 1 commit
  26. 20 Aug, 2013 1 commit
  27. 17 Aug, 2013 2 commits
  28. 24 Jul, 2013 2 commits
  29. 14 Jul, 2013 1 commit
    • Michael Pyne's avatar
      coverinfo: Do not crash if an MP3 file has no ID3 tag. · 0318fb35
      Michael Pyne authored
      This rarely happens since taglib will simply create an ID3 tag if one
      didn't exist before... but taglib can't do this if it can't find the
      file, which now seems to occur for files with a non-UTF8 filename
      encoding.
      
      You see this as a 'Couldn't resolve the mime type of <<foo>> -- this
      shouldn't happen' message on the console. In this situation JuK is able
      to resolve the file to an appropriate TagLib::File subclass, but the
      TagLib object is in an invalid state.
      
      CoverInfo wasn't checking for this (it was assuming any TagLib::File*
      that it was given was valid).
      
      I took a look through the reported JuK crasher bugs and didn't see
      anything relevant.
      
      I'm not sure whether this will end up in the KDE SC 4.11 or 4.11.1.
      0318fb35
  30. 30 Jun, 2013 2 commits
  31. 29 Jun, 2013 1 commit
    • Michael Pyne's avatar
      mpris2: Make some adapter methods async. · 629f9dc9
      Michael Pyne authored
      This is another attempt to work around JuK <=> Plasma DBus deadlocks,
      but making some of the DBus methods that Plasma would call into via the
      MPRIS2 interface be async.
      629f9dc9