1. 19 Oct, 2018 4 commits
  2. 10 Oct, 2018 2 commits
  3. 07 Oct, 2018 3 commits
  4. 03 Oct, 2018 1 commit
  5. 26 Sep, 2018 1 commit
    • Luigi Toscano's avatar
      LyricWiki: link to the actual lyrics page · eb1d9b62
      Luigi Toscano authored
      Summary:
      Instead of pointing to the homepage of the wiki,
      set the link to the actual page of the lyrics
      which are being shown.
      
      BUG: 332664
      FIXED-IN: 18.12.0
      
      Test Plan:
      The link to the LyricsWiki points to the actual page.
      Nothing changes when the lyrics are not found.
      
      Reviewers: mpyne
      
      Reviewed By: mpyne
      
      Differential Revision: https://phabricator.kde.org/D15303
      eb1d9b62
  6. 23 Sep, 2018 1 commit
  7. 22 Sep, 2018 2 commits
  8. 02 Sep, 2018 2 commits
  9. 31 Aug, 2018 1 commit
  10. 19 Aug, 2018 2 commits
  11. 18 Aug, 2018 2 commits
  12. 06 Aug, 2018 1 commit
  13. 30 Jul, 2018 1 commit
  14. 16 Jul, 2018 2 commits
  15. 04 Jul, 2018 1 commit
    • Michael Pyne's avatar
      Bring back inline tag editing. · 117646dd
      Michael Pyne authored
      This was a KDE 4 JuK feature that had been left disabled in the port to
      Plasma 5/KF5. I finished the implementation here in response to a user
      request.
      
      Given the code changes it's technically best described as a new feature
      (even if it used to work in KDE 4) so it probably won't show up until
      the next release of KDE Applications, though it should be safe to
      backport for interested distributions.
      
      GUI:
      BUG:395948
      FIXED-IN:18.08
      117646dd
  16. 03 Jul, 2018 1 commit
  17. 02 Jul, 2018 2 commits
  18. 29 Jun, 2018 1 commit
  19. 19 Jun, 2018 1 commit
  20. 17 Jun, 2018 1 commit
  21. 25 Apr, 2018 1 commit
  22. 09 Apr, 2018 1 commit
  23. 02 Apr, 2018 1 commit
  24. 25 Mar, 2018 3 commits
    • Michael Pyne's avatar
      systray: Ensure quit from systray also saves config changes. · 30cd501f
      Michael Pyne authored
      KStatusNotifierItem's 'maybeQuit' function is more than happy to call
      qApp->quit directly even though the standard quit action is available to
      be triggered and would do the right thing.
      
      Qt documents you can use aboutToQuit to catch this case, and it does
      seem to work.
      30cd501f
    • Michael Pyne's avatar
      Simplify shutdown handling. · a951caf3
      Michael Pyne authored
      JuK would fail to shutdown properly under Plasma 5 when the system tray
      was disabled and you used the 'X' from the window manager title bar to
      try to close JuK.  May have failed under other WMs or desktops as well,
      I haven't tested that.
      
      The shutdown code hasn't been reworked since KDE 3 times and for all I
      know I introduced this bug with the setQuitOnLastWindowClosed setting in
      main.cpp years ago and never realized.
      
      But this way, any way you destroy the main application class (JuK), you
      end up shutting down.  Continuing to use setQuitOnLastWindowClosed
      appears to be necessary since Qt will remove the queued quit signal to
      qApp once JuK is destructed and I don't trust running qApp->quit within
      the JuK dtor itself.
      
      Hopefully this fixes a crash-on-quit bug, but if not just reopen and
      I'll figure it out somehow...
      
      FIXED-IN:18.04
      BUG:388663
      a951caf3
    • Michael Pyne's avatar
      Don't try to start in docked mode without the systray. · 1eed4730
      Michael Pyne authored
      It appears to be possible to configure JuK to start in docked mode even
      if the system tray icon has been disabled by the user, which is quite
      pointless.  Prevent this by forcing the window to be shown at startup if
      the system tray icon is not turned on.
      1eed4730
  25. 19 Mar, 2018 2 commits