GitLab

Includes template-template parameter usage in playlist.h's createItems
until all usages of QList gone.

Large music libraries can cause dozens/hundreds or even more of threads
to be created at once. But all we really need is to do the loading off
of the GUI thread, and the I/O will be the bottleneck no matter how many
threads we use. So use Qt Concurrent to manage a threadpool instead,
which also simplifies the code somewhat.

I also fixed the broken global status updating when using threaded
loader while refactoring to support this.

I ran into all the problems one might expect from adding threading to an
old codebase but this variant seems pretty stable.

The benefit is that the heavy I/O with large music libraries is now off
of the GUI thread. So even though it will still take awhile to load all
music until I fix the bug(s) with using cached tags, at least the
application itself will be responsive while it loads audio.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

A prior code cleanup started trying to open the default KWallet
automatically, skipping the existing check for whether scrobbling is
enabled. Instead of reverting, add the check to the wallet opening code,
which already has to handle the possibility of failure.

Based on patch provided by tanjoodo, but simplified to create the
missing QNetworkAccessManager unilaterally.

This avoids a crash in the scrobbler when scrobbling is attempted with
an active session but no network manager (such as when the configured
internet connection is lost).

Differential Revision: https://phabricator.kde.org/D17140

GUI: This fixes things like the warning icons in the file deletion
dialog, file renamer, menu icons (such as Create Playlist from Selected
Items), and the "Jump to Playing Track" button on the status bar.

The track position slider remains unfixed.

This lets Hi-DPI displays to show cover art (when clicking the cover in
the "Now Playing" bar) at its native resolution even when using screen
scaling.

This is probably suboptimal for smaller covers but most embedded cover
art I find in the recent few years is already more than large enough to
show up fine this way.

CHANGELOG: Show embedded music cover art at native display resolution.

Conflicts:
	CMakeLists.txt

As submitted by Guo Yunhe <i@guoyunhe.me> on kde-multimedia.

In my testing this only applies with QT_AUTO_SCREEN_SCALE_FACTOR
environment variable enabled, but does indeed allow for many (not all)
pixmaps to automatically load high-res versions (such as from
KIconLoader).

I consider this a bugfix and the support is non-invasive, so applying to
18.12 and will merge to master separately.

Note that the cover art and slider art is still suboptimal.

Conflicts:
	playermanager.cpp

This fixes a bug that recently hit its 8 year anniversary. :(

The big issue was that there was no easy way to tell which keyboard
modifiers were set for the systray since Qt's event loop didn't actually
receive the keyboard events.

There's a separate function you can call, queryKeyboardModifiers, which
makes a specific query to the desktop, and works even if Qt event loop
didn't receive keyboard events. This fixes the bug here, and hopefully
for everyone else.

In fixing the bug I noticed that we can set out-of-bounds volumes due to
lack of checking, so I fixed that too.

BUG:250355
FIXED-IN:18.08.3

I did this because I got annoyed about my own log messages about
inhibiting/uninhibiting power management.

This ultimately was because Phonon forces a stop and then restart
sequence whenever forcibly changing the current media source, as we were
doing to switch tracks.

Phonon provides a way to queue up additional tracks to play when
playback is about to end which keeps itself in a playing state. I use
this method, which may also theoretically make gapless playback work.

This makes the playback handler that accepts a FileHandle on purpose a
bit easier to think through.

The only reason we couldn't perform setup on construction was because of
some U/I setup code that couldn't happen when the player manager is
normally constructed.

But the U/I setup is simple enough to move to JuK, so do so. Now the
rest of PlayerManager is that much simpler.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- make sure the XML with the album is the one we expect (<lfm> as
  root element)
- if the status is not "ok", inform whether the album was not found,
  or there was another error
- handle when the album has no cover

In all the above situations, WebImageFetcher does not attempt to start
a StoredTransferJob for an empty URL.

The dialog with the cover result is destroyed only if the user accepts
the result, showing no results for further searches in case the cover
dialog is cancelled.

Instead, make sure to destroy the cover dialog also in case the user
cancels it.

Summary:
Instead of pointing to the homepage of the wiki,
set the link to the actual page of the lyrics
which are being shown.

BUG: 332664
FIXED-IN: 18.12.0

Test Plan:
The link to the LyricsWiki points to the actual page.
Nothing changes when the lyrics are not found.

Reviewers: mpyne

Reviewed By: mpyne

Differential Revision: https://phabricator.kde.org/D15303

Summary:
With this change the time is correctly updated also when using
the VLC backend.
It worked for some reason with phonon-gstreamer, but it looks like
it's just by accident. In fact, according the documentation, the default
value of the property is 0:
https://api.kde.org/phonon/html/classPhonon_1_1MediaObject.html#ae0f0ab91c97a1f3495ed9467048bb81a

The choosen value (100) should allow for a fluid scrolling of the
progress element, without having a too small resolution, and
it seems to match the resolution of the gstreamer backend anyway.

BUG: 389907

Test Plan:
The time is updated on both the progress bar and the status bar with
both VLC and GStreamer Phonon backends.

Reviewers: mpyne

Reviewed By: mpyne

Differential Revision: https://phabricator.kde.org/D15222