1. 20 Oct, 2018 1 commit
    • Michael Pyne's avatar
      systray: Make SHIFT+Mousewheel change the volume, not the song. · e2012e79
      Michael Pyne authored
      This fixes a bug that recently hit its 8 year anniversary. :(
      
      The big issue was that there was no easy way to tell which keyboard
      modifiers were set for the systray since Qt's event loop didn't actually
      receive the keyboard events.
      
      There's a separate function you can call, queryKeyboardModifiers, which
      makes a specific query to the desktop, and works even if Qt event loop
      didn't receive keyboard events. This fixes the bug here, and hopefully
      for everyone else.
      
      In fixing the bug I noticed that we can set out-of-bounds volumes due to
      lack of checking, so I fixed that too.
      
      BUG:250355
      FIXED-IN:18.08.3
      e2012e79
  2. 07 Oct, 2018 1 commit
    • Pino Toscano's avatar
      WebImageFetcher: properly destroy dialog after any request · 441cb735
      Pino Toscano authored
      The dialog with the cover result is destroyed only if the user accepts
      the result, showing no results for further searches in case the cover
      dialog is cancelled.
      
      Instead, make sure to destroy the cover dialog also in case the user
      cancels it.
      441cb735
  3. 03 Oct, 2018 1 commit
  4. 22 Sep, 2018 1 commit
  5. 02 Sep, 2018 1 commit
  6. 31 Aug, 2018 1 commit
  7. 19 Aug, 2018 1 commit
  8. 18 Aug, 2018 1 commit
  9. 06 Aug, 2018 1 commit
  10. 30 Jul, 2018 1 commit
  11. 16 Jul, 2018 1 commit
  12. 04 Jul, 2018 1 commit
    • Michael Pyne's avatar
      Bring back inline tag editing. · 117646dd
      Michael Pyne authored
      This was a KDE 4 JuK feature that had been left disabled in the port to
      Plasma 5/KF5. I finished the implementation here in response to a user
      request.
      
      Given the code changes it's technically best described as a new feature
      (even if it used to work in KDE 4) so it probably won't show up until
      the next release of KDE Applications, though it should be safe to
      backport for interested distributions.
      
      GUI:
      BUG:395948
      FIXED-IN:18.08
      117646dd
  13. 03 Jul, 2018 1 commit
  14. 02 Jul, 2018 2 commits
  15. 29 Jun, 2018 1 commit
  16. 19 Jun, 2018 1 commit
  17. 17 Jun, 2018 1 commit
  18. 25 Apr, 2018 1 commit
  19. 09 Apr, 2018 1 commit
  20. 02 Apr, 2018 1 commit
  21. 25 Mar, 2018 3 commits
    • Michael Pyne's avatar
      systray: Ensure quit from systray also saves config changes. · 30cd501f
      Michael Pyne authored
      KStatusNotifierItem's 'maybeQuit' function is more than happy to call
      qApp->quit directly even though the standard quit action is available to
      be triggered and would do the right thing.
      
      Qt documents you can use aboutToQuit to catch this case, and it does
      seem to work.
      30cd501f
    • Michael Pyne's avatar
      Simplify shutdown handling. · a951caf3
      Michael Pyne authored
      JuK would fail to shutdown properly under Plasma 5 when the system tray
      was disabled and you used the 'X' from the window manager title bar to
      try to close JuK.  May have failed under other WMs or desktops as well,
      I haven't tested that.
      
      The shutdown code hasn't been reworked since KDE 3 times and for all I
      know I introduced this bug with the setQuitOnLastWindowClosed setting in
      main.cpp years ago and never realized.
      
      But this way, any way you destroy the main application class (JuK), you
      end up shutting down.  Continuing to use setQuitOnLastWindowClosed
      appears to be necessary since Qt will remove the queued quit signal to
      qApp once JuK is destructed and I don't trust running qApp->quit within
      the JuK dtor itself.
      
      Hopefully this fixes a crash-on-quit bug, but if not just reopen and
      I'll figure it out somehow...
      
      FIXED-IN:18.04
      BUG:388663
      a951caf3
    • Michael Pyne's avatar
      Don't try to start in docked mode without the systray. · 1eed4730
      Michael Pyne authored
      It appears to be possible to configure JuK to start in docked mode even
      if the system tray icon has been disabled by the user, which is quite
      pointless.  Prevent this by forcing the window to be shown at startup if
      the system tray icon is not turned on.
      1eed4730
  22. 19 Mar, 2018 2 commits
  23. 17 Mar, 2018 1 commit
  24. 13 Mar, 2018 1 commit
  25. 06 Mar, 2018 2 commits
    • Luca Beltrame's avatar
      Fix build with Qt 5.11 · 2e2c31c3
      Luca Beltrame authored
      2e2c31c3
    • Michael Pyne's avatar
      mpris: Don't toggle playback with "Pause". · 57457aee
      Michael Pyne authored
      We already have a separate playPause action for this, both in the MPRIS2
      DBus adaptor, and in PlayerManager.
      
      This also fixes playback resuming when the computer is suspended (Plasma
      sends the "Pause" command to each media player regardless of whether
      it's playing, and JuK incorrectly treats that as a request to toggle
      playback).
      
      BUG:381271
      FIXED-IN:18.04
      57457aee
  26. 04 Mar, 2018 1 commit
    • Michael Pyne's avatar
      Remove ancient Exec= key from .desktop file. · 21264845
      Michael Pyne authored
      Should allow JuK to start on Wayland.  Should also allow arguments to be
      passed to JuK (which in theory supports loading files from command
      line).
      
      I ask for URLs to be passed (%U) instead of files (%F) to avoid
      over-eager file managers or desktops trying to download music files to a
      temp directory and then deleting them once JuK is done.
      
      GUI:
      BUG:391354
      FIXED-IN:18.04
      21264845
  27. 03 Mar, 2018 1 commit
  28. 21 Feb, 2018 2 commits
  29. 13 Feb, 2018 2 commits
  30. 11 Feb, 2018 1 commit
  31. 10 Feb, 2018 3 commits
    • Michael Pyne's avatar
      Extract Playlist::SharedSettings into a separate file. · 90a6b862
      Michael Pyne authored
      This helps declutter playlist.cpp and even makes it seem a bit easier to
      read through, I think.
      
      I also tried to fix a couple of outstanding bugs along the way, for
      instance reordering columns should work now, although there's still a
      lot of improvements that need to be made here.
      90a6b862
    • Michael Pyne's avatar
      Stop playback before taking shutdown actions. · 18eed01d
      Michael Pyne authored
      This seems to prevent a gstreamer deadlock I sometimes get when trying
      to quit, though it's only a guess as to whether this is the cause or
      not.
      18eed01d
    • Michael Pyne's avatar
      More column-handling bugfixes in Playlist. · 2ea8a84d
      Michael Pyne authored
      - The showColumn/hideColumn functions work on visual indices, not
      logical indices, so converting a visual index to a logical one is both
      wrong and extra work.
      - The "Show Columns" menu was just flatly checking every column, even
      the ones that weren't shown.
      2ea8a84d