1. 20 Oct, 2018 1 commit
    • Michael Pyne's avatar
      systray: Make SHIFT+Mousewheel change the volume, not the song. · e2012e79
      Michael Pyne authored
      This fixes a bug that recently hit its 8 year anniversary. :(
      The big issue was that there was no easy way to tell which keyboard
      modifiers were set for the systray since Qt's event loop didn't actually
      receive the keyboard events.
      There's a separate function you can call, queryKeyboardModifiers, which
      makes a specific query to the desktop, and works even if Qt event loop
      didn't receive keyboard events. This fixes the bug here, and hopefully
      for everyone else.
      In fixing the bug I noticed that we can set out-of-bounds volumes due to
      lack of checking, so I fixed that too.
  2. 12 Oct, 2017 1 commit
    • Michael Pyne's avatar
      systemtray: Fix crash with scroll-to-next. · ee358b1b
      Michael Pyne authored
      And crashes involving other action invocations.  We need to guard
      against KSNI::action everywhere action() is called, not just in the
      ctor.  A good Junior Job might be going through and renaming the
      JuK-specific ActionCollection and action() functions to something a
      little less likely to conflict with KDE or Qt namespace.
  3. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
  4. 30 Sep, 2017 1 commit
  5. 27 Aug, 2017 1 commit
    • Michael Pyne's avatar
      Fix QActions in systray. · 24246f52
      Michael Pyne authored
      Turns out KStatusNotifierItem introduces its own ActionCollection and
      its own corresponding action() method call, which SystemTray was calling
      in preference to JuK's own ActionCollection::action() namespace fn.
  6. 26 Aug, 2017 2 commits
  7. 25 Aug, 2017 1 commit
  8. 26 Jul, 2017 2 commits
  9. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
  10. 14 Jun, 2013 1 commit
  11. 31 Jul, 2011 1 commit
  12. 22 Sep, 2010 1 commit
  13. 26 Aug, 2010 1 commit
  14. 24 Aug, 2010 1 commit
  15. 23 Aug, 2010 1 commit
  16. 30 Jul, 2010 1 commit
  17. 24 Jul, 2010 1 commit
    • Michael Pyne's avatar
      Fix bug 230041 (JuK system tray tooltip clips letters in words instead of at spaces) in · 6d3c7e57
      Michael Pyne authored
      trunk by applying two patches provided by Glad Deschrijver.
      The first removes an old hack that had been keeping lines from being broken that doesn't
      work with the new DBus-based system tray.
      The second patch uses italics on the song title to get the intended effect of the first,
      an easy visual distinction between song artist and title. This one could be bad depending
      on the font, but there are plenty of high-quality free fonts available, and we can't even
      blame the Apple font hinting patent now.
      Will backport to 4.5 as the fix is completely non-invasive and corrects an annoying visual
      flaw in the UI experience.
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1153775
  18. 19 Feb, 2010 1 commit
  19. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
  20. 30 Oct, 2009 1 commit
  21. 20 Sep, 2009 1 commit
  22. 18 Sep, 2009 1 commit
  23. 28 Apr, 2009 1 commit
  24. 12 Jan, 2009 1 commit
  25. 15 Aug, 2008 1 commit
  26. 26 Jun, 2008 2 commits
  27. 03 Jun, 2008 1 commit
  28. 20 May, 2008 1 commit
  29. 12 Jan, 2008 2 commits
  30. 19 Dec, 2007 1 commit
  31. 17 Nov, 2007 1 commit
  32. 03 Oct, 2007 1 commit
  33. 18 Jun, 2007 1 commit
  34. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      In addition many loops have been foreach()'ed, which really does make it more readable.
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      I haven't seen any regressions yet but then again I still can't play music either.
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
  35. 19 May, 2007 2 commits