1. 01 Feb, 2018 1 commit
    • Michael Pyne's avatar
      Extract Playlist::SharedSettings into a separate file. · f3171c17
      Michael Pyne authored
      This helps declutter playlist.cpp and even makes it seem a bit easier to
      read through, I think.
      
      I also tried to fix a couple of outstanding bugs along the way, for
      instance reordering columns should work now, although there's still a
      lot of improvements that need to be made here.
      f3171c17
  2. 31 Jan, 2018 1 commit
    • Michael Pyne's avatar
      Remove the 'emitChanged' hack in Playlist::createItem<> · 894e87d6
      Michael Pyne authored
      Whichever code is creating these items is in the best spot to know
      whether there will be one or many of these items and when the best time
      is to permit the playlist to sync up afterwards.  This permits the
      createItem functions to focus more on just that function.
      894e87d6
  3. 19 Jan, 2018 1 commit
  4. 07 Oct, 2017 1 commit
  5. 01 Oct, 2017 1 commit
    • Michael Pyne's avatar
      Remove Kdelibs4Support. · 1e3b90b8
      Michael Pyne authored
      This required a wide assortment of fixes, including deleting
      needless #include <koldfoo.h> headers, some minor additional porting
      tasks, and adding in includes that were previously only implicitly
      included.
      1e3b90b8
  6. 29 Sep, 2017 1 commit
  7. 28 Sep, 2017 1 commit
  8. 27 Aug, 2017 1 commit
  9. 26 Aug, 2017 1 commit
  10. 09 Aug, 2017 1 commit
  11. 27 Jul, 2017 5 commits
  12. 26 Jul, 2017 1 commit
  13. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  14. 30 Jun, 2013 1 commit
  15. 14 Jun, 2013 2 commits
  16. 06 Jun, 2013 1 commit
  17. 26 May, 2013 1 commit
  18. 10 Aug, 2011 1 commit
  19. 11 Jun, 2010 1 commit
    • Michael Pyne's avatar
      Finally get the "Time" column to show up in the history playlist. · e225bf7e
      Michael Pyne authored
      Between Qt 3 and Qt 4 the behavior of QWidget::polish() changed. What used to happen is
      that HistoryPlaylist created the first column (column 0) during construction by putting its
      addColumn call in HistoryPlaylist::polish(), which somehow got called before the Playlist
      class added its columns.
      
      In Qt 4 the polish method seems to have gone away, so we have to take different measures to
      ensure that the HistoryPlaylist gets first dibs on making columns. We do this by altering
      the ctor in Playlist to add placeholder columns for subclasses to control later.
      
      This fixes a long-standing JuK bug (since KDE 4.0) that doesn't seem to actually have been
      opened in b.k.o.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136889
      e225bf7e
  20. 16 Feb, 2009 1 commit
    • Michael Pyne's avatar
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove... · 2e865464
      Michael Pyne authored
      Last crasher bug I fixed was due to not using Playlist::clearItem() to remove a PlaylistItem.  I think it
      should always be possible to call delete on a PlaylistItem pointer and the Right Thing happens, so do a
      bit of refactoring to ensure that what happens in clearItem() is performed from the PlaylistItem dtor instead
      of running the PlaylistItem dtor from clearItem.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=926748
      2e865464
  21. 25 Sep, 2008 1 commit
  22. 26 Aug, 2008 1 commit
    • Michael Pyne's avatar
      Move much of the createItems<> templated method implementation to a helper function in playlist.cpp · 40c114dd
      Michael Pyne authored
      While doing so I managed to remove the need to have extraneous template types to avoid
      recursive includes so the code is a bit neater now as well.
      
      One functionality change is that items belonging to files that don't exist anymore are not
      created anymore.  Hopefully this will eliminate crashes on startup due to files in the collection
      being deleted between JuK startups.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=852974
      40c114dd
  23. 16 Jul, 2008 1 commit
  24. 14 May, 2008 1 commit
  25. 13 May, 2008 1 commit
  26. 09 Jan, 2008 1 commit
  27. 29 Sep, 2007 1 commit
  28. 24 Jun, 2007 2 commits
  29. 21 Jun, 2007 1 commit
  30. 04 Jun, 2007 1 commit
  31. 24 May, 2007 1 commit
    • Michael Pyne's avatar
      Fairly large overhaul of the JuK codebase to beat out a lot of the Qt 3 stuff. · 2c297413
      Michael Pyne authored
      Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
      Q3Dict should all be gone.
      
      In addition many loops have been foreach()'ed, which really does make it more readable.
      
      There is a crash fix as well, now the polish() function in Playlist has been replaced
      with an initialization slot which is singleShot'ed since the timing of the polish event
      is apparently different than it was in Qt 3, which was making new Playlists crash when
      they were first shown.
      
      Also I went through almost every header and pared it down to the minimum reasonably
      achievable, which required some additional headers in a few .cpp files but overall
      compilation time should be down and you won't have to rebuild all of JuK just because
      a header file got touched.
      
      I haven't seen any regressions yet but then again I still can't play music either.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815
      2c297413
  32. 19 May, 2007 1 commit
  33. 18 May, 2007 1 commit
  34. 04 May, 2007 1 commit