GitLab

Includes template-template parameter usage in playlist.h's createItems
until all usages of QList gone.

Whichever code is creating these items is in the best spot to know
whether there will be one or many of these items and when the best time
is to permit the playlist to sync up afterwards.  This permits the
createItem functions to focus more on just that function.

On second thought the whole FileHandle::null thing seems silly now.  It
made sense as an optimization when it was introduced but the extra
conceptual baggage is hard to maintain and far less important now.

This required a wide assortment of fixes, including deleting
needless #include <koldfoo.h> headers, some minor additional porting
tasks, and adding in includes that were previously only implicitly
included.

- define the logging categories using the specific ECM macro;
- remove the kdebug.h includes.

Thanks to Eric Newberry (from Google Code-In) for running the heavy
lifting on this.

I made some other corrections since we're touching all the source
anyways (e.g. fixing my email addresses), fixing the encoding of Richard
Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
comments so that there's no issue with trailing spaces/tabs.

REVIEW:114216

Between Qt 3 and Qt 4 the behavior of QWidget::polish() changed. What used to happen is
that HistoryPlaylist created the first column (column 0) during construction by putting its
addColumn call in HistoryPlaylist::polish(), which somehow got called before the Playlist
class added its columns.

In Qt 4 the polish method seems to have gone away, so we have to take different measures to
ensure that the HistoryPlaylist gets first dibs on making columns. We do this by altering
the ctor in Playlist to add placeholder columns for subclasses to control later.

This fixes a long-standing JuK bug (since KDE 4.0) that doesn't seem to actually have been
opened in b.k.o.

svn path=/trunk/KDE/kdemultimedia/juk/; revision=1136889

The major reason for this change is to allow for a saner destruct sequence
(instead of the unordered global static destruct sequence) which will hopefully
help reduce crash-on-shutdown bugs.

This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
bugs are found in it ;)

CCMAIL:nlecureuil@mandriva.com


svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429

svn path=/trunk/KDE/kdemultimedia/juk/; revision=910699

svn path=/trunk/KDE/kdemultimedia/juk/; revision=910695

svn path=/trunk/KDE/kdemultimedia/juk/; revision=882934

While doing so I managed to remove the need to have extraneous template types to avoid
recursive includes so the code is a bit neater now as well.

One functionality change is that items belonging to files that don't exist anymore are not
created anymore.  Hopefully this will eliminate crashes on startup due to files in the collection
being deleted between JuK startups.

svn path=/trunk/KDE/kdemultimedia/juk/; revision=852974

svn path=/trunk/KDE/kdemultimedia/juk/; revision=758772

svn path=/trunk/KDE/kdemultimedia/juk/; revision=718742

Still a lot of Qt 3 code to go but at this point Q3ValueList, Q3Vector, Q3PtrDict and
Q3Dict should all be gone.

In addition many loops have been foreach()'ed, which really does make it more readable.

There is a crash fix as well, now the polish() function in Playlist has been replaced
with an initialization slot which is singleShot'ed since the timing of the polish event
is apparently different than it was in Qt 3, which was making new Playlists crash when
they were first shown.

Also I went through almost every header and pared it down to the minimum reasonably
achievable, which required some additional headers in a few .cpp files but overall
compilation time should be down and you won't have to rebuild all of JuK just because
a header file got touched.

I haven't seen any regressions yet but then again I still can't play music either.

svn path=/trunk/KDE/kdemultimedia/juk/; revision=667815

busy work but quite a few headers were missing necessary includes and were not caught
because the required includes had been processed beforehand by coincidence.

svn path=/trunk/KDE/kdemultimedia/juk/; revision=666183

svn path=/trunk/KDE/kdemultimedia/juk/; revision=652516

svn path=/trunk/KDE/kdemultimedia/juk/; revision=595556

update.

All source now has a vim modeline, and all files use the same modeline (described in HACKING).

This will make it easier for vim users to stay HACKING-compatible in JuK.

svn path=/trunk/KDE/kdemultimedia/juk/; revision=513935

svn path=/trunk/KDE/kdemultimedia/juk/; revision=455930

BUG:93259

svn path=/trunk/kdemultimedia/juk/; revision=390968

CCMAIL:67341-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=342367

is the currently *playing* playlist; we have this wonderful method around
to see if it's the one playing.  ;-)

This makes it such that if you have the history visible but are playing
another playlist that pushing forward will continue to add those items to
the history.

svn path=/trunk/kdemultimedia/juk/; revision=323715

playlist.

svn path=/trunk/kdemultimedia/juk/; revision=323209

history playlist work again.

svn path=/trunk/kdemultimedia/juk/; revision=322959

everything in the status widget when the track changes.

svn path=/trunk/kdemultimedia/juk/; revision=321986

svn path=/trunk/kdemultimedia/juk/; revision=317484

to the playlistinterface.h file that can be subclassed by things that want
to track playlist changes using the generic API.

This also allowed removing a fair bit of cruft that was being thrown around
by signals in the Playlist class hierarchy.

This should be split up into two types of updates -- one for track changes
and another for data changes, but it was convenient in the first go to
roll them into one.  Splitting them up should be pretty trivial.

svn path=/trunk/kdemultimedia/juk/; revision=317251

TODO for a while:

*) Ditch the PlaylistSplitter class mostly in favor of the PlaylistCollection
*) Move to a more linear class interaction path rather than having PlaylistSplitter
   as an ugly thing trying to mediate between a bunch of unrelated classes
*) Rely more heavily on the global action collection and try to instantiate actions
   in the classes that they're related to
*) Remove a few dozen dirty hacks
*) Got rid of about 250 lines of code in the process

There are still a couple of outstanding issues but since my home internet connection
has decided that it doesn't like me at the moment and people are waiting on these
changes for further work I'm committing.  Stuff that still needs to be done (I'll
likely finish this tonight and commit it at work tomorrow):

*) Create the Artist / Album / Genre playlists in the Tree View Mode.  This is
   essentially easy, it just requires sticking a new constructor in and making sure
   that it works.
*) Make it so that the HistoryPlaylist is properly instantiated and shown when its
   asked for
*) Make sure that the status bar is updated with the current playlist information
*) Create dynamic playlists on multiple select

While that sounds like quite a bit that's really just a little bit of work, but
managing such a huge patch set off-line is getting rather tedious and most stuff
works now.  I should have a patch for the rest tomorrow.

svn path=/trunk/kdemultimedia/juk/; revision=316735

CCMAIL:72909-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=303133

*) Removed an extra copy of the path in CollectionListItem
*) Avoid two calls to PlaylistItem::refresh() on creating CollectionListItems
*) Moved resolveSymLinks() from being a static public of Playlist to being
   a helper function in FileHandle.

svn path=/trunk/kdemultimedia/juk/; revision=303018

still a lot of damage control yet to be done, but this at least gets things
building and working after porting the PlaylistItem over.

svn path=/trunk/kdemultimedia/juk/; revision=293445

lots of tabs in them, but I'm slowly moving away from the TT style
indentation to all spaces

svn path=/trunk/kdemultimedia/juk/; revision=288233

CCMAIL:63531-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=265696

streaming operators for the new playlist type to save the date that the
items were played on and integrated this into the rewritten playlist
caching code.

So basically history works, including restoration.

CCMAIL:61294-done@bugs.kde.org

svn path=/trunk/kdemultimedia/juk/; revision=243375