1. 01 Mar, 2018 1 commit
  2. 21 Feb, 2018 2 commits
  3. 11 Feb, 2018 2 commits
  4. 10 Feb, 2018 5 commits
    • Michael Pyne's avatar
      Extract Playlist::SharedSettings into a separate file. · 90a6b862
      Michael Pyne authored
      This helps declutter playlist.cpp and even makes it seem a bit easier to
      read through, I think.
      
      I also tried to fix a couple of outstanding bugs along the way, for
      instance reordering columns should work now, although there's still a
      lot of improvements that need to be made here.
      90a6b862
    • Michael Pyne's avatar
      Stop playback before taking shutdown actions. · 18eed01d
      Michael Pyne authored
      This seems to prevent a gstreamer deadlock I sometimes get when trying
      to quit, though it's only a guess as to whether this is the cause or
      not.
      18eed01d
    • Michael Pyne's avatar
      More column-handling bugfixes in Playlist. · 2ea8a84d
      Michael Pyne authored
      - The showColumn/hideColumn functions work on visual indices, not
      logical indices, so converting a visual index to a logical one is both
      wrong and extra work.
      - The "Show Columns" menu was just flatly checking every column, even
      the ones that weren't shown.
      2ea8a84d
    • Kacper Kasper's avatar
      Fix columns sorting. · cd8e9200
      Kacper Kasper authored
      Summary:
      QTreeWidgetItem in Qt5 requires overloading < operator to implement
      custom sorting. Use existing compare methods to do that.
      
      Additionally, natural sorting was implemented for strings.
      This allows to sort by filenames like file_<number>.
      
      BUG:389130
      
      Test Plan:
      Click on columns to sort them.
      Columns are sorted by artist, album and track number.
      
      Reviewers: mpyne
      
      Differential Revision: https://phabricator.kde.org/D10130
      cd8e9200
    • Michael Pyne's avatar
      Avoid crash on tree view mode by disabling tree view mode :( · 5982cede
      Michael Pyne authored
      I can't decipher the brokenness here in a way that will lead to a quick
      fix, so disable the broken feature for now to avoid causing needless
      crashes for a feature that currently doesn't work at all.
      
      BUG:389937
      FIXED-IN:17.12.3
      5982cede
  5. 02 Feb, 2018 1 commit
  6. 19 Jan, 2018 1 commit
    • Michael Pyne's avatar
      Immediately update dynamic/search playlist items upon a change. · e8c2dbbf
      Michael Pyne authored
      This is as opposed to recording the new list of PlaylistItems and then
      effecting the change after draining the event loop (an attempt at
      keeping GUI responsive if many updates are happening).
      
      Otherwise it is possible to
      - Generate a list of PlaylistItems to read from (when updating the
      playlist) and push to end of event loop
      - Delete some of those PlaylistItems due to already-queued events to
      delete playlist items
      - Finally try to use the list of PlaylistItems and run into a segfault
      from trying to access a deleted PlaylistItem.
      
      I think this should fix a crash when you delete multiple playlists.
      
      BUG:389176
      FIXED-IN:17.12.2
      e8c2dbbf
  7. 04 Jan, 2018 1 commit
  8. 11 Dec, 2017 1 commit
  9. 04 Dec, 2017 1 commit
  10. 02 Dec, 2017 1 commit
    • Michael Pyne's avatar
      Fix build when tunepimp is available. · 741957e0
      Michael Pyne authored
      The port to KF5 didn't encompass tunepimp, which was outdated even in
      KDE4 times.  This is just a simple build fix since we're in middle of
      release tagging, but in the future we will also need to audit the dead
      code that's not likely to be replaced by musicbrainz's current
      recommendations for client libs.
      741957e0
  11. 30 Nov, 2017 1 commit
  12. 13 Nov, 2017 1 commit
  13. 09 Nov, 2017 1 commit
  14. 02 Nov, 2017 1 commit
  15. 20 Oct, 2017 2 commits
  16. 15 Oct, 2017 1 commit
  17. 12 Oct, 2017 1 commit
    • Michael Pyne's avatar
      systemtray: Fix crash with scroll-to-next. · ee358b1b
      Michael Pyne authored
      And crashes involving other action invocations.  We need to guard
      against KSNI::action everywhere action() is called, not just in the
      ctor.  A good Junior Job might be going through and renaming the
      JuK-specific ActionCollection and action() functions to something a
      little less likely to conflict with KDE or Qt namespace.
      ee358b1b
  18. 07 Oct, 2017 7 commits
  19. 06 Oct, 2017 1 commit
  20. 04 Oct, 2017 2 commits
  21. 03 Oct, 2017 1 commit
  22. 02 Oct, 2017 5 commits