1. 07 Jul, 2018 1 commit
  2. 05 Jul, 2018 1 commit
  3. 01 Jun, 2018 1 commit
  4. 02 May, 2018 1 commit
  5. 25 Apr, 2018 1 commit
  6. 09 Apr, 2018 1 commit
  7. 02 Apr, 2018 1 commit
  8. 25 Mar, 2018 3 commits
    • Michael Pyne's avatar
      systray: Ensure quit from systray also saves config changes. · 30cd501f
      Michael Pyne authored
      KStatusNotifierItem's 'maybeQuit' function is more than happy to call
      qApp->quit directly even though the standard quit action is available to
      be triggered and would do the right thing.
      
      Qt documents you can use aboutToQuit to catch this case, and it does
      seem to work.
      30cd501f
    • Michael Pyne's avatar
      Simplify shutdown handling. · a951caf3
      Michael Pyne authored
      JuK would fail to shutdown properly under Plasma 5 when the system tray
      was disabled and you used the 'X' from the window manager title bar to
      try to close JuK.  May have failed under other WMs or desktops as well,
      I haven't tested that.
      
      The shutdown code hasn't been reworked since KDE 3 times and for all I
      know I introduced this bug with the setQuitOnLastWindowClosed setting in
      main.cpp years ago and never realized.
      
      But this way, any way you destroy the main application class (JuK), you
      end up shutting down.  Continuing to use setQuitOnLastWindowClosed
      appears to be necessary since Qt will remove the queued quit signal to
      qApp once JuK is destructed and I don't trust running qApp->quit within
      the JuK dtor itself.
      
      Hopefully this fixes a crash-on-quit bug, but if not just reopen and
      I'll figure it out somehow...
      
      FIXED-IN:18.04
      BUG:388663
      a951caf3
    • Michael Pyne's avatar
      Don't try to start in docked mode without the systray. · 1eed4730
      Michael Pyne authored
      It appears to be possible to configure JuK to start in docked mode even
      if the system tray icon has been disabled by the user, which is quite
      pointless.  Prevent this by forcing the window to be shown at startup if
      the system tray icon is not turned on.
      1eed4730
  9. 19 Mar, 2018 2 commits
  10. 17 Mar, 2018 1 commit
  11. 13 Mar, 2018 1 commit
  12. 06 Mar, 2018 2 commits
    • Luca Beltrame's avatar
      Fix build with Qt 5.11 · 2e2c31c3
      Luca Beltrame authored
      2e2c31c3
    • Michael Pyne's avatar
      mpris: Don't toggle playback with "Pause". · 57457aee
      Michael Pyne authored
      We already have a separate playPause action for this, both in the MPRIS2
      DBus adaptor, and in PlayerManager.
      
      This also fixes playback resuming when the computer is suspended (Plasma
      sends the "Pause" command to each media player regardless of whether
      it's playing, and JuK incorrectly treats that as a request to toggle
      playback).
      
      BUG:381271
      FIXED-IN:18.04
      57457aee
  13. 04 Mar, 2018 1 commit
    • Michael Pyne's avatar
      Remove ancient Exec= key from .desktop file. · 21264845
      Michael Pyne authored
      Should allow JuK to start on Wayland.  Should also allow arguments to be
      passed to JuK (which in theory supports loading files from command
      line).
      
      I ask for URLs to be passed (%U) instead of files (%F) to avoid
      over-eager file managers or desktops trying to download music files to a
      temp directory and then deleting them once JuK is done.
      
      GUI:
      BUG:391354
      FIXED-IN:18.04
      21264845
  14. 03 Mar, 2018 1 commit
  15. 21 Feb, 2018 2 commits
  16. 13 Feb, 2018 2 commits
  17. 11 Feb, 2018 1 commit
  18. 10 Feb, 2018 5 commits
    • Michael Pyne's avatar
      Extract Playlist::SharedSettings into a separate file. · 90a6b862
      Michael Pyne authored
      This helps declutter playlist.cpp and even makes it seem a bit easier to
      read through, I think.
      
      I also tried to fix a couple of outstanding bugs along the way, for
      instance reordering columns should work now, although there's still a
      lot of improvements that need to be made here.
      90a6b862
    • Michael Pyne's avatar
      Stop playback before taking shutdown actions. · 18eed01d
      Michael Pyne authored
      This seems to prevent a gstreamer deadlock I sometimes get when trying
      to quit, though it's only a guess as to whether this is the cause or
      not.
      18eed01d
    • Michael Pyne's avatar
      More column-handling bugfixes in Playlist. · 2ea8a84d
      Michael Pyne authored
      - The showColumn/hideColumn functions work on visual indices, not
      logical indices, so converting a visual index to a logical one is both
      wrong and extra work.
      - The "Show Columns" menu was just flatly checking every column, even
      the ones that weren't shown.
      2ea8a84d
    • Kacper Kasper's avatar
      Fix columns sorting. · cd8e9200
      Kacper Kasper authored
      Summary:
      QTreeWidgetItem in Qt5 requires overloading < operator to implement
      custom sorting. Use existing compare methods to do that.
      
      Additionally, natural sorting was implemented for strings.
      This allows to sort by filenames like file_<number>.
      
      BUG:389130
      
      Test Plan:
      Click on columns to sort them.
      Columns are sorted by artist, album and track number.
      
      Reviewers: mpyne
      
      Differential Revision: https://phabricator.kde.org/D10130
      cd8e9200
    • Michael Pyne's avatar
      Avoid crash on tree view mode by disabling tree view mode :( · 5982cede
      Michael Pyne authored
      I can't decipher the brokenness here in a way that will lead to a quick
      fix, so disable the broken feature for now to avoid causing needless
      crashes for a feature that currently doesn't work at all.
      
      BUG:389937
      FIXED-IN:17.12.3
      5982cede
  19. 03 Feb, 2018 2 commits
    • Michael Pyne's avatar
      GIT_SILENT modernize some comments. · a5dcba16
      Michael Pyne authored
      a5dcba16
    • Michael Pyne's avatar
      Bring back a visual indication of the playing item. · 0dd849ec
      Michael Pyne authored
      Turned out to be surprisingly more difficult than I thought, so
      hopefully no additional bugs.
      
      In particular some Phonon backends seem to insert a trip to a
      StoppedState when changing the MediaObject's current source, so I had to
      find a way around that to be able to call Playlist::stop() from
      PlaylistCollection (which is what actually clears the visual indication
      when playback stops).
      0dd849ec
  20. 02 Feb, 2018 2 commits
  21. 01 Feb, 2018 5 commits
  22. 31 Jan, 2018 3 commits