1. 11 Nov, 2018 1 commit
    • Michael Pyne's avatar
      Enable Qt support for High DPI icons. · 0ad0ee58
      Michael Pyne authored
      As submitted by Guo Yunhe <i@guoyunhe.me> on kde-multimedia.
      
      In my testing this only applies with QT_AUTO_SCREEN_SCALE_FACTOR
      environment variable enabled, but does indeed allow for many (not all)
      pixmaps to automatically load high-res versions (such as from
      KIconLoader).
      
      I consider this a bugfix and the support is non-invasive, so applying to
      18.12 and will merge to master separately.
      
      Note that the cover art and slider art is still suboptimal.
      0ad0ee58
  2. 23 Sep, 2018 1 commit
  3. 19 Jun, 2018 1 commit
  4. 25 Mar, 2018 2 commits
    • Michael Pyne's avatar
      Simplify shutdown handling. · a951caf3
      Michael Pyne authored
      JuK would fail to shutdown properly under Plasma 5 when the system tray
      was disabled and you used the 'X' from the window manager title bar to
      try to close JuK.  May have failed under other WMs or desktops as well,
      I haven't tested that.
      
      The shutdown code hasn't been reworked since KDE 3 times and for all I
      know I introduced this bug with the setQuitOnLastWindowClosed setting in
      main.cpp years ago and never realized.
      
      But this way, any way you destroy the main application class (JuK), you
      end up shutting down.  Continuing to use setQuitOnLastWindowClosed
      appears to be necessary since Qt will remove the queued quit signal to
      qApp once JuK is destructed and I don't trust running qApp->quit within
      the JuK dtor itself.
      
      Hopefully this fixes a crash-on-quit bug, but if not just reopen and
      I'll figure it out somehow...
      
      FIXED-IN:18.04
      BUG:388663
      a951caf3
    • Michael Pyne's avatar
      Don't try to start in docked mode without the systray. · 1eed4730
      Michael Pyne authored
      It appears to be possible to configure JuK to start in docked mode even
      if the system tray icon has been disabled by the user, which is quite
      pointless.  Prevent this by forcing the window to be shown at startup if
      the system tray icon is not turned on.
      1eed4730
  5. 01 Oct, 2017 4 commits
  6. 26 Aug, 2017 1 commit
  7. 25 Aug, 2017 1 commit
    • Luigi Toscano's avatar
      Port away from KCmdLineArgs · 67ffed2e
      Luigi Toscano authored
      - reenable the command line parsing;
      - pass the parsed arguments to the "JuK" instance, as they are
        needed later;
      - use the global KAboutData information instead of accessing
        it through KCmdLineArgs.
      67ffed2e
  8. 27 Jul, 2017 1 commit
  9. 26 Jul, 2017 2 commits
  10. 11 Jul, 2016 1 commit
  11. 26 Apr, 2016 1 commit
  12. 24 Apr, 2016 1 commit
    • Michael Pyne's avatar
      Allow 'default playlists' to have duplicate entries. · cb42ead6
      Michael Pyne authored
      This is still disabled in search playlists, folder-based playlists, and
      the collection list (where the concept doesn't make sense), but at
      least you can add items over and over to the normal playlists.
      
      FIXED-IN:16.08
      cb42ead6
  13. 10 Oct, 2014 2 commits
  14. 30 Nov, 2013 1 commit
    • Michael Pyne's avatar
      GIT_SILENT: Update source code license headers. · d969a0b4
      Michael Pyne authored
      Thanks to Eric Newberry (from Google Code-In) for running the heavy
      lifting on this.
      
      I made some other corrections since we're touching all the source
      anyways (e.g. fixing my email addresses), fixing the encoding of Richard
      Lärkäng's name, and I've also chosen to avoid the fancy box-shaped
      comments so that there's no issue with trailing spaces/tabs.
      
      REVIEW:114216
      d969a0b4
  15. 11 Nov, 2013 1 commit
  16. 06 Oct, 2013 1 commit
    • Shubham Chaudhary's avatar
      Notify the user that JuK is docked on startup. · 61e5fc8d
      Shubham Chaudhary authored
      We show a simple notification if the user starts up JuK and it is set to
      dock in the systray on startup (as otherwise the user may wonder why it
      didn't open up). Although a "Do not show again" checkbox is not possible
      with KNotification, it is possible to remove this additional
      notification by going to "Application and System Notifications" in
      System Settings to manage "Juk music player" application notifications.
      
      We do *not* show a notification if a session is being restored to avoid
      noise, however JuK will show the main window if the user tries to start
      it up again after it's already running, so this should be OK.
      
      Thanks to Shubham Chaudhary for the bugfix (you're been marked as the
      patch author), and Michael for reporting the bug.
      
      This bugfix adds new strings so it cannot be backported. It will show up
      first in KDE SC 4.12.
      
      BUG:316832
      FIXED-IN:4.12
      GUI:
      61e5fc8d
  17. 03 Sep, 2013 2 commits
  18. 09 Mar, 2013 1 commit
  19. 06 Jan, 2013 1 commit
  20. 22 Sep, 2012 1 commit
    • Michael Pyne's avatar
      Bump version for 4.10, update about strings. · 03b9578a
      Michael Pyne authored
      This is mostly work done by Markus Meik Slopianka to improve the About
      dialog strings (e.g. a jukebox "for KDE" made more sense when KDE meant
      only the desktop release). I've taken the liberty of also bumping the
      version so I don't forget before 4.10.
      
      REVIEW:105902
      03b9578a
  21. 19 Apr, 2012 1 commit
  22. 23 Feb, 2012 1 commit
  23. 26 Jan, 2012 1 commit
  24. 15 May, 2011 1 commit
  25. 05 May, 2011 1 commit
    • Michael Pyne's avatar
      Use standard KMainWindow restore procedure. · e1a55177
      Michael Pyne authored
      This seems to fix the issue for me where sometimes JuK will start up with a
      wildly mis-sized playlist box. I do not consider this safe enough to
      backport however.
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1230442
      e1a55177
  26. 26 Apr, 2011 1 commit
  27. 20 Apr, 2011 1 commit
    • Michael Pyne's avatar
      Set directory mode for renamer's "music folder". · def93297
      Michael Pyne authored
      Γιώργος Κυλάφας submitted this patch for the JuK file renamer to use the proper
      "directory mode" of KFileDialog for the music folder selection in the File
      Renamer configuration.
      
      It's *much* appreciated -- this represents the first non-Michael Pyne
      contribution to JuK since about 8 months ago (and the one before that was 20
      months ago).
      
      I will backport to 4.6.3.
      
      CCMAIL:gekylafas@gmail.com
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1228551
      def93297
  28. 24 Jul, 2010 1 commit
    • Michael Pyne's avatar
      Fix bug 230041 (JuK system tray tooltip clips letters in words instead of at spaces) in · 6d3c7e57
      Michael Pyne authored
      trunk by applying two patches provided by Glad Deschrijver.
      
      The first removes an old hack that had been keeping lines from being broken that doesn't
      work with the new DBus-based system tray.
      
      The second patch uses italics on the song title to get the intended effect of the first,
      an easy visual distinction between song artist and title. This one could be bad depending
      on the font, but there are plenty of high-quality free fonts available, and we can't even
      blame the Apple font hinting patent now.
      
      Will backport to 4.5 as the fix is completely non-invasive and corrects an annoying visual
      flaw in the UI experience.
      
      CCBUG:230041
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1153775
      6d3c7e57
  29. 10 May, 2010 1 commit
  30. 13 Feb, 2010 1 commit
    • Michael Pyne's avatar
      Hopefully fix bug 226587 (juk produces a crash on exit if not in dock-in-systray mode). · d9d2dd95
      Michael Pyne authored
      Valgrind gave me the hint that the address in question was on the stack, and changing
      the main window to be on the heap instead seemed to work just fine.
      
      Probably I missed or forgot some elementary rule of Qt programming or something, but
      seems to work now. Will backport to 4.4.1
      
      CCBUG:226587
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1089770
      d9d2dd95
  31. 11 Jan, 2010 1 commit
  32. 26 Nov, 2009 1 commit
    • Michael Pyne's avatar
      Decouple PlayerManager from JuK so that it isn't a singleton. · c0204770
      Michael Pyne authored
      The major reason for this change is to allow for a saner destruct sequence
      (instead of the unordered global static destruct sequence) which will hopefully
      help reduce crash-on-shutdown bugs.
      
      This will not be in the upcoming KDE 4.4 beta but will be in the 4.4 release (assuming no
      bugs are found in it ;)
      
      CCMAIL:nlecureuil@mandriva.com
      
      
      svn path=/trunk/KDE/kdemultimedia/juk/; revision=1054429
      c0204770
  33. 03 Aug, 2009 1 commit