Commit 8ec84346 authored by Yuri Chornoivan's avatar Yuri Chornoivan
Browse files

Fix minor EBN issues

parent 1eb3bd01
......@@ -32,7 +32,7 @@ class PhonemeGroup;
class LanguageStub : public ILanguage
{
public:
LanguageStub(QString id)
explicit LanguageStub(QString id)
: m_id(id)
{
}
......
......@@ -36,14 +36,14 @@ class ResourceRepositoryStub : public IResourceRepository
{
Q_OBJECT
public:
ResourceRepositoryStub(std::vector<std::unique_ptr<ILanguage>> languages)
explicit ResourceRepositoryStub(std::vector<std::unique_ptr<ILanguage>> languages)
{
for (auto &language : languages) {
m_languages.append(std::move(language));
}
}
ResourceRepositoryStub(std::vector<std::shared_ptr<ILanguage>> languages)
explicit ResourceRepositoryStub(std::vector<std::shared_ptr<ILanguage>> languages)
{
for (auto &language : languages) {
m_languages.append(language);
......
......@@ -184,7 +184,7 @@ Learner *ProfileManager::addProfile(const QString &name)
setActiveProfile(learner);
}
connect(learner, SIGNAL(goalRemoved(Learner *, LearningGoal *)), this, SLOT(removeLearningGoal(Learner *, LearningGoal *)));
connect(learner, &Learner::goalRemoved, this, &ProfileManager::removeLearningGoal);
return learner;
}
......
......@@ -34,7 +34,7 @@ class ARTIKULATECORE_EXPORT DrawerTrainingActions : public QObject
Q_PROPERTY(QList<QObject *> actions READ actions NOTIFY actionsChanged)
public:
DrawerTrainingActions(QObject *parent = nullptr);
explicit DrawerTrainingActions(QObject *parent = nullptr);
void setSession(ISessionActions *session);
ISessionActions *session() const;
QList<QObject *> actions() const;
......
......@@ -39,7 +39,7 @@ class ARTIKULATECORE_EXPORT ISessionActions : public QObject
{
Q_OBJECT
public:
ISessionActions(QObject *parent)
explicit ISessionActions(QObject *parent)
: QObject(parent)
{
}
......
......@@ -48,8 +48,8 @@ class ARTIKULATECORE_EXPORT TrainingAction : public QAbstractListModel
public:
enum ModelRoles { ModelDataRole = Qt::UserRole + 1 };
TrainingAction(QObject *parent = nullptr);
TrainingAction(const QString &text, QObject *parent = nullptr);
explicit TrainingAction(QObject *parent = nullptr);
explicit TrainingAction(const QString &text, QObject *parent = nullptr);
TrainingAction(std::shared_ptr<IPhrase> phrase, ISessionActions *session, QObject *parent = nullptr);
Q_INVOKABLE void trigger();
bool enabled() const;
......
......@@ -36,7 +36,7 @@ public:
/**
* Default Constructor
*/
MainWindowEditor(ContributorRepository *repository);
explicit MainWindowEditor(ContributorRepository *repository);
/**
* Default Destructor
......
......@@ -37,7 +37,7 @@ public:
enum courseRoles { TitleRole = Qt::UserRole + 1, I18nTitleRole, DescriptionRole, IdRole, LanguageRole, DataRole };
explicit CourseModel(QObject *parent = nullptr);
CourseModel(IResourceRepository *repository, QObject *parent = nullptr);
explicit CourseModel(IResourceRepository *repository, QObject *parent = nullptr);
~CourseModel() override = default;
QHash<int, QByteArray> roleNames() const override;
IResourceRepository *resourceRepository() const;
......
......@@ -37,7 +37,7 @@ public:
enum skeletonRoles { TitleRole = Qt::UserRole + 1, DescriptionRole, IdRole, DataRole };
explicit SkeletonModel(QObject *parent = nullptr);
SkeletonModel(IEditableRepository *repository, QObject *parent = nullptr);
explicit SkeletonModel(IEditableRepository *repository, QObject *parent = nullptr);
~SkeletonModel() override = default;
QHash<int, QByteArray> roleNames() const override;
IEditableRepository *resourceRepository() const;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment