Commit 3d4e6230 authored by Yuri Chornoivan's avatar Yuri Chornoivan
Browse files

Fix minor EBN issues

parent 3df804c9
......@@ -33,7 +33,7 @@ class ActionBar : public QGraphicsObject
{
Q_OBJECT
public:
ActionBar(WorksheetEntry* parent);
explicit ActionBar(WorksheetEntry* parent);
~ActionBar() override = default;
WorksheetToolButton* addButton(const QIcon& icon, const QString& toolTip,
......
......@@ -33,7 +33,7 @@ class Animation : public QObject
{
Q_OBJECT
public:
Animation( QObject* parent=nullptr);
explicit Animation( QObject* parent=nullptr);
~Animation() override;
void setMovie(QMovie* movie);
......
......@@ -32,7 +32,7 @@ class AnimationResultItem : public WorksheetImageItem, public ResultItem
Q_OBJECT
public:
AnimationResultItem(QGraphicsObject* parent);
explicit AnimationResultItem(QGraphicsObject* parent);
~AnimationResultItem() override = default;
using WorksheetImageItem::setGeometry;
......
......@@ -28,7 +28,7 @@ class CreateMatrixDlg : public QDialog
{
Q_OBJECT
public:
CreateMatrixDlg( QWidget* parent);
explicit CreateMatrixDlg( QWidget* parent);
~CreateMatrixDlg() override;
int numRows();
......
......@@ -29,7 +29,7 @@ class BackendChooseDialog : public QDialog
{
Q_OBJECT
public:
BackendChooseDialog( QWidget* parent);
explicit BackendChooseDialog( QWidget* parent);
~BackendChooseDialog() override = default;
QString backendName();
......
......@@ -28,7 +28,7 @@ class RExpression : public Cantor::Expression
Q_OBJECT
public:
enum ServerReturnCode{SuccessCode=0, ErrorCode, InterruptedCode};
RExpression( Cantor::Session*, bool internal = false);
explicit RExpression( Cantor::Session*, bool internal = false);
~RExpression() override = default;
void evaluate() override;
......
......@@ -27,7 +27,7 @@
class RScriptExtension : public Cantor::ScriptExtension
{
public:
RScriptExtension(QObject* parent);
explicit RScriptExtension(QObject* parent);
~RScriptExtension() override = default;
public Q_SLOTS:
QString runExternalScript(const QString& path) override;
......@@ -41,7 +41,7 @@ class RPlotExtension : public Cantor::AdvancedPlotExtension,
public Cantor::AdvancedPlotExtension::DirectiveAcceptor<Cantor::AbscissScaleDirective>
{
public:
RPlotExtension(QObject* parent);
explicit RPlotExtension(QObject* parent);
~RPlotExtension() override = default;
QString accept(const Cantor::PlotTitleDirective&) const override;
QString accept(const Cantor::OrdinateScaleDirective&) const override;
......@@ -54,7 +54,7 @@ class RPlotExtension : public Cantor::AdvancedPlotExtension,
class RVariableManagementExtension : public Cantor::VariableManagementExtension
{
public:
RVariableManagementExtension(QObject* parent);
explicit RVariableManagementExtension(QObject* parent);
~RVariableManagementExtension() override = default;
QString addVariable(const QString& name, const QString& value) override;
QString setValue(const QString& name, const QString& value) override;
......
......@@ -28,7 +28,7 @@ class RHighlighter : public Cantor::DefaultHighlighter
Q_OBJECT
public:
RHighlighter( QObject* parent);
explicit RHighlighter( QObject* parent);
~RHighlighter() override = default;
protected:
......
......@@ -38,7 +38,7 @@ class RSession : public Cantor::Session
{
Q_OBJECT
public:
RSession( Cantor::Backend* backend);
explicit RSession( Cantor::Backend* backend);
~RSession() override;
void login() override;
......
......@@ -28,7 +28,7 @@ class RSettingsWidget : public QWidget,public Ui::RSettingsBase
Q_OBJECT
public:
RSettingsWidget(QWidget *parent = nullptr);
explicit RSettingsWidget(QWidget *parent = nullptr);
bool eventFilter(QObject*, QEvent*) override;
public Q_SLOTS:
......
......@@ -3,8 +3,8 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
<kcfgfile name="cantorrc"/>
<include>QStandardPaths</include>
<kcfgfile name="cantorrc"/>
<group name="JuliaBackend">
<entry name="replPath" type="Url">
<label>Path to the Julia native REPL</label>
......
......@@ -34,7 +34,7 @@ public:
* @param session session to bound expression to
* @param internal @see Cantor::Expression::Expression(Session*, bool)
*/
JuliaExpression(Cantor::Session *session, bool internal = false);
explicit JuliaExpression(Cantor::Session *session, bool internal = false);
~JuliaExpression() override = default;
/**
......
......@@ -38,7 +38,7 @@ public:
*
* @param parent QObject parent
*/
JuliaHighlighter(QObject *parent);
explicit JuliaHighlighter(QObject *parent);
~JuliaHighlighter() override = default;
public Q_SLOTS:
......
......@@ -37,7 +37,7 @@ class JuliaServer: public QObject
{
Q_OBJECT
public:
JuliaServer(QObject *parent = nullptr);
explicit JuliaServer(QObject *parent = nullptr);
~JuliaServer() override;
......@@ -84,7 +84,7 @@ public Q_SLOTS:
Q_SCRIPTABLE QStringList variablesList();
/**
* @return corresponding list of values for variables from variablesList.
* @return corresponding list of values for variables from variablesList.
*/
Q_SCRIPTABLE QStringList variableValuesList();
......
......@@ -46,7 +46,7 @@ public:
*
* @param backend owning backend
*/
JuliaSession(Cantor::Backend *backend);
explicit JuliaSession(Cantor::Backend *backend);
/**
* @see Cantor::Session::login
......
......@@ -27,7 +27,7 @@ class KAlgebraExpression : public Cantor::Expression
{
Q_OBJECT
public:
KAlgebraExpression( KAlgebraSession* session, bool internal = false);
explicit KAlgebraExpression( KAlgebraSession* session, bool internal = false);
~KAlgebraExpression() override = default;
void evaluate() override;
......
......@@ -26,7 +26,7 @@
class KAlgebraVariableManagementExtension : public Cantor::VariableManagementExtension
{
public:
KAlgebraVariableManagementExtension( QObject* parent );
explicit KAlgebraVariableManagementExtension( QObject* parent );
~KAlgebraVariableManagementExtension() override = default;
public Q_SLOTS:
......
......@@ -33,7 +33,7 @@ class KAlgebraSession : public Cantor::Session
{
Q_OBJECT
public:
KAlgebraSession( Cantor::Backend* backend);
explicit KAlgebraSession( Cantor::Backend* backend);
~KAlgebraSession() override;
void login() override;
......
......@@ -3,8 +3,8 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
<kcfgfile name="cantorrc"/>
<include>QStandardPaths</include>
<kcfgfile name="cantorrc"/>
<group name="LuaBackend">
<entry name="Path" type="Url">
<label>Path to luajit command</label>
......
......@@ -30,7 +30,7 @@ class LuaExpression : public Cantor::Expression
Q_OBJECT
public:
LuaExpression( Cantor::Session* session, bool internal = false);
explicit LuaExpression( Cantor::Session* session, bool internal = false);
~LuaExpression() override = default;
void evaluate() override;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment