Skip to content

GitLab

Kalzium
Kalzium
Switch branch/tag
  1. 21 Feb, 2015 1 commit
  3. 23 Jan, 2015 1 commit
  5. 12 Jan, 2015 1 commit
  7. 02 Jan, 2015 3 commits
  9. 28 Nov, 2014 1 commit
  11. 10 Nov, 2014 1 commit
  13. 31 Oct, 2014 1 commit
  15. 30 Oct, 2014 1 commit
  17. 29 Oct, 2014 1 commit
  19. 26 Oct, 2014 2 commits
  21. 17 Sep, 2014 1 commit
    • Martin Walch's avatar
      reformat whole code base of Kalzium · 7adfaccb
      Martin Walch authored 
      Across the project there are many coding styles with lots of different
indentation patterns. There are three different tabs to space
conversions (1:2, 1:4, 1:8), even mixed within individual files. This
makes the code unnecessarily hard to read and to edit.

In the hope that I do not offend anybody: unify code style.

Roughly apply the style from kdelibs:

* get rid of all tabs
* indentation is four spaces
* unify includes and include guards
* less blank lines
* one space after "if", "for", etc.
* no space after cast
* prefix operators ("++", "--") instead of postfix where applicable
* pointers: preferably single space before "\*" (same for "&")
* opening curly braces on same line except for implementations
* no whitespace after opening parenthesis "(" or before closing ones ")"
* no single line "if", "for", "else", etc. (always curly braces)
* indent "case" to same level as corresponding "switch"
* at least in some files adjust line wraps to a limit of 100 chars
* exactly one newline at EOF

Also some formatting to copyright statements (I hope this is legally ok)

Additionally:
* fix some spelling errors
* constify& some foreach loops (suggested by krazy2)
* replace some single char strings with chars (suggested by krazy2)

This whole patch fixes between 15 and 20 krazy2 warnings.

REVIEW: 120238
      7adfaccb
  23. 15 Sep, 2014 2 commits
    • Martin Walch's avatar
      Fix bug #338666: "Kalzium crashes when selecting >File >Export Data..." · 7c590a04
      Martin Walch authored 
      Problem is easy to spot with valgrind:
The private ExportDialog *m_exportDialog is not explicitely initialized
with 0, so later calling "if (!m_exportDialog)" may fail.

This accidentally slipped in with a header cleanup (commit d36687d5...)

Easy fix: initialize the pointer with 0 just like all the others.

REVIEW: 120219
      7c590a04
    • Martin Walch's avatar
      Fix bug #338666: "Kalzium crashes when selecting >File >Export Data..." · 287791bb
      Martin Walch authored 
      Problem is easy to spot with valgrind:
The private ExportDialog *m_exportDialog is not explicitely initialized
with 0, so later calling "if (!m_exportDialog)" may fail.

This accidentally slipped in with a header cleanup (commit d36687d5...)

Easy fix: initialize the pointer with 0 just like all the others.

BUG: 338666
FIXED-IN: 4.14.2
      287791bb
  25. 04 Aug, 2014 2 commits
  27. 31 Jul, 2014 4 commits
  29. 25 Jul, 2014 2 commits
  31. 24 Jul, 2014 2 commits
  33. 21 Jul, 2014 1 commit
  35. 20 Jul, 2014 1 commit
  37. 16 Jul, 2014 1 commit
  39. 07 Jul, 2014 1 commit
  41. 05 Jul, 2014 1 commit
  43. 30 Jun, 2014 1 commit
  45. 28 Jun, 2014 1 commit
  47. 24 Jun, 2014 1 commit
  49. 23 Jun, 2014 1 commit
  51. 21 Jun, 2014 1 commit
  53. 19 Jun, 2014 1 commit
  55. 15 Jun, 2014 1 commit
  57. 25 May, 2014 1 commit
  59. 28 Apr, 2014 1 commit