GitLab

This way they're more correct, which means they can work with KHelpCenter
and when falling back to opening the relevant page at docs.kde.org in any
web browser.

See graphics/okular!441 for more
details.

(cherry picked from commit b6194157)

(cherry picked from commit 18b9e0f8)

(cherry picked from commit 75e1911c)

(cherry picked from commit d8805c21)

This silences Clang's `-Wunused-const-variable` warning messages.

The documentation for QAbstractItemModel states:

    When implementing a table based model, rowCount()/columnCount()
    should return 0 when the parent is valid.

This argument is only useful for knowing the old size, which we really
don't care about.

There is only one instance of ResultsView ever created, with a second
one in a TODO comment, so it's fair to assume the `name` argument would
have been meant to tell them apart.

(Note that the body of ResultsView::print() is simply one big comment.)

BUG: 431866

For the radical sort order to be changeable at runtime, the button grid
must be made rebuildable.

RadicalButton::setStatus() no longer has any reason to call setFont(),
so it can simply inherit its font from its ButtonGrid parent, which can
also stop overriding its own setFont() and let Qt do the dirty work.

Right-clicking on a selected radical button would set its (visual)
status to Related, and thus no longer Selected, even though the
underlying radical remained selected.  Furthermore, right-clicking on it
again would have no effect; there was no way to remove the Related
status of a single button, except by left-clicking on it to toggle its
selected status.

From the comment left in ButtonGrid::radicalClicked(), the original
author seemed to have some idea in mind, but left it unimplemented.
Right-clicking therefore does nothing, except confuse the user, so let's
just disable it.

(I'm not ripping the whole thing out just yet, in case someone else want
to do something with it.)

A KStatusNotifierItem's status is Passive by default, meaning:

    Nothing is happening in the application, so showing this icon is not
    required.

The application is expected to set it to Active at some point:

    The application is doing something, or it is important that the icon
    is always reachable from the user.

Although we never really "do something", the second half about needing
the icon to be reachable corresponds to our situation.

BUG: 132476

(cherry picked from commit fa7f7db8)

Remove the operator< and add an explicit compareIndices function that
makes it clear what we're sorting by

Make Radical have a QString instead be a QString so that operator < from
QString doesn't break the explicitless of compareIndices we just
introduced

This is simpler, and brings ConfigDictionarySelector::updateWidgets()
more or less in line with Kiten::loadDictConfig().

Creating a config item at runtime for each dictionary is not only
needlessly complex, but also deceiving; config items usually act as a
convenient shortcut (thanks to their unique name that doesn't require
messing around with groups), but the items added here are only available
to others *if* the configure dialog has been displayed beforehand.

BUG: 418108

The previous copy of radkfile was the one that shipped with xjdic
version 23, way back in 1998.  This file has seen countless updates and
corrections since then (including no longer listing 二 as a 1-stroke
radical).

The version included here is dated from August 2020, fetched from
http://nihongo.monash.edu/kradinf.html.

Ever since the release of xjdic version 24 (back in 2003), some radkfile
entries have included an additional element (either in the form of a JIS
X 0212 hex code or an image filename), which must be excluded when
parsing the stroke count.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

(cherry picked from commit 1a40e2a1)

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

* Update date and version numbers
* Use more entities, suitable tags and punctuation