Commit ddb83b14 authored by Akarsh Simha's avatar Akarsh Simha
Browse files

A commit full of FIXMEs and hardly anything else

By the poetic tone of my commit messages, I presume it is quite clear
that I am very sleepy, which is why not a single of these FIXMEs have
been attended to today. Hopefully, some day...
parent 30862b94
......@@ -828,6 +828,11 @@ void CatalogDB::GetAllObjects(const QString &catalog,
RA = t.ra();
Dec = t.dec();
// FIXME: It is a bad idea to create objects in one class
// (using new) and delete them in another! The objects created
// here are usually deleted by CatalogComponent! See
// CatalogComponent::loadData for more information!
if (iType == 0) { // Add a star
StarObject *o = new StarObject(RA, Dec, mag, lname);
......@@ -235,6 +235,7 @@ void OpsCatalog::slotApply() {
// JM: Why are we calling this if no deep sky stuff was changed?
// AS: It's possible that custom catalogs have changed, which is probably why.
Options::setShowMessier( m_ShowMessier );
......@@ -55,6 +55,27 @@ CatalogComponent::CatalogComponent(SkyComposite *parent,
CatalogComponent::~CatalogComponent() {
// FIXME: Check this and implement it properly when you're not as
// desperate to sleep as I am right now. -- AS
auto removeFromContainer = []( auto &thingToRemove, auto &container ) {
container.remove( container.indexOf( thingToRemove ) );
foreach ( SkyObject *obj, m_ObjectList ) {
// FIXME: Should the name removal be done here!? What part of this giant edifice of code is supposed to take care of this? SkyMapComposite? -- AS
// FIXME: Removing from any of these containers is VERY SLOW (QList will be O(N) to find and O(1) to remove, whereas QVector will be O(N) to find and O(N) to remove...) -- AS
removeFromComtainer( objectNames( obj->type() ), obj->name() );
removeFromContainer( objectLists(obj->type()), QPair<QString, const SkyObject *>(obj->name(), obj) );
removeFromContainer( objectLists(obj->type()), QPair<QString, const SkyObject *>(obj->longname(), obj) );
delete obj;
void CatalogComponent::_loadData( bool includeCatalogDesignation ) {
......@@ -75,13 +96,30 @@ void CatalogComponent::_loadData( bool includeCatalogDesignation ) {
//FIXME JM 2016-06-02: inefficient and costly check
// Need better way around this
//if (!objectNames(
// AS: FIXME -- after Artem Fedoskin introduced the
// objectLists, which is definitely better, we should
// really work towards doing away with this.
// N.B. It might be better to use a std::multiset instead
// of QVector<QPair<>>, because it allows for inexpensive
// O(log N) lookups, but the filter and find will be very
// quick because of the binary search tree. HOWEVER, it
// will come at the cost of a lot of code complexity,
// since std:: containers may not work well out of the box
// with Qt's MVC system, so this would be desirable only
// if N (number of named objects in KStars) becomes very
// very large such that the filtering in Find Dialog takes
// too long. -- AS
//FIXME - get rid of objectNames completely. For now only KStars Lite uses objectLists
for(int iter = 0; iter < m_ObjectList.size(); ++iter) {
SkyObject *obj = m_ObjectList[iter];
Q_ASSERT( obj );
if(obj->type() <= SkyObject::TYPE_UNKNOWN) {
QVector<QPair<QString, const SkyObject *>>&objects = objectLists(obj->type());
bool dupName = false;
......@@ -91,6 +129,15 @@ void CatalogComponent::_loadData( bool includeCatalogDesignation ) {
QString longname = obj->longname();
//FIXME - find a better way to check for duplicates
// FIXME: AS: There is an argument for why we may not want
// to remove duplicates -- when the object is removed, all
// names seem to be removed, so if there are two objects
// in KStars with the same name in two different catalogs
// (e.g. Arp 148 from Arp catalog, and Arp 148 from some
// miscellaneous catalog), then disabling one catalog
// removes the name entirely from the list.
for(int i = 0; i < objects.size(); ++i) {
if(name ==
dupName = true;
......@@ -108,7 +155,7 @@ void CatalogComponent::_loadData( bool includeCatalogDesignation ) {
// Remove Duplicates
// Remove Duplicates (see FIXME by AS above)
foreach(QStringList list, objectNames())
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment