1. 30 Oct, 2016 1 commit
  2. 10 Feb, 2015 1 commit
  3. 04 Nov, 2014 1 commit
  4. 30 Dec, 2013 1 commit
  5. 18 Apr, 2011 1 commit
  6. 17 Oct, 2010 2 commits
    • Akarsh Simha's avatar
      Undo last commit, which was an incorrect merge. Still not completely · 434a98b0
      Akarsh Simha authored
      fixed.
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=1186602
      434a98b0
    • Akarsh Simha's avatar
      Merging Harry's OpenGL branch into trunk! · 61fc2b3a
      Akarsh Simha authored
      Yippeeeee! Now everyone can have the OpenGL'd KStars!
      
      I must congratulate Harry on writing such beautiful code. I really
      like the way this stuff works now.
      
      There are a whole bunch of *regressions* introduced by this, which
      Harry has summarized in an earlier e-mail to the mailing list, which I
      hope, can be fixed at least to some extent before release.
      
      The GL version is much more smoother and nice on my machine.
      
      Also, this has NOT been tested to compile! I'm going to test it
      immediately after this commit, because I found it convenient that
      way. Expect follow up commits to fix compile errors.
      
      CCMAIL: kstars-devel@kde.org
      
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=1186600
      61fc2b3a
  7. 29 Jul, 2009 2 commits
  8. 24 Jun, 2009 1 commit
    • Alexey Khudyakov's avatar
      Make function KSPlanetBase::findMagnitude virtual. · a8d00818
      Alexey Khudyakov authored
      It more robust and simple. Also it's more natural to keep
      code which calculate object magnitude in its class.
      
      KSPlanetBase::findMagnitude now pure virtual function 
      
      CCMAIL: kstars-devel@kde.org
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=986289
      a8d00818
  9. 11 Jun, 2009 1 commit
  10. 05 Jun, 2009 1 commit
  11. 03 Jun, 2009 1 commit
    • Alexey Khudyakov's avatar
      In this changeset clone function is implemented. It allows safe · cbb53a3a
      Alexey Khudyakov authored
      copying of objects. E.g. KSPlanet stored as SkyObject* pointer
      would be copied as KSPlanet and not sliced. 
      
      For all subclasses of SkyObject but DeepSkyObject copy
      constructors are removed. In most cases they are pretty useless
      and could be replaced with default implementations. 
      
      * Changes in copy constructors
       - Trail in TrailObject wasn't copied. Now it's copied
       - const annotation added in DeepSkyObject copy constructor
      
      * Overloaded assignment operator in EclipticPosition
        (skyobjects/ksplanetbase.h) removed. Default
        implementation would be just fine too.
      
      Please note, despite the fact that a lot of files are changed
      only conjustion tool is affected by this change. Objects of
      SkyObject class family are not copied much.
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=977139
      cbb53a3a
  12. 25 Feb, 2009 1 commit
  13. 12 Jul, 2008 1 commit
    • Akarsh Simha's avatar
      + Adding copy constructors to KSPlanetBase, KSAsteroid, KSComet and · 03c13c37
      Akarsh Simha authored
        TrailObject in order to facilitate the use of Comets and Asteroids
        in the Calculator, esp. in the Conjunctions Tool.
      
      + Allowing the first object in a conjunction prediction to be an
        asteroid or a comet.
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=831513
      03c13c37
  14. 18 Jan, 2008 1 commit
  15. 21 Dec, 2007 1 commit
    • Jason Harris's avatar
      Applying Akarsh's patch to fix calculation of asteroid magnitudes. · fb58e531
      Jason Harris authored
      I only changed "10" to "SkyObject::ASTEROID" where appropriate.
      
      In testing the magnitudes, I found that the KStars values are always 
      fainter than the published NASA values (at ssd.jpl.nasa.gov) by a few 
      tenths of a magnitude.  I believe this is because the geocentric 
      distance computed by kstars is larger than the NASA values.  I'll have 
      to look into why that is happening.
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=751453
      fb58e531
  16. 22 Sep, 2007 1 commit
    • Jason Harris's avatar
      As discussed on kstars-devel, applying whitespace fixes to our · 64526106
      Jason Harris authored
      codebase.  This is mostly about indenting with 4 spaces instead of
      TAB, but other changes were applied too.  I used the program "astyle"
      to apply the changes; the following configuration file was used:
      
      # brackets should be attached to pre-bracket lines
      brackets=attach
      # set 4 spaces per indent
      indent=spaces=4
      # indent case labels in switch blocks
      #indent-switches
      #indent "public"/"private"/etc. in classes
      indent-classes
      #insert blank line before/after blocks
      break-blocks
      #add empty space inside parentheses
      pad=paren-in
      #don't break one-line blocks
      one-line=keep-blocks
      
      
      Try to use these style options when writing new code.
      
      I did *NOT* run astyle in the htmesh or satlib directories, as these
      contain third-party code.  I also did NOT run it in indi, because I
      thought maybe Jasem would like to use his own style options there.
      
      I noticed a couple of problems with comment blocks; please fix these
      as you find them.
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=715584
      64526106
  17. 13 Apr, 2006 1 commit
  18. 14 Feb, 2006 1 commit
    • Jason Harris's avatar
      A boring commit for better code: · 3067162b
      Jason Harris authored
      changed all empty-string instances ("") to QString().
      Changed QString function arguments to "const QString&"
      
      The first item was done in all code directories, but the second has only 
      been done in the main kstars directory.  Need to propagate changes to 
      tools, widgets, and skycomponents directories.
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=509265
      3067162b
  19. 10 Jun, 2005 1 commit
    • Jason Harris's avatar
      Ladies and Gentlemen, I give you: Pluto the asteroid. · 2cfea597
      Jason Harris authored
      Yes, it's true, Pluto is now derived from KSAsteroid instead of
      KSPlanetBase.  Using the asteroid-like orbital elements results in a
      much more precise determination of its position, which remains robust
      over a much longer interval of time (thousands of years instead of
      ~100 years).
      
      The derived class (KSPluto) hard-codes the orbital elements for Pluto,
      as taken from this site: http://ssd.jpl.nasa.gov/elem_planets.html It
      also allows for the orbital elements to evolve with time, at a
      constant rate.  The rates are also from that website, and are also
      hard-coded in KSPluto,
      
      Updated Pluto's orbital track data for the solar system viewer.  Also
      fixed the calculation of the planets' X/Y coordinates in the tool.
      Before, we gave X and Y in the plane of the planet's orbit, rather
      than in the ecliptic plane.  The positions are now correctly projected
      onto the ecliptic plane.  It only makes a noticeable difference for
      Pluto (due to its large inclination angle).
      
      Also fixed calculation of planet magnitudes.  I was getting "nan" mags
      for both Pluto and Mercury.  I didn't understant the calculation of
      the planet phase, so I used a much simpler formulation of it from
      "Practical Astronomy with your Calculator".  Pablo, please have a look
      at what I did there (in KSPlanetBase::findMagnitude).
      
      CCMAIL: kstars-devel@kde.org
      
      
      svn path=/trunk/KDE/kdeedu/kstars/; revision=423925
      2cfea597
  20. 09 Apr, 2004 1 commit
    • Jason Harris's avatar
      Extensive overhaul of KStars header files: · 1085c7d2
      Jason Harris authored
      + Forward-declare classes wherever possible (i.e.,
      use "class Foo;" instead of "#include <foo.h>")
      
      + Improve DOxygen comments
      
      + Remove some unused functions
      
      + Fix some compiler warnings
      
      The forward-declarations caused a lot of changes.
      Many cpp files were depending on
      remotely-included headers (i.e, it needs a.h, but
      it uses '#include "b.h"'; b.h has '#include "c.h";
      c.h has '#include "a.h"'...yuck).  We should now
      be much closer to the ideal where each file
      includes the headers of the classes that it needs.
      
      Almost all of the header files now have good DOxygen
      API comments.  The few classes which don't are ones
      that I don't feel qualified to document (i.e., INDI).
      
      CCMAIL: kstars-devel@kde.org
      
      svn path=/trunk/kdeedu/kstars/; revision=302474
      1085c7d2
  21. 17 Aug, 2003 1 commit
    • Jason Harris's avatar
      Well, it took all day, but I fixed the Moon bug. · ac428ca5
      Jason Harris authored
      It all started when Jasem noticed that the Moon "jumped" when its popup
      menu was shown.  I tracked the problem to the calculation of rise/set
      times, which reset the moon's position to geocentric coordinates (i.e.,
      without correcting for the fact that the location is on Earth's surface,
      6500 km from the center).
      
      In fixing the problem, I decided to finally apply this "figure of the
      Earth" correction to all solar system bodies, not just the Mooon (even
      though the effect is close to negligible for other bodies, since they
      are much further away).  This caused the usual cascade of changes in
      many parts of the code:
      
      Prior to these changes, each subclass of KSPlanetBase (KSPlanet,
      KSPluto, KSSun, KSMoon, KSAsteroid, and KSComet) had overloaded its own
      unique 'findPosition()' function.  This function has been renamed
      'findGeocentricPosition()', and is now a protected function (it
      shouldn't be called directly from outside the member functions anymore;
      instead call the new findPosition()...see below).
      
      Moved KSMoon's functions 'findPosition(KSNumbers *num, dms *lat, dms
      *LST, KSPlanetBase *Earth)' and 'localizeCoords(dms *lat, dms *LST)' to
      KSPlanetBase.  These are *not* overloaded by the subclasses.
      findPosition calls the overloaded findGeocentricPosition(), and then
      calls localizeCoords() to correct for figure-of-the-Earth.  Since
      localizeCoords() is only used in findPosition(), it is private.  These
      moves allow the figure-of-the-Earth correction to be applied to all
      solar system bodies.
      
      moved KStarsData::isSolarSystem(SkyObject*) to
      SkyObject::isSolarSystem().
      
      several of the functions related to rise/set times in SkyObject had
      tweaks to their arguments.  Basically, instead of passing latitude and
      longitude as dms pointers, we now simply pass a GeoLocation pointer.
      
      Added rearth() and setRearth() to KSPlanetBase. These read and set the
      distance of the body from Earth (which we need for localizeCoords()).
      setRearth( KSPlanetBase *earth ) will compute the distance;
      setRearth(double) will simply set it (in AU).  setRearth(*earth) doesn't
      do anything for the Moon, because its Rearth is computed as part of its
      findGeocentricPosition()
      
      Removed now-redundant KSMoon::distance()
      
      Added '#define AU_KM 1.49605e8' to kstarsdata.h, the number of km in one
      AU.
      
      PlanetCatalog::findPosition( KSNumbers *num ) moved to findPosition(
      KSNumbers *num, dms *lat, dms *LST )
      
      CCMAIL: kstars-devel@lists.sourceforge.net
      
      svn path=/trunk/kdeedu/kstars/; revision=243219
      ac428ca5
  22. 28 May, 2003 1 commit
    • Jason Harris's avatar
      Working toward a better separation of the "backend" from the GUI frontend. · 6106d4c6
      Jason Harris authored
      The motivation for this is to add a command-line mode to generate a skymap
      image based on the current settings stored in the kstarsrc file.  This
      will let people use KStars to dynamically generate desktop wallpapers, for
      example.
      
      To this end, I have removed usage of a pointer to the KStars object
      wherever possible.  KStars is the class for our main window, and also has
      been the container for core parts of the program, such as KStarsData,
      KStarsOptions, SimClock, etc.  To separate the backend, I have made
      KStarsData the keeper of these core non-GUI objects, which will allow us
      to avoid direct usage of the KStars object in functions that have nothing
      to do with the GUI.
      
      All solar-system classes passed a pointer to KStars in their constructor;
      these have been changed to KStarsData pointers.  (In doing this I noticed
      that most of these classes didn't even use this pointer, so I am
      investigating whether we can remove the KStarsData pointer altogether).
      
      The functions in kstars_options_handling (loadOptions() and saveOptions())
      are now members of KStarsData.  The existing KStarsData::saveOptions()
      function has been renamed restoreOptions(), which makes more sense since
      its function is to restore the original options if "Cancel" is selected in
      the ViewOsDialog).  One complication: saveOptions() now takes an optional
      KStars pointer, because some of the options are taken directly from GUI
      properties, such as the window size and the Focus point.
      
      Note that I also added the necessary code to main.cpp for the
      "--dump" command-line option, but it currently does not do anything :)
      CCMAIL: kstars-devel@lists.sourceforge.net
      
      svn path=/trunk/kdeedu/kstars/; revision=228370
      6106d4c6
  23. 12 Mar, 2003 1 commit
  24. 23 Feb, 2003 1 commit