Vijay Dhameliya authored Oct 18, 2013 and Albert Astals Cid committed Oct 18, 2013

While loading data for supernovae, there seems error in reading file supernovae.dat  so it leads to creation of dummy supernovae object which leads to various error during run time of Kstars. So lets avoid creation of such dummy supernovae objects.
This fixes attached bug too.

Approved by Henry de Valence

FIXED-IN: 4.11.3
BUGS: 322848
REVIEW: 112879

(cherry picked from commit a51182d7)

Many of the fixes in bleeding-edge are best put into KDE 4.11, so upon
some brief consultation with fellow developers, we concluded that we
might as well merge bleeding-edge into master.

I also agree with Alexey and Henry that it is best to make small
branches to hold features. It would be interesting if we came up with
a system to notify the mailing list every time a new remote branch is
opened, if not already existing.

Those interested could please help us with some extensive testing so
that we can be sure that KDE 4.11 is error-free.

The hard feature freeze is on the 8th IIRC.

CCMAIL: kstars-devel@kde.org

Skymap should be inited before we register any of its methods to a signal.

BUG: 321028

Fixes the issue with time displayed being one step behind.

BUG: 321028
BUG: 296829
REVIEW: 110973

While this does not really find and eliminate the source of the null
object, it at least prevents KStars from crashing while trying to add
objects to the observing list. The segfault can result in severe loss
of observing wishlist data because the data file is overwritten each
time and the data save could be aborted by a segfault.

It happened to me today, and I have to redo 2 hours of scouring
through observing lists.

Will not backport as we're going to release 4.11 soon.

BUG

Jai Luthra authored Jun 03, 2013 and Akarsh Simha committed Jun 03, 2013

Thanks for your contribution, Jai!

CCMAIL: me@jailuthra.in

This makes the supernovae updater work properly on systems where
the python executable is Python 3 (e.g., Arch Linux).

REVIEW:110398

Conflicts:
	kstars/skyobjects/ksmoon.cpp

This leads to problems on Windows.
also adapt documentation accordingly.

CCBUG: 312775

CCBUG: 318682

autogenerated files during the build must go to the build directory,
to avoid polluting the source directory

of qsTr() in wiview.qml.

It looks weird if there's a separator between Image Resources and Info
Resources, when there's nothing else between them. So if no DSS
imagery is available, but image / info resources are (eg: for
planets). Like this:

Xplanet (for eg.)     >
------------------------
Image Resources       >
------------------------
Information Resources >
------------------------

If DSS images are available, things look better:

Angular Distance [ (eg.)
------------------------
Image Resources       >
Show DSS Image
Show SDSS Image
------------------------
Information Resources >
------------------------

So, it's best to throw in the separator only when DSS / SDSS links are
shown.

The popup menu for some objects would end up becoming too long because
of the number of information and image links. So moving them into
dedicated submenus helps keep the context menu short and improves
usability. Besides, grouping the links as image / info resources helps
users find them more easily.

I decided not to put the DSS / SDSS imagery under the image links
submenu, because they are available for any point on the sky (within
the footprints of the surveys). If we ever create a submenu for sky
surveys, it should possibly go in there.

CCMAIL: kstars-devel@kde.org

Earlier, I changed the default projection to Gnomonic because it looked
like one was "inside" the star globe. On second thoughts, the distortion
is much higher in Gnomonic, so I'm reverting back to Lambert.

I'm not sure what is the best preference for most users. I invite
suggestions and feedback on this subject.

CCMAIL: kstars-devel@kde.org

+ Created the "Data" menu and moved "Download New Data" (GHNS / KNS3)
  and "Updates" (which provides options to update comet / asteroid /
  supernova data) under it.

+ Moved the Observation Planner to the "Observation" menu.

+ Changed internal name of the Observation Menu from oal to
  observation.

+ Indentation improvements

CCMAIL: kstars-devel@kde.org

With the addition of Tupi-Guarani sky culture, the default entry
pointed to that instead. Bumping up this number should make Western
the default again.