1. 10 Aug, 2018 1 commit
  2. 09 Aug, 2018 2 commits
  3. 08 Aug, 2018 3 commits
  4. 07 Aug, 2018 6 commits
    • Eric Dejouhanet's avatar
      Add RA/DEC fields to the list of controls which trigger a save. · e1a3f136
      Eric Dejouhanet authored
      Summary: RA/DEC fields were not triggering the signal calling setDirty and saving the scheduler job values.
      Test Plan:
      Create a scheduler job with any target and sequence.
      Double-click to edit the job.
      Edit RA and/or DEC fields.
      Without the fix, jobs would not re-evaluate on-the-fly to schedule the new coordinates, and values would not be saved.
      With the fix, re-evaluation is triggered when the focus leaves the edit field, and RA/DEC changes are properly saved.
      Reviewers: mutlaqja, wreissenberger
      Subscribers: kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D14679
    • Csaba Kertesz's avatar
      Fix the custom sky object removal · da7c8a6b
      Csaba Kertesz authored
    • Jasem Mutlaq's avatar
      Fix typo · 9c7bebf8
      Jasem Mutlaq authored
    • Jasem Mutlaq's avatar
    • Jasem Mutlaq's avatar
    • Eric Dejouhanet's avatar
      Edit scheduler jobs with double-click and update icon to match Capture module. · 1d45a9c0
      Eric Dejouhanet authored
      Add move buttons, refactor button state changes.
      This change required refactoring to avoid mixing up button states. I
      believe this is too opaque for its own good. The scheduler UI states
      should be moved to their own state machine, QML perhaps?
      Test Plan:
      Create a multi-job scheduler list, with some jobs that will start asap, others that will start later on.
      Double-click to edit jobs, check that single-click will only select.
      Observe that the end-user may click to edit, but observe that fields would not match job line in that case, so learning curve is probably relatively flat for this change.
      Check add button changes to apply when editing, check other button states.
      Change fields, check validation actually change fields.
      [BUG] Note the bug with RA/DEC fields, which do not update the job properly. Another change which triggers a save is required to have it work properly.
      Click to select a job, move it up and down, check other jobs re-evaluate properly.
      Fill fields for a new job, click to select a job, add the new job, new job should be inserted before the selected job.
      [SHOULD WORK, NOT TESTED] Observe schedule inversion when two jobs that can start now change order.
      [SHOULD WORK, NOT TESTED] Double-click a job to edit it, change a field, select another job without validating, apply changes, proper job should update.
      Check button states and evaluation when loading a scheduler list from a file.
      [BUG] Note that sometimes no line is selected, but it's still possible to move jobs.
      Reviewers: mutlaqja, wreissenberger
      Reviewed By: mutlaqja
      Subscribers: kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D14665
  5. 06 Aug, 2018 1 commit
  6. 05 Aug, 2018 7 commits
  7. 04 Aug, 2018 5 commits
    • Andy Galasso's avatar
      The PHD2 external guider was not honoring the Lost Star timeout setting, it... · 45777dfd
      Andy Galasso authored
      The PHD2 external guider was not honoring the Lost Star timeout setting, it was using a hard-coded value of 5 seconds which is much too aggressive.
    • Yuri Chornoivan's avatar
      Fix some EBN issues · a6b9780d
      Yuri Chornoivan authored
    • Wolfgang Reissenberger's avatar
      Summary: Logging output in Capture corrected, considering · 0abaa846
      Wolfgang Reissenberger authored
      only the counts of a single sequence job
      Test Plan:
      Create an Capture plan with two entries of the same
      filter. Check, whether the log output displays the correct counts
      of captured images and total images.
      Reviewers: TallFurryMan, mutlaqja
      Reviewed By: mutlaqja
      Differential Revision: https://phabricator.kde.org/D14605
    • Eric Dejouhanet's avatar
      Rework scheduler startup to merge execution paths. · 46523bed
      Eric Dejouhanet authored
      Reworked Scheduler startup functions so that all execution paths use "startJobEvaluation".
      Function "startJobEvaluation" is also called when clicking button "Only evaluate jobs".
      D-Bus interface "resetAllJobs" is altered to execute an evaluation too.
      Test Plan:
      In the context of starting the Scheduler, create or load a set of Scheduler Jobs.
      Note there is a difference in this Test Plan between full evaluation and on-th-fly evaluation:
      - Full evaluation resets the states of all Scheduler Jobs and unconditionally refreshes the capture storage.
      - On-the-fly evaluation is lighter, does not check storage, and only applies to IDLE, EVALUATION and ABORTED jobs.
      If loading, full evaluation is called after the XML load is successful.
      If creating, on-the-fly evaluation is called every time a control is updated.
      Not that without the fix, there is a regression with Track/Align/Focus/Guide in that context, which cannot be saved (workaround was to finish edit with a pipeline step checked).
      Start the Scheduler, full evaluation is called.
      This fix eliminates remaining issues with capture counts not proper in the Scheduler.
      Now the correct captured frame map is transferred to the capture module and we can start fixing things there.
      Reviewers: mutlaqja, wreissenberger
      Reviewed By: mutlaqja
      Subscribers: kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D14601
    • Eric Dejouhanet's avatar
      Update frame map unconditionally when starting scheduler. · 3e5f9f05
      Eric Dejouhanet authored
      Summary: This fix makes sure the captured frame map is properly updated when the Scheduler starts.
      Test Plan:
      Create a scheduler job with a sequence, make the sequence complete successfully.
      Don't touch the Scheduler, remove some captures from the sequence storage.
      Start the Scheduler.
      Without this fix, capture count is not updated before starting the sequence.
      With this fix, capture count is updated and transferred properly to the sequence.
      Note that issues further down the pipe prevents the sequence from processing properly, this is a first step.
      Reviewers: mutlaqja, wreissenberger
      Reviewed By: mutlaqja
      Subscribers: kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D14587
  8. 03 Aug, 2018 4 commits
    • Eric Dejouhanet's avatar
      Mark scheduler job dirty when succesfully changing its target. · c774401a
      Eric Dejouhanet authored
      When editing a scheduler job, call setDirty when target is selected from the pop-up list.
      The target and RA/DEC boxes were only triggering the job update when editing the text and leaving the field.
      When the pop-up list was used, the programmatic update of those fields wasn't triggering that update.
      This fixes the use case where the end-user is looking for a target to start in ASAP mode.
      In that use case, the end-user will select targets and observe the starting date/time the Scheduler computed.
      Test Plan:
      Create a Scheduler job.
      Click its line in the job table once to edit it, and click the search button.
      Choose another target, the target and RA/DEC fields reflect the update.
      Click the add/save-job button.
      Prior to this fix, the job would not be updated in the queue table.
      With this fix, the job is properly updated.
      Reviewers: mutlaqja, wreissenberger
      Reviewed By: mutlaqja
      Subscribers: kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D14586
    • Csaba Kertesz's avatar
      Use localization for KStars Lite · bf4ac1e6
      Csaba Kertesz authored
    • Csaba Kertesz's avatar
      Further fixes for the Android build · 5cec0578
      Csaba Kertesz authored
    • Eric Dejouhanet's avatar
      Adjust job editing algorithm · f83aed48
      Eric Dejouhanet authored
      Make Scheduler watch job widgets changes properly, so that setDirty is
      called appropriately. Move job edition checks before job creation to
      simplify the algorithm. Clarify when add button enables.
      Fix wrong QT slot connections on QDoubleSpinBox.
      Test Plan:
      Job edition in the Scheduler tab.
      Jobs should properly reevaluate as they are edited, as the original
      algorithm was intending to. Part of the code I removed during the past
      months incorrectly assumed that there was support for canceling changes
      made to a SchedulerJob.
      If that feature is needed, it is relatively simple to clone a backup of
      the SchedulerJob when it is opened for editing, and restore that backup
      when clicking on a cancel button. However, said cancel button should not
      be at the same location as the job removal button for clarity of interface.
      Reviewers: mutlaqja
      Reviewed By: mutlaqja
      Subscribers: pino, kde-edu
      Tags: #kde_edu
      Differential Revision: https://phabricator.kde.org/D13769
  9. 02 Aug, 2018 2 commits
  10. 01 Aug, 2018 5 commits
  11. 31 Jul, 2018 4 commits