1. 23 Nov, 2003 1 commit
    • Pablo de Vicente's avatar
      Fixed a bug first pointed out by Mikhail Zotov in a private communication, · 152179b5
      Pablo de Vicente authored
      who noticed that precession between B1950 to J2000 as done by KStars does not
      coincide with the results given by SIMBAD (http://simbad.u-strasbg.fr/sim-fidl.pl).  M. Zotov has not opened yet a bug in bugs.kde.org, so I have no bug
      number to refer to in this commit.
      
        The bug comes from the fact that conversion between coordinates in B1950
      to J2000 (and viceversa) involves changing from (old) catalog FK4 to FK5,
      and a simple precesion, as done by KStars is not enough.
      
      To fix this bug I have used the following reference:
      Smith, C. A.; Kaplan, G. H.; Hughes, J. A.; Seidelmann, P. K.; Yallop,
      B. D.; Hohenkerk, C. Y.
      Astronomical Journal, vol. 97, Jan. 1989, p. 265-279
      
      The conversion between the FK4 catalog and the FK5 catalog requires 4 steps:
       - Drop E-Terms in B1950 coordinates. In the past, the mean places of
         stars published in the FK4 catalog included the contribution to the
         aberration due to the ellipticity of the orbit of the Earth. These terms,
         known as E-terms were almost constant, and in the newer FK5 catalog they
         are not included.
       - Precess from B1950 to 1984, January 1st, at 0h, using the parameters
         given by the Astronomische Rechen-Institut.
       - Apply the zero-point correction to the right ascensions to correct for the
         equinox error of the FK4. This is done for 1984, Jan 1st, at 0h.
       - Precess from 1984 Jan 1st at 0h, to J2000 using the new precessional
         parameters.
      
         This bug may seem not important since KStars produces a result which is
      almost correct, but since the conversion between B1950 and J2000 is done
      very frequently among astronomers it needs to be corrected. This bug affects
      the precessional module and the galactic/equatorial conversion module. This
      fix ONLY applies to the first module, although now it is straightforward to
      correct the second module. I will do this later.
      
        Since Stephan Kulow only accepts big bug fixes in the KDE 3.2 deep freeze
      period in order to ensure a fast stability of the first relase, I commit
      these fixes only to the KDE 3.1.4 branch, even knowing there may be no ç
      KDE 3.1.5 release in the future. As soon as the KDE 3.2 branch is opened
      for small bug fixes I will port this fix.
      
      CCMAIL: kstars-devel@kde.org
      
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=269012
      152179b5
  2. 14 Oct, 2003 2 commits
  3. 03 Sep, 2003 1 commit
    • Pablo de Vicente's avatar
      The atmospheric refraction at the horizon shifts altitude by · f80c17ab
      Pablo de Vicente authored
      - 34 arcmin = 0.5667 degrees. This value changes if the observer
      is above the horizon, or if the weather conditions change.
      
      For the sun we have to add half the angular sie of the body, since
      the sunset is the time the upper limb of the sun disappears below
      the horizon, and dawn, when the upper part of the limb appears
      over the horizon. The angular size of the sun = angular size of the
      moon = 31' 59''.
      
      So for the sun the correction is = -34 - 16 = 50 arcmin = -0.8333
      
      This same correction should be applied to the Moon however parallax
      is important here. Meeus states that the correction should be
      0.7275 P - 34 arcmin, where P is the moon's horizontal parallax.
      He proposes a mean value of +0.125 degrees if no great accuracy
      is needed.
      
      Changed "if" condition, because I had exchanged the Sun and the stellar
      cases and added a bigger comment explaining why we use these values.
      
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=247999
      f80c17ab
  4. 29 Jul, 2003 1 commit
  5. 21 Jun, 2003 1 commit
    • Jason Harris's avatar
      backporting fix for two precession-related bugs: (1) always precess focus · de6ee12e
      Jason Harris authored
      coordinates when date changes by a lot and tracking an object; (2) the URL
      for requesting a DSS image (slotDSS()/slotDSS2()) must contain the J2000
      coordinates, not the current coordinates.  Fixed for the case where user
      clicked on an object, but not for empty-sky clicks.  The problem is that
      there is no precessToAnyDate() function in 3_1_BRANCH; it is not
      possible to determine J2000 coords from present-day coords without adding
      this function.
      
      CCMAIL: kstars-devel@lists.sourceforge.net
      
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=232804
      de6ee12e
  6. 27 May, 2003 1 commit
  7. 22 Apr, 2003 1 commit
  8. 04 Apr, 2003 1 commit
  9. 17 Mar, 2003 2 commits
    • Ralf Nolden's avatar
      fix compile · 97037914
      Ralf Nolden authored
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=214447
      97037914
    • Ralf Nolden's avatar
      fixincludes · 91ac3e59
      Ralf Nolden authored
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=214416
      91ac3e59
  10. 07 Mar, 2003 1 commit
  11. 06 Mar, 2003 1 commit
  12. 28 Feb, 2003 1 commit
  13. 25 Feb, 2003 1 commit
  14. 24 Feb, 2003 1 commit
  15. 02 Feb, 2003 2 commits
    • Jason Harris's avatar
      The statusBar field that shows the mouse cursor's coordinates was not wide... · 0d2f9ee0
      Jason Harris authored
      The statusBar field that shows the mouse cursor's coordinates was not wide enough to show the coordinates. This was due to an outdated initialization string. Fixed.
      
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=204332
      0d2f9ee0
    • Jason Harris's avatar
      Fixed bug #51708. This was an exit condition on Gentoo systems if the program was started at · 571110b5
      Jason Harris authored
      a position that is below the horizon. When this occurs, the program launches a KMessageBox
      that asks if the user would like to adjust the starting position. On Gentoo systems, the program
      exited (without error!) an instant after the user made a selection (Yes or No, did not matter!).
      Tests showed that when the message box was removed, the exit did not occur. Also, if the
      messagebox is shown after the main window has been displayed, the exit does not occur.
      So, as a workaround, we delayed showing the messagebox until after the main window has been
      show()-ed. We still don't understand this exit condition, but at least it no longer occurs.
      
      svn path=/branches/KDE_3_1_BRANCH/kdeedu/kstars/; revision=204328
      571110b5
  16. 29 Dec, 2002 1 commit
  17. 27 Nov, 2002 1 commit
  18. 15 Nov, 2002 2 commits
  19. 31 Oct, 2002 1 commit
    • Lauri Watts's avatar
      Cleanup · ea0a312b
      Lauri Watts authored
      svn path=/trunk/kdeedu/doc/kstars/; revision=186644
      ea0a312b
  20. 27 Oct, 2002 1 commit
  21. 26 Oct, 2002 1 commit
  22. 24 Oct, 2002 1 commit
    • Jason Harris's avatar
      Adding README.images, which lists authorship and copyright info for · 01df9e06
      Jason Harris authored
      every image used in the program.  Also replaced 28 of the inline images.
      Some of the replaced images had copyright issues.  None of these changes
      affect program execution or i18n.  Asked for permission for this commit
      on kde-devel; consent was given.
      
      svn path=/trunk/kdeedu/kstars/; revision=185511
      01df9e06
  23. 14 Oct, 2002 1 commit
    • Jason Harris's avatar
      efficiency bugfix: call SkyMap::update() less often. We had been calling · 741a9f5a
      Jason Harris authored
      a "non-computational" update() 10 times a second.  This basically blits
      the sky pixmap onto the window and draws the infoboxes.  We now only call
      update() if the LT/UT/ST time values have changed (so, roughly 1-2 times
      per second).
      
      Also, removed hard-coded restriction on width of timespinbox widget.
      
      svn path=/trunk/kdeedu/kstars/; revision=183943
      741a9f5a
  24. 12 Oct, 2002 2 commits
  25. 30 Sep, 2002 1 commit
  26. 28 Sep, 2002 1 commit
  27. 27 Sep, 2002 1 commit
  28. 25 Sep, 2002 1 commit
  29. 24 Sep, 2002 1 commit
  30. 22 Sep, 2002 2 commits
  31. 20 Sep, 2002 3 commits
    • Jason Harris's avatar
      reverting dms::SinCos() back to separate sin()/cos() calls until we find a · cf3ea143
      Jason Harris authored
      way to determine if the user has the GNU math library (as opposed to an
      ANSI-standard library, in which the sincos() function is not defined).
      
      svn path=/trunk/kdeedu/kstars/; revision=179189
      cf3ea143
    • Script Kiddy's avatar
      CVS_SILENT made messages · ccc9f1c0
      Script Kiddy authored
      svn path=/trunk/kdeedu/kstars/; revision=179129
      ccc9f1c0
    • Andy Fawcett's avatar
      Portability fix for FreeBSD, probably needs fixing for other non-glibc systems too · 125dcb33
      Andy Fawcett authored
      I'm pretty sure this can be done with auto*, but it is beyond my skills.
      
      From Jason's commit log (for the backport to KDE_3_0_BRANCH)
      --
      two performance backports:  Replaced dms::PI() with const double dms::PI.
      We had been actually computing acos(-1) every time we needed PI (duh).
      Now we just use the value defined in math.h.  Also, using sincos()
      function defined in math.h in place of calling sin() and cos() separately
      in dms::SinCos().  This is about 33% faster.  However, sincos() is not a
      standard C/C++ function; it is defined in GNU C.  We may need to add a
      contingency for non-Linux compiles...
      --
      
      This has just ensured that the Branch won't build for some people (me for a start, and I
      am quite sure others too). Please consider reverting the sincos() stuff in the branch,
      as I am not going to commit a partial fix there, just to sort out something that should
      have been fully tested in HEAD before backporting.
      
      CCMAIL: kstars@30doradus.org
      
      diff -u -3 -p -r1.11 dms.cpp
      --- dms.cpp     2002/09/19 11:52:57     1.11
      +++ dms.cpp     2002/09/20 06:03:06
      @@ -106,17 +106,21 @@ dms dms::operator- (dms angle)
      
       void dms::SinCos( double &sina, double &cosa ) {
       // This is the old implementation of sincos which is standard C compliant
      +#if defined(__FreeBSD__)
      +// almost certainly this needs more checks for other non-glibc platforms
      +// but I am currently unable to check those
       /*
              register double rad = radians();
              sina = sin( rad );
              cosa = cos( rad );
       */
      -
      +#else
       /**The sincos function computes sin and cos at once (hardware accelareted / fsincos in assembler).
              *It's ~33% faster than computing sin and cos separate. But sincos() is not a standard C/C++
              *function and requires #define _GNU_SOURCE. It's defined in math.h.
              */
              sincos(radians(), &sina, &cosa);
      +#endif
       }
      
      svn path=/trunk/kdeedu/kstars/; revision=179090
      125dcb33
  32. 19 Sep, 2002 1 commit