1. 03 Aug, 2018 1 commit
    • Eric Dejouhanet's avatar
      Adjust job editing algorithm · f83aed48
      Eric Dejouhanet authored
      Summary:
      Make Scheduler watch job widgets changes properly, so that setDirty is
      called appropriately. Move job edition checks before job creation to
      simplify the algorithm. Clarify when add button enables.
      
      Fix wrong QT slot connections on QDoubleSpinBox.
      
      Test Plan:
      Job edition in the Scheduler tab.
      
      Jobs should properly reevaluate as they are edited, as the original
      algorithm was intending to. Part of the code I removed during the past
      months incorrectly assumed that there was support for canceling changes
      made to a SchedulerJob.
      
      If that feature is needed, it is relatively simple to clone a backup of
      the SchedulerJob when it is opened for editing, and restore that backup
      when clicking on a cancel button. However, said cancel button should not
      be at the same location as the job removal button for clarity of interface.
      
      Reviewers: mutlaqja
      
      Reviewed By: mutlaqja
      
      Subscribers: pino, kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D13769
      f83aed48
  2. 02 Aug, 2018 2 commits
  3. 01 Aug, 2018 5 commits
  4. 31 Jul, 2018 4 commits
  5. 30 Jul, 2018 4 commits
  6. 29 Jul, 2018 3 commits
    • Jasem Mutlaq's avatar
      Show tip of the day dialog after applying themes. · 6654b2fd
      Jasem Mutlaq authored
      BUGS:396953
      FIXED-IN:3.0.0
      6654b2fd
    • Jasem Mutlaq's avatar
      c8847a5f
    • Andy Galasso's avatar
      PHD2: honor the "Receive external guide frames" setting. Also, only log event... · 9be2169d
      Andy Galasso authored
      PHD2: honor the "Receive external guide frames" setting. Also, only log event messages from PHD2 when verbose logging is enabled
      PHD2: only request a new star image if there is not already an outstanding requests to get the star image
      PHD2: additional communication reliablity work
      
          - prevent problem with intermittent dropped messages by only sending a single JSONRPC request at a time
          - added more debug logging
          - use the documented set of phd2 states; remove custom states and use new state variables for dither state
          - fix error that aborts guiding when a dither is started before the initial settling has completed
          - fix dither timeouts being caused by the dither timer expiring sooner than the timeout sent to PHD2
      PHD2: fix error loading PHD2 star image
      
          In every other frame the temporary .fit file was getting deleted before it could be displayed.
      
          Also, fix a possible file descriptor leak that could occur if a fitsio function call failed.
      
      PHD2: do not process partial JSON responses, wait until the full resonse (terminated by newline) is received
      
          The existing code could prematurely process incomplete chunks of phd2 response messages. Now we will
          wait for a full newline-terminated message before processing the response. This also allows us to remove
          a bunch of workaround code that was trying to deal with chopped-up partial messages.
      
      CCMAIL:kstars-devel@kde.org
      CCMAIL:rlancaster@gmail.com
      BUGS:392392
      FIXED-IN:3.0.0
      9be2169d
  7. 28 Jul, 2018 1 commit
    • Pino Toscano's avatar
      i18n fixes · 0e259fb0
      Pino Toscano authored
      - fixes string puzzles
      - English style fixes
      - avoid contractions ("aren't" -> "are not", etc)
      - remove extra QString() around i18n()
      - avoid almost all the exclamation marks, since this is not a game
      - do not translate messages to debug
      - spell "Internet", and "JSON" correctly
      - use KMessageBox::information() instead of error() for an actual information message...
      - remove some of the extra HTML markup in UI files
      
      This is just the tip of the iceberg of i18n issues in kstars ...
      0e259fb0
  8. 26 Jul, 2018 2 commits
  9. 25 Jul, 2018 6 commits
  10. 24 Jul, 2018 8 commits
  11. 23 Jul, 2018 4 commits