1. 15 Aug, 2018 1 commit
  2. 13 Aug, 2018 2 commits
    • Jasem Mutlaq's avatar
      Fix upper limits for some guide settings · eb4aa89d
      Jasem Mutlaq authored
      eb4aa89d
    • Eric Dejouhanet's avatar
      Fixes for the Scheduler and Capture modules · b7e3810b
      Eric Dejouhanet authored
      Summary:
      - Adds a type for the captured frame map.
      - Updates captured frames map when a capture completes.
      - Removes use of general variables and prefer activeJob whenever possible in the capture module.
      - Fixes the issue with duplicated scheduler jobs using duplicated sequence jobs. (Issue was in the duration estimation, which was not properly consolidating captured frames for single scheduler jobs.)
      - Fixes evaluation of Hour Angle when checking meridian flip in the case DEC is +/-90 degrees (undefined HA).
      - Fixes unexpected slew when repeating a scheduler job with no pipeline step checked.
      - Fixes dbus error management, reworks function unParkMount to clarify state.
      - Fixes park/unpark looping in unparked/parked state, reworks checkMountParkingStatus.
      - Fixes capture progress at 100% at the beginning of capture.
      - Fixes incoherent use of target prefix in the capture path.
      - Adds a message in the Capture module when a capture aborts.
      - Fixes signature management when an hardcoded prefix is used in the sequence.
      - Updates duplicate job warning, incorrect when two different sequences have the same storage.
      - Fixes no-step job looping on altitude check.
      - Fixes update of captured frames map for sequence jobs already complete.
      
      There are no additional abort detections, so Scheduler may still get stuck if the error doesn't come up at its level. A later change will introduce timeouts for Scheduler steps.
      
      Test Plan:
      Use as many tests vectors as possible, in various configurations.
      - simple_test tested OK
      - simple_test_no_twilight tested OK
      - duplicated_scheduler_jobs_no_twilight tested OK
      - duplicated_scheduler_jobs_duplicated_sequence_jobs_no_twilight tested OK
      - complex_job tested OK, but there is a bug remaining on guiding deviation
      
      Message "Manual scheduled focusing is not supported" is still annoying when running test vectors in sequence, to be investigated and eventually removed very soon.
      
      Image count update in the Scheduler is still an issue, and is probably not just picking a signal and increasing a count.
      
      There is a spurious folder created with the name of the capture prefix. This is a regression from the signature fix for the prefix issue. Fairly minimal, but not professional.
      
      Guider is doing weird things when used with the simulator. It detects offset on the guide star although the simulator always produce the same image, only noise is different from frame to frame, and this seems to cause issues with drift calculation. Or the settings of my guider page are completely off... However, the guider is able to produce a guiding deviation that exceeds the bounds acceptable for exposure, and capture suspends.
      Now this is still an issue in the last differential: capture module suspends for 60 seconds waiting for the guider, guider never really asserts return to bounds, and capture module never asserts the suspend timer neither. Ooof.
      
      To get a guiding abort with the simulator in a development VM, pause the VM for a few minutes or hours.
      This will cause a large instant deviation that will abort the guiding procedure.
      This currently causes the Scheduler to properly abort, but then loop indefinitely without succeeding in restarting its jobs.
      
      Reviewers: mutlaqja, wreissenberger
      
      Reviewed By: mutlaqja
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14684
      b7e3810b
  3. 12 Aug, 2018 3 commits
  4. 11 Aug, 2018 4 commits
  5. 10 Aug, 2018 2 commits
  6. 09 Aug, 2018 2 commits
  7. 08 Aug, 2018 3 commits
  8. 07 Aug, 2018 6 commits
    • Eric Dejouhanet's avatar
      Add RA/DEC fields to the list of controls which trigger a save. · e1a3f136
      Eric Dejouhanet authored
      Summary: RA/DEC fields were not triggering the signal calling setDirty and saving the scheduler job values.
      
      Test Plan:
      Create a scheduler job with any target and sequence.
      Double-click to edit the job.
      Edit RA and/or DEC fields.
      Without the fix, jobs would not re-evaluate on-the-fly to schedule the new coordinates, and values would not be saved.
      With the fix, re-evaluation is triggered when the focus leaves the edit field, and RA/DEC changes are properly saved.
      
      Reviewers: mutlaqja, wreissenberger
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14679
      e1a3f136
    • Csaba Kertesz's avatar
      Fix the custom sky object removal · da7c8a6b
      Csaba Kertesz authored
      da7c8a6b
    • Jasem Mutlaq's avatar
      Fix typo · 9c7bebf8
      Jasem Mutlaq authored
      9c7bebf8
    • Jasem Mutlaq's avatar
      7f915094
    • Jasem Mutlaq's avatar
      6da8bb68
    • Eric Dejouhanet's avatar
      Edit scheduler jobs with double-click and update icon to match Capture module. · 1d45a9c0
      Eric Dejouhanet authored
      Summary:
      Add move buttons, refactor button state changes.
      
      This change required refactoring to avoid mixing up button states. I
      believe this is too opaque for its own good. The scheduler UI states
      should be moved to their own state machine, QML perhaps?
      
      Test Plan:
      Create a multi-job scheduler list, with some jobs that will start asap, others that will start later on.
      Double-click to edit jobs, check that single-click will only select.
      Observe that the end-user may click to edit, but observe that fields would not match job line in that case, so learning curve is probably relatively flat for this change.
      Check add button changes to apply when editing, check other button states.
      Change fields, check validation actually change fields.
      [BUG] Note the bug with RA/DEC fields, which do not update the job properly. Another change which triggers a save is required to have it work properly.
      Click to select a job, move it up and down, check other jobs re-evaluate properly.
      Fill fields for a new job, click to select a job, add the new job, new job should be inserted before the selected job.
      [SHOULD WORK, NOT TESTED] Observe schedule inversion when two jobs that can start now change order.
      [SHOULD WORK, NOT TESTED] Double-click a job to edit it, change a field, select another job without validating, apply changes, proper job should update.
      Check button states and evaluation when loading a scheduler list from a file.
      [BUG] Note that sometimes no line is selected, but it's still possible to move jobs.
      
      Reviewers: mutlaqja, wreissenberger
      
      Reviewed By: mutlaqja
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14665
      1d45a9c0
  9. 06 Aug, 2018 1 commit
  10. 05 Aug, 2018 7 commits
  11. 04 Aug, 2018 5 commits
    • Andy Galasso's avatar
      The PHD2 external guider was not honoring the Lost Star timeout setting, it... · 45777dfd
      Andy Galasso authored
      The PHD2 external guider was not honoring the Lost Star timeout setting, it was using a hard-coded value of 5 seconds which is much too aggressive.
      45777dfd
    • Yuri Chornoivan's avatar
      Fix some EBN issues · a6b9780d
      Yuri Chornoivan authored
      a6b9780d
    • Wolfgang Reissenberger's avatar
      Summary: Logging output in Capture corrected, considering · 0abaa846
      Wolfgang Reissenberger authored
      only the counts of a single sequence job
      
      Test Plan:
      Create an Capture plan with two entries of the same
      filter. Check, whether the log output displays the correct counts
      of captured images and total images.
      
      Reviewers: TallFurryMan, mutlaqja
      
      Reviewed By: mutlaqja
      
      Differential Revision: https://phabricator.kde.org/D14605
      0abaa846
    • Eric Dejouhanet's avatar
      Rework scheduler startup to merge execution paths. · 46523bed
      Eric Dejouhanet authored
      Summary:
      Reworked Scheduler startup functions so that all execution paths use "startJobEvaluation".
      Function "startJobEvaluation" is also called when clicking button "Only evaluate jobs".
      D-Bus interface "resetAllJobs" is altered to execute an evaluation too.
      
      Test Plan:
      In the context of starting the Scheduler, create or load a set of Scheduler Jobs.
      
      Note there is a difference in this Test Plan between full evaluation and on-th-fly evaluation:
      - Full evaluation resets the states of all Scheduler Jobs and unconditionally refreshes the capture storage.
      - On-the-fly evaluation is lighter, does not check storage, and only applies to IDLE, EVALUATION and ABORTED jobs.
      
      If loading, full evaluation is called after the XML load is successful.
      
      If creating, on-the-fly evaluation is called every time a control is updated.
      
      Not that without the fix, there is a regression with Track/Align/Focus/Guide in that context, which cannot be saved (workaround was to finish edit with a pipeline step checked).
      
      Start the Scheduler, full evaluation is called.
      This fix eliminates remaining issues with capture counts not proper in the Scheduler.
      Now the correct captured frame map is transferred to the capture module and we can start fixing things there.
      
      Reviewers: mutlaqja, wreissenberger
      
      Reviewed By: mutlaqja
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14601
      46523bed
    • Eric Dejouhanet's avatar
      Update frame map unconditionally when starting scheduler. · 3e5f9f05
      Eric Dejouhanet authored
      Summary: This fix makes sure the captured frame map is properly updated when the Scheduler starts.
      
      Test Plan:
      Create a scheduler job with a sequence, make the sequence complete successfully.
      Don't touch the Scheduler, remove some captures from the sequence storage.
      Start the Scheduler.
      Without this fix, capture count is not updated before starting the sequence.
      With this fix, capture count is updated and transferred properly to the sequence.
      
      Note that issues further down the pipe prevents the sequence from processing properly, this is a first step.
      
      Reviewers: mutlaqja, wreissenberger
      
      Reviewed By: mutlaqja
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14587
      3e5f9f05
  12. 03 Aug, 2018 4 commits
    • Eric Dejouhanet's avatar
      Mark scheduler job dirty when succesfully changing its target. · c774401a
      Eric Dejouhanet authored
      Summary:
      When editing a scheduler job, call setDirty when target is selected from the pop-up list.
      The target and RA/DEC boxes were only triggering the job update when editing the text and leaving the field.
      When the pop-up list was used, the programmatic update of those fields wasn't triggering that update.
      
      This fixes the use case where the end-user is looking for a target to start in ASAP mode.
      In that use case, the end-user will select targets and observe the starting date/time the Scheduler computed.
      
      Test Plan:
      Create a Scheduler job.
      Click its line in the job table once to edit it, and click the search button.
      Choose another target, the target and RA/DEC fields reflect the update.
      Click the add/save-job button.
      Prior to this fix, the job would not be updated in the queue table.
      With this fix, the job is properly updated.
      
      Reviewers: mutlaqja, wreissenberger
      
      Reviewed By: mutlaqja
      
      Subscribers: kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D14586
      c774401a
    • Csaba Kertesz's avatar
      Use localization for KStars Lite · bf4ac1e6
      Csaba Kertesz authored
      bf4ac1e6
    • Csaba Kertesz's avatar
      Further fixes for the Android build · 5cec0578
      Csaba Kertesz authored
      5cec0578
    • Eric Dejouhanet's avatar
      Adjust job editing algorithm · f83aed48
      Eric Dejouhanet authored
      Summary:
      Make Scheduler watch job widgets changes properly, so that setDirty is
      called appropriately. Move job edition checks before job creation to
      simplify the algorithm. Clarify when add button enables.
      
      Fix wrong QT slot connections on QDoubleSpinBox.
      
      Test Plan:
      Job edition in the Scheduler tab.
      
      Jobs should properly reevaluate as they are edited, as the original
      algorithm was intending to. Part of the code I removed during the past
      months incorrectly assumed that there was support for canceling changes
      made to a SchedulerJob.
      
      If that feature is needed, it is relatively simple to clone a backup of
      the SchedulerJob when it is opened for editing, and restore that backup
      when clicking on a cancel button. However, said cancel button should not
      be at the same location as the job removal button for clarity of interface.
      
      Reviewers: mutlaqja
      
      Reviewed By: mutlaqja
      
      Subscribers: pino, kde-edu
      
      Tags: #kde_edu
      
      Differential Revision: https://phabricator.kde.org/D13769
      f83aed48