Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KStars KStars
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 86
    • Issues 86
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Education
  • KStarsKStars
  • Merge requests
  • !477

Merged
Created Nov 26, 2021 by Toni Schriber@escribanContributor

standardized dialog for guider 'Control Parameters' & 'Other Settings'

  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 2

Before the refactor of the guiding modules by Hy Murvit it was necessary to implement a special handling for parameters like Proportional Gain, Integral Gain, etc. The dialog for these parameters was in the main guidedialog and did not have an Apply- and OK-button. After the refactor they are placed in a sub-KConfigPage with Apply- and OK-button and it is very confusing to use two different schemes: 'Control Parameters' uses direct saving and 'Other Settings' uses the built-in saving of KConfigDialog via 'kcfg'-variables!

This MR use 'kcfg'-variables throughout the whole dialog so the handling of all parameters is the same and simplifies the code a lot because saving is handled automatically by the 'kcfg'-variables scheme.

Edited Nov 26, 2021 by Toni Schriber
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: unifiedguidedialog