Skip to content

GitLab

Commit e0e46e86 authored by Stefan Gerlach's avatar Stefan Gerlach
Browse files
Options

[locale] axis and histogram dock

parent f9866b4e
Hide whitespace changes
Inline Side-by-side
Showing with 94 additions and 69 deletions
src/kdefrontend/dockwidgets/AxisDock.cpp
View file @ e0e46e86
......@@ -288,7 +288,7 @@ void AxisDock::init() {
ui.cbArrowType->setItemIcon(0, pm);
//simple, small
float cos_phi = cos(3.14159/6);
double cos_phi = cos(M_PI/6.);
pm.fill(Qt::transparent);
pa.begin( &pm );
pa.setRenderHint(QPainter::Antialiasing);
......@@ -314,6 +314,7 @@ void AxisDock::init() {
pa.setRenderHint(QPainter::Antialiasing);
pa.setBrush(Qt::SolidPattern);
pa.drawLine(3, 10, 17, 10);
//TODO: QPolygon?
QPointF points3[3] = {QPointF(17, 10), QPointF(10, 10-4*cos_phi), QPointF(10, 10+4*cos_phi) };
pa.drawPolygon(points3, 3);
pa.end();
......@@ -622,16 +623,19 @@ void AxisDock::positionChanged() {
if (m_initializing)
return;
double offset = ui.lePosition->text().toDouble();
for (auto* axis : m_axesList)
axis->setOffset(offset);
bool ok;
const double offset{QLocale().toDouble(ui.lePosition->text(), &ok)};
if (ok) {
for (auto* axis : m_axesList)
axis->setOffset(offset);
}
}
void AxisDock::scaleChanged(int index) {
if (m_initializing)
return;
auto scale = (Axis::Scale)index;
auto scale = static_cast<Axis::Scale>(index);
for (auto* axis : m_axesList)
axis->setScale(scale);
}
......@@ -654,7 +658,10 @@ void AxisDock::startChanged() {
if (m_initializing)
return;
double value = ui.leStart->text().toDouble();
bool ok;
double value{QLocale().toDouble(ui.leStart->text(), &ok)};
if (!ok)
return;
//check first, whether the value for the lower limit is valid for the log- and square root scaling. If not, set the default values.
auto scale = Axis::Scale(ui.cbScale->currentIndex());
......@@ -663,16 +670,16 @@ void AxisDock::startChanged() {
KMessageBox::sorry(this,
i18n("The axes lower limit has a non-positive value. Default minimal value will be used."),
i18n("Wrong lower limit value") );
ui.leStart->setText( "0.01" );
value = 0.01;
ui.leStart->setText(QLocale().toString(value) );
}
} else if (scale == Axis::Scale::Sqrt) {
if (value < 0) {
KMessageBox::sorry(this,
i18n("The axes lower limit has a negative value. Default minimal value will be used."),
i18n("Wrong lower limit value") );
ui.leStart->setText( "0" );
value = 0;
ui.leStart->setText(QLocale().toString(value) );
}
}
......@@ -685,7 +692,11 @@ void AxisDock::endChanged() {
if (m_initializing)
return;
double value = ui.leEnd->text().toDouble();
bool ok;
const double value{QLocale().toDouble(ui.leEnd->text(), &ok)};
if (!ok)
return;
const Lock lock(m_initializing);
for (auto* axis : m_axesList)
axis->setEnd(value);
......@@ -713,7 +724,11 @@ void AxisDock::zeroOffsetChanged() {
if (m_initializing)
return;
double offset = ui.leZeroOffset->text().toDouble();
bool ok;
const double offset{QLocale().toDouble(ui.leZeroOffset->text(), &ok)};
if (!ok)
return;
const Lock lock(m_initializing);
for (auto* axis : m_axesList)
axis->setZeroOffset(offset);
......@@ -723,7 +738,11 @@ void AxisDock::scalingFactorChanged() {
if (m_initializing)
return;
double scalingFactor = ui.leScalingFactor->text().toDouble();
bool ok;
const double scalingFactor{QLocale().toDouble(ui.leScalingFactor->text(), &ok)};
if (!ok)
return;
if (scalingFactor != 0.0) {
const Lock lock(m_initializing);
for (auto* axis : m_axesList)
......@@ -770,7 +789,7 @@ void AxisDock::lineColorChanged(const QColor& color) {
m_initializing = false;
}
void AxisDock::lineWidthChanged(double value) {
void AxisDock::lineWidthChanged(double value) {
if (m_initializing)
return;
......@@ -786,7 +805,7 @@ void AxisDock::lineOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* axis : m_axesList)
axis->setLineOpacity(opacity);
}
......@@ -821,7 +840,7 @@ void AxisDock::arrowSizeChanged(int value) {
if (m_initializing)
return;
float v = Worksheet::convertToSceneUnits(value, Worksheet::Unit::Point);
double v = Worksheet::convertToSceneUnits(value, Worksheet::Unit::Point);
for (auto* axis : m_axesList)
axis->setArrowSize(v);
}
......@@ -1052,7 +1071,7 @@ void AxisDock::majorTicksOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* axis : m_axesList)
axis->setMajorTicksOpacity(opacity);
}
......@@ -1282,7 +1301,7 @@ void AxisDock::minorTicksOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* axis : m_axesList)
axis->setMinorTicksOpacity(opacity);
}
......@@ -1467,7 +1486,7 @@ void AxisDock::majorGridOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* axis : m_axesList)
axis->setMajorGridOpacity(opacity);
}
......@@ -1527,7 +1546,7 @@ void AxisDock::minorGridOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* axis : m_axesList)
axis->setMinorGridOpacity(opacity);
}
......@@ -1567,9 +1586,9 @@ void AxisDock::axisPositionChanged(Axis::Position position) {
m_initializing = false;
}
void AxisDock::axisPositionChanged(float value) {
void AxisDock::axisPositionChanged(double value) {
m_initializing = true;
ui.lePosition->setText( QString::number(value) );
ui.lePosition->setText(QLocale().toString(value));
m_initializing = false;
}
......@@ -1589,11 +1608,11 @@ void AxisDock::axisStartChanged(double value) {
if (m_initializing) return;
const Lock lock(m_initializing);
ui.leStart->setText( QString::number(value) );
ui.leStart->setText(QLocale().toString(value));
ui.dateTimeEditStart->setDateTime( QDateTime::fromMSecsSinceEpoch(value) );
// determine stepsize and number of decimals
double range = fabs(m_axis->end() - m_axis->start());
double range = std::abs(m_axis->end() - m_axis->start());
int decimals = nsl_math_rounded_decimals(range) + 1;
DEBUG("range = " << range << ", decimals = " << decimals)
ui.sbMajorTicksSpacingNumeric->setDecimals(decimals);
......@@ -1605,11 +1624,11 @@ void AxisDock::axisEndChanged(double value) {
if (m_initializing) return;
const Lock lock(m_initializing);
ui.leEnd->setText( QString::number(value) );
ui.leEnd->setText(QLocale().toString(value));
ui.dateTimeEditEnd->setDateTime( QDateTime::fromMSecsSinceEpoch(value) );
// determine stepsize and number of decimals
double range = fabs(m_axis->end() - m_axis->start());
double range = std::abs(m_axis->end() - m_axis->start());
int decimals = nsl_math_rounded_decimals(range) + 1;
DEBUG("range = " << range << ", decimals = " << decimals)
ui.sbMajorTicksSpacingNumeric->setDecimals(decimals);
......@@ -1620,13 +1639,13 @@ void AxisDock::axisEndChanged(double value) {
void AxisDock::axisZeroOffsetChanged(qreal value) {
if (m_initializing) return;
const Lock lock(m_initializing);
ui.leZeroOffset->setText( QString::number(value) );
ui.leZeroOffset->setText(QLocale().toString(value));
}
void AxisDock::axisScalingFactorChanged(qreal value) {
if (m_initializing) return;
const Lock lock(m_initializing);
ui.leScalingFactor->setText( QString::number(value) );
ui.leScalingFactor->setText(QLocale().toString(value));
}
//line
......@@ -1874,11 +1893,11 @@ void AxisDock::load() {
else
ui.cbPosition->setCurrentIndex(index);
ui.lePosition->setText( QString::number( m_axis->offset()) );
ui.cbScale->setCurrentIndex( (int) m_axis->scale() );
ui.lePosition->setText( QLocale().toString(m_axis->offset()) );
ui.cbScale->setCurrentIndex( (int)m_axis->scale() );
ui.chkAutoScale->setChecked( m_axis->autoScale() );
ui.leStart->setText( QString::number(m_axis->start()) );
ui.leEnd->setText( QString::number(m_axis->end()) );
ui.leStart->setText( QLocale().toString(m_axis->start()) );
ui.leEnd->setText( QLocale().toString(m_axis->end()) );
ui.sbMajorTicksSpacingNumeric->setDecimals(0);
ui.sbMajorTicksSpacingNumeric->setSingleStep(m_axis->majorTicksSpacing());
......@@ -1922,8 +1941,8 @@ void AxisDock::load() {
}
}
ui.leZeroOffset->setText( QString::number(m_axis->zeroOffset()) );
ui.leScalingFactor->setText( QString::number(m_axis->scalingFactor()) );
ui.leZeroOffset->setText( QLocale().toString(m_axis->zeroOffset()) );
ui.leScalingFactor->setText( QLocale().toString(m_axis->scalingFactor()) );
//Line
ui.cbLineStyle->setCurrentIndex( (int) m_axis->linePen().style() );
......@@ -2033,13 +2052,13 @@ void AxisDock::loadConfig(KConfig& config) {
else
ui.cbPosition->setCurrentIndex(index);
ui.lePosition->setText( QString::number( group.readEntry("PositionOffset", m_axis->offset())) );
ui.lePosition->setText( QLocale().toString(group.readEntry("PositionOffset", m_axis->offset())) );
ui.cbScale->setCurrentIndex( group.readEntry("Scale", (int) m_axis->scale()) );
ui.chkAutoScale->setChecked(group.readEntry("AutoScale", m_axis->autoScale()));
ui.leStart->setText( QString::number( group.readEntry("Start", m_axis->start())) );
ui.leEnd->setText( QString::number( group.readEntry("End", m_axis->end())) );
ui.leZeroOffset->setText( QString::number( group.readEntry("ZeroOffset", m_axis->zeroOffset())) );
ui.leScalingFactor->setText( QString::number( group.readEntry("ScalingFactor", m_axis->scalingFactor())) );
ui.chkAutoScale->setChecked( group.readEntry("AutoScale", m_axis->autoScale()) );
ui.leStart->setText( QLocale().toString(group.readEntry("Start", m_axis->start())) );
ui.leEnd->setText( QLocale().toString(group.readEntry("End", m_axis->end())) );
ui.leZeroOffset->setText( QLocale().toString(group.readEntry("ZeroOffset", m_axis->zeroOffset())) );
ui.leScalingFactor->setText( QLocale().toString(group.readEntry("ScalingFactor", m_axis->scalingFactor())) );
//Title
KConfigGroup axisLabelGroup = config.group("AxisLabel");
......@@ -2149,12 +2168,12 @@ void AxisDock::saveConfigAsTemplate(KConfig& config) {
group.writeEntry("Position", ui.cbPosition->currentIndex() + 2);
}
group.writeEntry("PositionOffset", ui.lePosition->text());
group.writeEntry("PositionOffset", QLocale().toDouble(ui.lePosition->text()));
group.writeEntry("Scale", ui.cbScale->currentIndex());
group.writeEntry("Start", ui.leStart->text());
group.writeEntry("End", ui.leEnd->text());
group.writeEntry("ZeroOffset", ui.leZeroOffset->text());
group.writeEntry("ScalingFactor", ui.leScalingFactor->text());
group.writeEntry("Start", QLocale().toDouble(ui.leStart->text()));
group.writeEntry("End", QLocale().toDouble(ui.leEnd->text()));
group.writeEntry("ZeroOffset", QLocale().toDouble(ui.leZeroOffset->text()));
group.writeEntry("ScalingFactor", QLocale().toDouble(ui.leScalingFactor->text()));
//Title
KConfigGroup axisLabelGroup = config.group("AxisLabel");
......
src/kdefrontend/dockwidgets/AxisDock.h
View file @ e0e46e86
......@@ -154,7 +154,7 @@ private slots:
void axisDescriptionChanged(const AbstractAspect*);
void axisOrientationChanged(Axis::Orientation);
void axisPositionChanged(Axis::Position);
void axisPositionChanged(float);
void axisPositionChanged(double);
void axisScaleChanged(Axis::Scale);
void axisAutoScaleChanged(bool);
void axisStartChanged(double);
......
src/kdefrontend/dockwidgets/HistogramDock.cpp
View file @ e0e46e86
......@@ -403,10 +403,10 @@ void HistogramDock::setCurves(QList<Histogram*> list) {
ui.cbOrientation->setCurrentIndex(m_curve->orientation());
ui.cbBinningMethod->setCurrentIndex(m_curve->binningMethod());
ui.sbBinCount->setValue(m_curve->binCount());
ui.leBinWidth->setText(QString::number(m_curve->binWidth()));
ui.leBinWidth->setText(QLocale().toString(m_curve->binWidth()));
ui.chkAutoBinRanges->setChecked(m_curve->autoBinRanges());
ui.leBinRangesMin->setText( QString::number(m_curve->binRangesMin()) );
ui.leBinRangesMax->setText( QString::number(m_curve->binRangesMax()) );
ui.leBinRangesMin->setText( QLocale().toString(m_curve->binRangesMin()) );
ui.leBinRangesMax->setText( QLocale().toString(m_curve->binRangesMax()) );
ui.chkVisible->setChecked( m_curve->isVisible() );
KConfig config(QString(), KConfig::SimpleConfig);
......@@ -576,9 +576,12 @@ void HistogramDock::binWidthChanged() {
return;
const Lock lock(m_initializing);
float width = ui.leBinWidth->text().toDouble();
for (auto* curve : m_curvesList)
curve->setBinWidth(width);
bool ok;
const double width{QLocale().toDouble(ui.leBinWidth->text(), &ok)};
if (ok) {
for (auto* curve : m_curvesList)
curve->setBinWidth(width);
}
}
void HistogramDock::autoBinRangesChanged(int state) {
......@@ -594,15 +597,16 @@ void HistogramDock::autoBinRangesChanged(int state) {
}
void HistogramDock::binRangesMinChanged(const QString& value) {
DEBUG("HistogramDock::binRangesMinChanged() value = " << value.toDouble());
if (m_initializing)
return;
DEBUG(" set value")
const Lock lock(m_initializing);
const double min = value.toDouble();
for (auto* hist : m_curvesList)
hist->setBinRangesMin(min);
bool ok;
const double min{QLocale().toDouble(value, &ok)};
if (ok) {
for (auto* hist : m_curvesList)
hist->setBinRangesMin(min);
}
}
void HistogramDock::binRangesMaxChanged(const QString& value) {
......@@ -610,9 +614,12 @@ void HistogramDock::binRangesMaxChanged(const QString& value) {
return;
const Lock lock(m_initializing);
const double max = value.toDouble();
for (auto* hist : m_curvesList)
hist->setBinRangesMax(max);
bool ok;
const double max{QLocale().toDouble(value, &ok)};
if (ok) {
for (auto* hist : m_curvesList)
hist->setBinRangesMax(max);
}
}
//Line tab
......@@ -1213,7 +1220,7 @@ void HistogramDock::errorBarsCapSizeChanged(double value) const {
if (m_initializing)
return;
float size = Worksheet::convertToSceneUnits(value, Worksheet::Unit::Point);
double size = Worksheet::convertToSceneUnits(value, Worksheet::Unit::Point);
for (auto* curve : m_curvesList)
curve->setErrorBarsCapSize(size);
}
......@@ -1263,7 +1270,7 @@ void HistogramDock::errorBarsOpacityChanged(int value) const {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* curve : m_curvesList)
curve->setErrorBarsOpacity(opacity);
}
......@@ -1313,7 +1320,7 @@ void HistogramDock::fillingOpacityChanged(int value) {
if (m_initializing)
return;
qreal opacity = (float)value/100.;
qreal opacity = (double)value/100.;
for (auto* curve : m_curvesList)
curve->setFillingOpacity(opacity);
}
......@@ -1366,10 +1373,10 @@ void HistogramDock::curveBinCountChanged(int count) {
m_initializing = false;
}
void HistogramDock::curveBinWidthChanged(float width) {
void HistogramDock::curveBinWidthChanged(double width) {
if (m_initializing)return;
const Lock lock(m_initializing);
ui.leBinWidth->setText(QString::number(width));
ui.leBinWidth->setText(QLocale().toString(width));
}
void HistogramDock::curveAutoBinRangesChanged(bool value) {
......@@ -1381,13 +1388,13 @@ void HistogramDock::curveAutoBinRangesChanged(bool value) {
void HistogramDock::curveBinRangesMinChanged(double value) {
if (m_initializing)return;
const Lock lock(m_initializing);
ui.leBinRangesMin->setText(QString::number(value));
ui.leBinRangesMin->setText(QLocale().toString(value));
}
void HistogramDock::curveBinRangesMaxChanged(double value) {
if (m_initializing)return;
const Lock lock(m_initializing);
ui.leBinRangesMax->setText(QString::number(value));
ui.leBinRangesMax->setText(QLocale().toString(value));
}
//Line-Tab
......@@ -1562,13 +1569,12 @@ void HistogramDock::curveFillingFileNameChanged(QString& filename) {
ui.leFillingFileName->setText(filename);
m_initializing = false;
}
void HistogramDock::curveFillingOpacityChanged(float opacity) {
void HistogramDock::curveFillingOpacityChanged(double opacity) {
m_initializing = true;
ui.sbFillingOpacity->setValue( round(opacity*100.0) );
m_initializing = false;
}
//"Error bars"-Tab
void HistogramDock::curveErrorTypeChanged(Histogram::ErrorType type) {
m_initializing = true;
......
src/kdefrontend/dockwidgets/HistogramDock.h
View file @ e0e46e86
......@@ -148,7 +148,7 @@ private slots:
void curveOrientationChanged(Histogram::HistogramOrientation);
void curveBinningMethodChanged(Histogram::BinningMethod);
void curveBinCountChanged(int);
void curveBinWidthChanged(float);
void curveBinWidthChanged(double);
void curveAutoBinRangesChanged(bool);
void curveBinRangesMinChanged(double);
void curveBinRangesMaxChanged(double);
......@@ -191,7 +191,7 @@ private slots:
void curveFillingFirstColorChanged(QColor&);
void curveFillingSecondColorChanged(QColor&);
void curveFillingFileNameChanged(QString&);
void curveFillingOpacityChanged(float);
void curveFillingOpacityChanged(double);
//"Error bars"-Tab
void curveErrorTypeChanged(Histogram::ErrorType);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment