Satellites: Do not trigger default setting in constructor to avoid bad data

parent f50e86eb
......@@ -46,7 +46,16 @@ SatellitesPlugin::SatellitesPlugin( const MarbleModel *marbleModel )
m_configDialog, SLOT(setDialogActive(bool)) );
setVisible( false );
setSettings( QHash<QString, QVariant>() );
// TODO: due to the async fetching of data sources there is some race condition
// on multiple calls of this method, this needs some closer look
// The plugin used to call here
// setSettings( QHash<QString, QVariant>() );
// to set some defaults. But this resulted in idList being garbaged with more and more
// duplicated entries of MSC at each app start, as the default setting would trigger
// some addition of ids later on, when in the meantime the setSettings() call from
// the plugin user on startup would set idList with the ids stored from last run.
// For now we just rely on the plugin user calling setSettings and have the default
// set then if needed.
m_showOrbitAction = new QAction( tr( "Display orbit" ), this );
m_showOrbitAction->setCheckable( true );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment