Minor code improvements

src/editor/vocabularydelegate.cpp

@@ -29,7 +29,7 @@ using namespace Editor;
 
 VocabularyDelegate::VocabularyDelegate(QObject *parent)
     : QItemDelegate(parent)
-    , m_translator(0)
+    , m_translator(nullptr)
 {
 }
 

src/scripts/scripting/translation.cpp

@@ -24,10 +24,6 @@ Translation::Translation(KEduVocTranslation *translation)
 {
 }
 
-Translation::~Translation()
-{
-}
-
 QString Translation::wordType() const
 {
     if (m_translation->wordType())

src/scripts/scripting/translation.h

@@ -5,14 +5,12 @@
 #ifndef SCRIPTINGSCRIPTOBJECTTRANSLATION_H
 #define SCRIPTINGSCRIPTOBJECTTRANSLATION_H
 
-#include <KEduVocConjugation>
-#include <KEduVocDeclension>
-
 #include "expression.h"
 #include "text.h"
+#include <KEduVocConjugation>
+#include <KEduVocDeclension>
 #include <KEduVocTranslation>
 #include <KEduVocWordtype>
-
 #include <QObject>
 
 namespace Scripting
@@ -61,8 +59,6 @@ public:
      */
     explicit Translation(KEduVocTranslation *translation);
 
-    ~Translation();
-
     KEduVocTranslation *kEduVocTranslation()
     {
         return m_translation;

src/scripts/translator.cpp

@@ -4,27 +4,18 @@
 */
 #include "translator.h"
 #include "scripting/parley.h"
-
 #include <QDebug>
 
-Translator::Translator()
-    : m_parent(nullptr)
-{
-}
-
 Translator::Translator(QObject *parent)
     : m_parent(parent)
 {
 }
 
-Translator::~Translator()
-{
-}
-
 void Translator::addTranslation(const QString &word, const QString &fromLanguage, const QString &toLanguage, const QString &translation)
 {
-    if (word.trimmed() == QLatin1String(""))
+    if (word.trimmed().isEmpty()) {
         return;
+    }
 
     QString t = word + fromLanguage + toLanguage;
     qDebug() << "Translation for " << word << "in cache: " << m_translations.contains(t);

src/scripts/translator.h

@@ -64,10 +64,7 @@ Keeps the translated words
 class Translator
 {
 public:
-    Translator();
-    explicit Translator(QObject *parent);
-
-    ~Translator();
+    explicit Translator(QObject *parent = nullptr);
 
     /**
      * Stores the translation of @p word from language @p fromLanguage, to language @p toLanguage.