Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit c931d920 authored by Hartmut Riesenbeck's avatar Hartmut Riesenbeck

[Parley] Fix false error message when entering dashboard

Summary:
When entering dashboard with conjugations as current practice mode, an
error message box is shown when no entries are due for practice. It
says: "The vocabulary document contains no entries that can be used for
the chosen type of practice."
For determining the word count of the collection widgets, the
EntryFilter class is used. A missing test for the showDialg flag was
added in the conjugation entries evaluation.

BUG: 387656

Reviewers: #kde_edu, apol

Reviewed By: apol

Subscribers: apol

Tags: #kde_edu

Differential Revision: https://phabricator.kde.org/D9246
parent 21da13e7
......@@ -148,7 +148,7 @@ QList<TestEntry*> EntryFilter::entries(bool showDialog)
// lists of EduVocTranslations.
if (Prefs::practiceMode() == Prefs::EnumPracticeMode::ConjugationPractice) {
QList< TestEntry* > ret = conjugationTestEntries(ignoreBlocked);
if (ret.count() == 0) {
if ((ret.count() == 0) && showDialog) {
KMessageBox::error(0, noEntriesError);
}
return ret;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment