Commit c2eaf9ef authored by Thorsten Zachmann's avatar Thorsten Zachmann

Fix memory leaks

==31293== 1,708 (136 direct, 1,572 indirect) bytes in 1 blocks are definitely lost in loss record 2,039 of 2,111
==31293==    at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31293==    by 0x6B512A1: QObject::QObject(QObject*) (qobject.cpp:721)
==31293==    by 0x8767D6D: KoCharacterStyle::KoCharacterStyle(QObject*) (KoCharacterStyle.cpp:343)
==31293==    by 0x8773CDF: KoParagraphStyle::KoParagraphStyle(QObject*) (KoParagraphStyle.cpp:97)
==31293==    by 0x7F6E40C: KoTextShapeData::loadStyle(KoXmlElement const&, KoShapeLoadingContext&) (KoTextShapeData.cpp:331)
==31293==    by 0x8B8EDDD: KoTosContainer::loadText(KoXmlElement const&, KoShapeLoadingContext&) (KoTosContainer.cpp:88)
==31293==    by 0x22E762B6: EnhancedPathShape::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (EnhancedPathShape.cpp:585)
==31293==    by 0x8B3C5D0: KoShapeFactoryBase::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoShapeFactoryBase.cpp:228)
==31293==    by 0x8B38735: KoShapeRegistry::Private::createShapeInternal(KoXmlElement const&, KoShapeLoadingContext&, KoXmlElement const&) const (KoShapeRegistry.cpp:313)
==31293==    by 0x8B382BB: KoShapeRegistry::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) const (KoShapeRegistry.cpp:268)
==31293==    by 0x1D047D12: KoPAPageBase::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoPAPageBase.cpp:212)
==31293==    by 0x1CD5DBEA: KPrPage::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KPrPage.cpp:126)

here the default style is not freed as the paragraph styles.

REVIEW: 106154
parent 0162105d
......@@ -48,8 +48,7 @@ KoInteractionStrategy::KoInteractionStrategy(KoInteractionStrategyPrivate &dd)
KoInteractionStrategy::~KoInteractionStrategy()
{
Q_D(KoInteractionStrategy);
delete d;
delete d_ptr;
}
void KoInteractionStrategy::handleCustomEvent(KoPointerEvent *event)
......
......@@ -360,6 +360,7 @@ void KoTextShapeData::loadStyle(const KoXmlElement &element, KoShapeLoadingConte
d->paragraphStyle = new KoParagraphStyle(format, cformat);
qDeleteAll(paragraphStyles);
delete defaultStyle;
}
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment