1. 26 Jun, 2018 2 commits
  2. 25 Jun, 2018 18 commits
    • Wolthera van Hövell's avatar
      CPMT: Fix the exporter so it produces clean acbf files. · 3931309d
      Wolthera van Hövell authored
      The output files are verified against the acbf-1.1.xsd
      
      Only two errors remain:
      
      1. Keyword element cannot appear multiple times according to the xsd, but
         this should be possible according to the spec, once for each translation.
      2. References cannot have language tags in 1.1, but they can in 1.2. I'll
         leave this for now.
      
      Other than that this replaces the spaces with underlines because spaces are annoying
      in the command line.
      3931309d
    • Dmitry Kazakov's avatar
      Fix initialization of the global assistants color · d8373ce4
      Dmitry Kazakov authored
      1) KisDocument is a 'model' of global color
      2) KisPaintingAssistantsDecoration is a 'controller' of global color
      3) KisPaintingAssistant is a 'view' of global color
      
      Decoration is responsible for updating the global color cache
      of global color in all the assistants.
      d8373ce4
    • Dmitry Kazakov's avatar
      Save global color to KRA file · a0654953
      Dmitry Kazakov authored
      Summary:
      This is a patch on top of my custom colors patch.
      
      The shared/global assistant color for painting assistants is stored outside of the assistant data model. Because of this I had to add a new property to save to in the KRA saver and loader.
      
      I also had to fix up a few initialization areas in the UI so the loaded values didn't get wiped out.
      
      I also removed a couple "legacy" comments in the KRA saver that got me confused. boud confirmed that those notes were in the calligra days
      
      Test Plan:
      Have multiple assistants. A couple with a shared color and one with a custom color.
      
      Saved and loaded the file and made sure it kept the same value.
      
      Reviewers: #krita, dkazakov
      
      Subscribers: dkazakov
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13437
      a0654953
    • Dmitry Kazakov's avatar
      Remove an assert that breaks some code · 5b76f0f7
      Dmitry Kazakov authored
      Some code expects end() to return raw value for saving/loading
      
      CCBUG:395378
      5b76f0f7
    • Dmitry Kazakov's avatar
      Fix resetting profile when changing desktop on Unity · 5715c348
      Dmitry Kazakov authored
      We should use homogenous functions for checking if the screen has
      changed.
      5715c348
    • Halla Rempt's avatar
      Update gmic to 2.3.0 · a75f0683
      Halla Rempt authored
      a75f0683
    • Jonathan Liu's avatar
      Do not scroll pop-up palette when setting document offset · befdf29e
      Jonathan Liu authored
      Summary:
      QWidget::scroll(int dx, int dy) will scroll the widget including its
      children. Since KisPopupPalette is a child of KisQPainterCanvas when
      using the QPainter-based canvas we want to scroll only the widget
      and not its children by calling QWidget::scroll(int dx, int dy,
      const QRect &r) instead.
      
      BUG:395375
      
      Test Plan:
      1. Click Settings > Configure Krita > Display
      2. Uncheck "Canvas Graphics Acceleration" and click OK
      3. File > New to create new document
      4. Click "Freehand Brush Tool"
      5. Right-click on canvas, rotate using wheel. The popup should not move.
      6. Right-click on canvas, reset rotation by clicking at top circle of wheel. The popup should not move.
      7. Right-click on canvas, zoom using zoom slider. The popup should not move.
      8. Right-click on canvas, reset zoom to 100% by clicking "100%" button. The popup should not move,.
      
      Reviewers: #krita, dkazakov
      
      Reviewed By: #krita, dkazakov
      
      Subscribers: dkazakov, #krita
      
      Tags: #krita
      
      Differential Revision: https://phabricator.kde.org/D13703
      befdf29e
    • L. E. Segovia's avatar
      Fix PyKrita library search path for MacOS · 43d649da
      L. E. Segovia authored
      If Krita detects that its embedded Python comes from a system
      installation, it must preserve the original search path (Py_GetPath)
      and append the PyKrita module paths.
      
      This prevents PyKrita from not being able to find the 'sip' and
      'encodings' modules, which in turn cause the Python engine to
      fail to initialize and to outright crash, respectively.
      
      Differential Revision: https://phabricator.kde.org/D13682
      43d649da
    • Dmitry Kazakov's avatar
      Change asserts into normal checks · f1dcbd1b
      Dmitry Kazakov authored
      Sometimes (during merge/grouping/ungrouping) it happens that active node
      is changed by the model. The model knows only about a dummy, but not about
      the node itself. And the node might have already become disconnected, even
      though the dummy is still present.
      
      BUG:395751
      f1dcbd1b
    • Dmitry Kazakov's avatar
      Fix activation of a brush preset when it is selected by a dragging action · 16d83d74
      Dmitry Kazakov authored
      NOTE: please let this patch to be tested for a couple of weeks before
            merging it into 4.1.
      
      KoResourceItemChooser::activated() we should check the actual resource
      that is passed to a function instead of requesting the currently selected,
      because it might still be not updated (when calling this function in
      selectionChanged() callback).
      
      BUG:394440
      16d83d74
    • Dmitry Kazakov's avatar
      Transform invisible layers that are a part of a group · 5fbadb60
      Dmitry Kazakov authored
      (don't transform invisible root layer, though)
      
      BUG:393617
      5fbadb60
    • Dmitry Kazakov's avatar
      Fix continued transform of a group when some layers are hidden · 6d7e160d
      Dmitry Kazakov authored
      When some layers of a group are hidden/locked, not all of the will
      be transformed by the transform tool. We should not continue the
      previous command if a set of layers is different.
      
      CCBUG:393617
      6d7e160d
    • Halla Rempt's avatar
      Remove unused items in kis_vec.h · 2dd3f0ee
      Halla Rempt authored
      2dd3f0ee
    • Halla Rempt's avatar
      Remove obsolete todo · b84b67c6
      Halla Rempt authored
      b84b67c6
    • Dmitry Kazakov's avatar
      Correctly invalidate frames when moving a Clone Layer · 6c23ac4c
      Dmitry Kazakov authored
      When moving a clone layer we should also reset all the frames, because
      it doesn't have any animation channels.
      
      BUG:394510
      6c23ac4c
    • Dmitry Kazakov's avatar
      Fix a crash in an incorrect assert · a50a73c7
      Dmitry Kazakov authored
      a50a73c7
    • Dmitry Kazakov's avatar
      Fix assert when trying to merge down a group with a transform mask · 223f0d2d
      Dmitry Kazakov authored
      We should be very careful about passing node pointers in queued signals.
      Sometimes it may happen that the signal is delivered *after* the node has
      been removed from the layers graph. If it is possible and we should avoid
      that, e.g. activating this node, we should check node's graph listener's
      pointer.
      
      BUG:395003
      223f0d2d
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 9fd3f6b6
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      9fd3f6b6
  3. 24 Jun, 2018 6 commits
  4. 23 Jun, 2018 1 commit
  5. 22 Jun, 2018 1 commit
  6. 21 Jun, 2018 3 commits
    • Scott Petrovic's avatar
    • Halla Rempt's avatar
      Remove the recorder · ea4b85f5
      Halla Rempt authored
      We've been disabling this in releases since forwever because itr was
      never even nearly finished: for instance, the wdgpaintactioneditor form
      was never used anywhere, most tools didn't implement the special
      recording code, all of our actions were never recorded.
      
      A design where extra code has to be added in multiple places for every
      single thing that we want to record isn't going to work.
      
      If we want to do a recorder, we should start thinking about how we can
      do this in a generic way, by having the UI generate xml or json that gets
      recorded and executed: I guess we'd need to add some kind of interpreter
      at the heart of Krita. But this is a dead end...
      
      CCMAIL:kimageshop@kde.org
      ea4b85f5
    • Burkhard Lück's avatar
      fic broken appdata.xml · 0708470a
      Burkhard Lück authored
      0708470a
  7. 20 Jun, 2018 9 commits