1. 16 Sep, 2019 6 commits
  2. 15 Sep, 2019 1 commit
  3. 14 Sep, 2019 7 commits
    • Dmitry Kazakov's avatar
      Make OCIO warning shorter: floating message is shorter than message box · 68fe323b
      Dmitry Kazakov authored
      Thes commit cannot go to Krita 4.2, becasue it changes translatable
      string. Therefore it goes as a separate commit.
      68fe323b
    • Dmitry Kazakov's avatar
      Fix crash when converting color space with OCIO enabled · ccc25f2e
      Dmitry Kazakov authored
      The crash happened because of recursive entrance into
      KisOpenGLImageTextures when a message box was opened. This
      patch removes a message box and adds nitification with a floating
      message.
      
      BUG:411045
      ccc25f2e
    • Agata Cacko's avatar
      Revert "Remove KisTool::notifyMdified" · d0602e63
      Agata Cacko authored
      This reverts commit 8ef85fdd.
      
      This commit fixes issue with autosave only saving once per manual save.
      Possibly it also fixes the issue with editing time being way lower
      than expected.
      
      ---
      
      Mentioned commit removed sending signal KisImage->notifyModified()
      by KisFreehandTool. Turned out that signal was important for autosave
      to work correctly and _possibly_ for counting time spent on the painting.
      
      Theoretically this signal should be also sent by strokes, rendering
      sending signal here redundant (hence the previous commit with
      "It is not used anymore" message). This requires further investigation
      and then recommitting these changes after making sure all logic is
      performed as before.
      
      Looks like the course of action with the signal from the Freehand tool was
      as follows:
      
         Freehand Tool sends ModifiedSignal
      -> Image Signal Router sends sigImageModified()
      -> KisDocument catches it and calls setModified( undoStackNotEmpty )
      -> KisDocument does a lot of logic and then sends modified()
      
      Supposedly strokes call KisDocument::setModified(...), at least on master.
      I can't confirm it because I didn't check the relevant code yet.
      But if that's true, that should be enough - all relevant logic happens
      inside this function. On the other hand, practice seems to prove
      otherwise...
      
      BUG:411631
      d0602e63
    • Dmitry Kazakov's avatar
    • Dmitry Kazakov's avatar
      Update Qt to 5.12.5 on OSX · e284cdf6
      Dmitry Kazakov authored
      OSX QStandardPaths patch has been merged upstream
      e284cdf6
    • Dmitry Kazakov's avatar
      Update Qt to 5.12.5 on Windows and Linux · b833dd0c
      Dmitry Kazakov authored
      0050-Fix-using-tablet-on-QML-widgets.patch is now broken, we need to
      fix the bug again.
      b833dd0c
    • Raghavendra Kamath's avatar
      Cleanup the svg and add license in the svg · 3e21da98
      Raghavendra Kamath authored
      - Removed unused definitions and removed the unecessary information such as export path from
      original authors system
      - Saved the svg in plain svg format to reduce the size
      - Svgs are now migrated to new inkscape dpi
      - Changed the license to CC-BY-SA 4.0 like other svg in the repo earlier the license was proprietary.
      3e21da98
  4. 13 Sep, 2019 5 commits
    • Agata Cacko's avatar
      Fix curve changing with sensors w/ Use Same Curve · 542da22b
      Agata Cacko authored
      Before this commit, curve would change semi-randomly in some cases
      if you change from some specific sensors to some other specific sensors
      (having a complex curve and clicking randomly should show a bug though)
      when "Share curve across all settings" is selected.
      This commit fixes that behaviour.
      
      BUG:383909
      CCBUG:410158
      542da22b
    • Agata Cacko's avatar
      Replace cache with a new variable in curve option · 43c2bad8
      Agata Cacko authored
      Before this commit, "Use the same curve" (precisely,
      "Share curve across all settings") was done using
      (1) rewriting values in sensors to the selected curve
      (2) cached curves for all the sensors in case the user changes
      their mind and wants the previous ones.
      
      This behaviour brings confusion and is hard to debug, hence
      the change.
      
      This commit adds a new separate variable that keeps the
      "common curve", so all sensors has their own curves.
      There is no need for caching or restoring, it just needs
      to be clear that when the Use The Same Curve checkbox is
      checked, the value from the common curve needs to be taken
      instead of the curve from the sensor in question.
      43c2bad8
    • Dmitry Kazakov's avatar
      Fix crash when Colorize Tool is active on closing Krita · 78ea95b5
      Dmitry Kazakov authored
      Steps to reproduce:
      1) Create a layer with colorize mask
      2) Disable "Show key strokes" on the mask (important)
      3) Select "Colorize Tool"
      4) Click on the mask, to lazily activate key strokes
      5) Close Krita -> Crash
      
      The crash happened because of some weird update signals coming
      after KisView was actually destroyed.
      78ea95b5
    • Dmitry Kazakov's avatar
      Set "Show in Timeline" to "on" by default · 3def70fa
      Dmitry Kazakov authored
      During the sprint we discussed that with painters and they said that
      it would be much easier for them if all the layers would be visible
      in the timeline by default. If the user can always hide a layer if
      he likes.
      
      CC:kimageshop@kde.org
      3def70fa
    • Dmitry Kazakov's avatar
      Fix using user-setting for Region of Interest Margin · 38480887
      Dmitry Kazakov authored
      The setting was present in KisImageConfig, but was never used in the
      code itself.
      38480887
  5. 12 Sep, 2019 21 commits