BluezQt merge requestshttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests2024-02-15T10:49:02Zhttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/55Fix connecting to org.freedesktop.DBus.ObjectManager InterfacesAdded2024-02-15T10:49:02ZBharadwaj RajuFix connecting to org.freedesktop.DBus.ObjectManager InterfacesAddedThe metatype also needs to be qRegisterMetaType'd in addition to
qDBusRegisterMetaType and Q_DECLARE_METATYPE.
I still don't know why it worked in plasmawindowed though…
BUG: 477633The metatype also needs to be qRegisterMetaType'd in addition to
qDBusRegisterMetaType and Q_DECLARE_METATYPE.
I still don't know why it worked in plasmawindowed though…
BUG: 477633KF6https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/58Add support for manufacturer data in LE advertisements2024-03-28T16:29:02ZPontus SjögrenAdd support for manufacturer data in LE advertisementsManufacturer data in LE advertisements are not currently supported. This PR fixes that.Manufacturer data in LE advertisements are not currently supported. This PR fixes that.https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/57Fixed min_bitpool and max_bitpool from capabilities where ignored2024-03-14T17:04:55ZTobias StannowskiFixed min_bitpool and max_bitpool from capabilities where ignoredThe bit pool might be smaller if a remote devices is connected to a 2.4 GHz Wi-Fi network.The bit pool might be smaller if a remote devices is connected to a 2.4 GHz Wi-Fi network.https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/56Add primary services for LE Audio; BASS, CAS, CSIS, MCS, PACS.2024-03-28T19:04:16ZJohn SchulzAdd primary services for LE Audio; BASS, CAS, CSIS, MCS, PACS.I also aligned the assignments for readability.I also aligned the assignments for readability.https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/54GIT_SILENT Port to new way of including CI templates2023-12-16T11:28:02ZAlbert Astals CidGIT_SILENT Port to new way of including CI templateshttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/53Fix QML unit tests2023-12-05T21:00:52ZVolker Krausevkrause@kde.orgFix QML unit testshttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/52Fix '"__BYTE_ORDER" is not defined, evaluates to 0' warning2023-12-03T11:23:22ZAlbert Astals CidFix '"__BYTE_ORDER" is not defined, evaluates to 0' warninghttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/51Port away from deprecated implicit lambda captures2023-12-02T20:15:17ZVolker Krausevkrause@kde.orgPort away from deprecated implicit lambda captureshttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/50Register QVariantMapMap as metatype2023-10-20T22:13:20ZNicolas FellaRegister QVariantMapMap as metatypeBUG: 472910BUG: 472910https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/49rfkill: Drop return values2023-08-30T17:08:29ZKai Uwe Broulikrfkill: Drop return valuesWriting to rfkill can block for quite some time.
Removing the return values makes it easier to make it asynchronous.
If you want to know whether it succeeded you can just connect
to the stateChanged signal.
---
I probably won’t have t...Writing to rfkill can block for quite some time.
Removing the return values makes it easier to make it asynchronous.
If you want to know whether it succeeded you can just connect
to the stateChanged signal.
---
I probably won’t have the time to actually make it async or in a thread or something but at least prepare the API so we could do that anytime during the 6.x era.
@drosca @nicolasfellahttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/48Remove code variants for building with Qt 62023-08-02T22:13:51ZFriedrich W. H. KossebauRemove code variants for building with Qt 6With the 5 series branched, there is no more purpose for those variants.
And they confuse at least doxygen (but surely also other static code
analyzer).
Done for all modules which have such things in public headers. And consistently the...With the 5 series branched, there is no more purpose for those variants.
And they confuse at least doxygen (but surely also other static code
analyzer).
Done for all modules which have such things in public headers. And consistently there to not make the codebase more strange.https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/47Fix some duplicated/misnamed include guards2023-07-25T17:35:29ZFriedrich W. H. KossebauFix some duplicated/misnamed include guardsFound while playing with unity builds...Found while playing with unity builds...https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/46Use classic header guards consistently2023-07-18T23:24:23ZFriedrich W. H. KossebauUse classic header guards consistentlySneaked in overlapping with !36Sneaked in overlapping with !36https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/45Consistently use std::unique_ptr to life-manage the PIMPL d objects2023-07-03T16:13:41ZFriedrich W. H. KossebauConsistently use std::unique_ptr to life-manage the PIMPL d objectsCatching up to the other KF modules :)Catching up to the other KF modules :)https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/44Use more forward declarations again, given header moc files now included2023-07-07T20:38:54ZFriedrich W. H. KossebauUse more forward declarations again, given header moc files now includedCommit 700a7de8323276ea911233f4f94ebf2a249d54dc added some includes
as needed for property types used in headers whose moc files were
compiled separately in mocs_compilation.cpp. And follow-up commit
d8c5b4a04b959f0f2e37ff7e88f24e190d1f8...Commit 700a7de8323276ea911233f4f94ebf2a249d54dc added some includes
as needed for property types used in headers whose moc files were
compiled separately in mocs_compilation.cpp. And follow-up commit
d8c5b4a04b959f0f2e37ff7e88f24e190d1f842f cleaned up now duplicated
includes in the sources.
With the moc file included by the corresponding source file that is
no longer needed. So this restores the old forward declarations, with
some adaptions to additions meanwhile.
@nicolasfella @apol @mlaurenthttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/43Add explicit moc includes to sources for moc-covered headers2023-06-29T20:26:59ZFriedrich W. H. KossebauAdd explicit moc includes to sources for moc-covered headers* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to s...* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
moc includes generated with script from sdk/kde-dev-scripts!24 + some manual fine-tuning of newlines.
Checked completeness by this running in the toplevel build dir giving `0`:
`find . -name mocs_compilation.cpp -exec cat {} \; | grep "#include" | wc -l`https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/42Include only needed headers instead of QtQml module header2023-06-16T16:41:20ZFriedrich W. H. KossebauInclude only needed headers instead of QtQml module headerNO_CHANGELOGNO_CHANGELOGhttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/41Remove rfkill udev rules2023-05-18T12:43:16ZVolker Krausevkrause@kde.orgRemove rfkill udev rulesThis is meanwhile upstream in udev's own default rules, and causes a
co-installability conflict with KF5.
https://github.com/systemd/systemd/commit/213455e26a6e7fc7a84749474fe906c2a145babeThis is meanwhile upstream in udev's own default rules, and causes a
co-installability conflict with KF5.
https://github.com/systemd/systemd/commit/213455e26a6e7fc7a84749474fe906c2a145babehttps://invent.kde.org/frameworks/bluez-qt/-/merge_requests/40Mark private slot method of public class as unexported2023-03-31T20:58:00ZFriedrich W. H. KossebauMark private slot method of public class as unexportedGiven the slot is marked as private and thus not intended for
external use, exporting the symbol adds some minor unneeded costs
in binary size and linking time, which can be avoided.Given the slot is marked as private and thus not intended for
external use, exporting the symbol adds some minor unneeded costs
in binary size and linking time, which can be avoided.https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/39Unexport more private methods2023-03-21T20:59:20ZFriedrich W. H. KossebauUnexport more private methods0.23 % reduction (1832040 -> 1827752) in stripped binary size in debug build ;)0.23 % reduction (1832040 -> 1827752) in stripped binary size in debug build ;)