Skip to content

GitLab

Switch branch/tag
  1. 27 Sep, 2021 1 commit
    • Alex Richardson's avatar
      Handle git remotes that aren't called origin in _repository_name() · 1dad57d4
      Alex Richardson authored 
      I was seeing `error: No such remote 'origin'` in the cmake output.
This commit avoids hardcoding `origin` as the upstream URL and instead
uses the `git rev-parse @{u}` to get the configured upstream.

As a follow-up we may want to check if this should be executed by default,
but for now this fixes a warning that I'm seeing with various projects.
      1dad57d4
  3. 25 May, 2021 1 commit
  5. 23 Apr, 2021 1 commit
    • Friedrich W. H. Kossebau's avatar
      Modules docs: move rst docs into bracket comments · 5512e035
      Friedrich W. H. Kossebau authored 
      CMake >= 3.0 supports bracket comments, and the reStructuredText
integration code in sphinx/ext/ecm.py already supports extracting
the docs from a bracket comment instead.
Editing documentation without leading line comment markers is more simple,
e,g. when reflowing text over lines.

With ECM meanwhile requiring CMake 3.5 now it is possible to switch
(and thus follow also the approach used by cmake itself).

NO_CHANGELOG
      5512e035
  7. 22 Jan, 2021 1 commit
  9. 01 Nov, 2020 1 commit
    • Volker Krause's avatar
      Make androiddeployqt find libraries and QML plugins without installation · 2135cbdf
      Volker Krause authored 
      This matters for libraries in the same repository as the application that
also have an AAR that needs to be integrated, as well as QML plugins. For
this to work we need to consider the build directory as a search prefix,
and produce the exact directory layout there that androiddeployqt expects.

For libraries this is then almost transparent for the application build
system, the only thing that needs to be taken care of manually is putting
the corresponding -android-dependencies.xml file into the right place in
the build dir as well. A macro wrapping that might be an option to
centralize that logic here as well in the future.

For QML plugins this is transparent if you have them set up to work without
installation already anyway, otherwise that setup has to be done for this
to work.

Example: pim/itinerary!28

knotifications!12 would
presumably also need this (not tested yet).
      2135cbdf
  11. 01 Oct, 2020 1 commit
    • Harald Sitter's avatar
      fix fetch-translations for invent urls · 693781d2
      Harald Sitter authored 
      regex gets slightly adjusted to only run on kde.org urls, the actual
repo name may now contain slash as well since
a) basenames aren't necessarily unique anymore
b) by extension we need to give fetchpo an actually unique repo path so
it can resolve the underlying project and its translations
      693781d2
  13. 14 Jun, 2020 1 commit
  15. 19 Aug, 2019 2 commits
    • Harald Sitter's avatar
      disable autouic again - it breaks builds · 557e5d89
      Harald Sitter authored 
      Summary:
autouic (like automoc) assumes that every ui_*.h include statement it finds
relates to a .ui file that needs generating. this is not always true.

e.g. we have software which generates ui_debug.h which is simply
a qloggingcategory header for the UI category of that software which would
then trip up autouic because it would assume there's a .ui file when there
really isn't one.

unfortunately the ui_ assumption cannot be selectively disabled, so we
can't have explicit listing of .ui in source lists

```
set(foo_SRCS foo.cpp foo.ui)
```

without also getting the not particularly compatible include assumptions.
this should be revisited for kf6 since there isn't a technical need for
files to be called ui_*, they could just as well be *_ui or anything else
so as to not clash with autouic assumption.

autorcc does not suffer from this problem so we can leave it enabled, for
now anyway.

Test Plan: sonnet builds again

Reviewers: apol, nicolasfella, cullmann

Reviewed By: apol

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D23262
      557e5d89
    • Harald Sitter's avatar
      set autorcc and autouic by default · 60ca1a27
      Harald Sitter authored 
      Summary:
I couldn't find any pertinent discussion on the topic but some reviews I
stumbled over did set it on some of our application repos and also wonder
why we don't enable it by default.

autorcc allows more idiomatic use of qrc as they may be used like any
"ordinary" source file and cmake will know what to do with them (namely
compile into relevant cpp for inclusion in target) without the developer
having to worry about anything.

autouic does the same albeit for .ui files.

Test Plan: .qrc files can be added to src list variables and will get automatically generated into cpp files in the binary dir and built into the target

Reviewers: apol

Reviewed By: apol

Subscribers: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22805
      60ca1a27
  17. 22 Feb, 2019 1 commit
  19. 03 Feb, 2019 1 commit
  21. 12 Nov, 2018 1 commit
  23. 24 Sep, 2018 1 commit
  25. 07 Sep, 2018 1 commit
  27. 06 Aug, 2018 1 commit
    • Aleix Pol Gonzalez's avatar
      Make it possible for ECM to detect po files at configure time · 02881711
      Aleix Pol Gonzalez authored 
      Summary:
ECMPoQmTools will need to have the translations downloaded at configure time instead of on build time, otherwise it needs an awkward second configure.
To that end we introduce a KDE_L10N_SYNC_TRANSLATIONS variable that allows it to do so.
ECMPoTools will download the translations in the build directory, because cmake shouldn't touch the sources. Have it check the build directory too when the macro is called.

Test Plan: Built analitza translations.

Reviewers: #frameworks, cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14569
      02881711
  29. 05 Nov, 2017 1 commit
  31. 09 Aug, 2017 3 commits
  33. 20 Apr, 2017 2 commits
  35. 10 Apr, 2017 1 commit
  37. 07 Apr, 2017 3 commits
  39. 06 Apr, 2017 1 commit
    • Aleix Pol Gonzalez's avatar
      Introduce fetch-translations build command · e6222298
      Aleix Pol Gonzalez authored 
      Summary:
Makes it possible to fetch translations when building the project. To do so
it fetches kde:releaseme and uses the new fetchpo.rb program to download the
translations into the build directory.

This should make it much easier to integrate translations in the development
process.

Test Plan: Downloaded and installed translations for some projects

Reviewers: #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter

Reviewed By: sitter

Subscribers: sitter

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D5143
      e6222298
  41. 05 Mar, 2017 1 commit
  43. 01 Feb, 2017 1 commit
  45. 03 Dec, 2016 1 commit
    • Ovidiu-Florin BOGDAN's avatar
      Find the correct path to the cmake command · e630aa98
      Ovidiu-Florin BOGDAN authored 
      Summary: When running tests with hardcoded `cmake`, it get's suffixed to the project's build path. Setting it with an absolute path ensures using the right cmake binary.

Test Plan: Compiled, installed. Used to generate tests for kdev-embedded. `cmake` binary is now prefixed with the absolute system path, and no longer with the project's build dir.

Reviewers: kfunk, #frameworks, apol

Reviewed By: kfunk, apol

Subscribers: kfunk

Differential Revision: https://phabricator.kde.org/D3568
      e630aa98
  47. 16 Nov, 2016 1 commit
  49. 05 Nov, 2016 1 commit
  51. 15 Sep, 2016 1 commit
  53. 31 Aug, 2016 1 commit
  55. 24 Aug, 2016 1 commit
    • Aleix Pol Gonzalez's avatar
      Create a test that validates projects' appstream information · 47d580f9
      Aleix Pol Gonzalez authored 
      At the moment, we're validating it in build.kde.org, but I feel it will be
easier for developers to test if we do so locally.
This patch does it by seeing which *.appdata.xml files are being installed
and validating them. This way we can keep it generic for all KDE projects.

REVIEW: 128533
      47d580f9
  57. 28 Dec, 2015 1 commit
  59. 18 Nov, 2015 1 commit
  61. 13 Oct, 2015 1 commit
  63. 15 Sep, 2015 1 commit
  65. 06 Feb, 2015 1 commit
  67. 04 Feb, 2015 1 commit